[Bug 7346] New: 'perl translate install' creates template directories for invalid languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 Bug #: 7346 Summary: 'perl translate install' creates template directories for invalid languages Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: marc@msys.ch QAContact: ian.walls@bywatersolutions.com When you (e.g. accidentally) try to install a non-existing or invalid language, the translate Perl script will bail out with an error message. But it has already created the language directories under /usr/share/koha/opac/htdocs/opac-tmpl/prog and /usr/share/koha/intranet/htdocs/intranet-tmpl/prog and the (invalid) language code is presented as a choice in the admin I18N/L10N interface. To very, enter perl translate install de-XY. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-12-11 10:56:49 UTC --- Created attachment 6705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6705 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 --- Comment #2 from Marc Balmer <marc@msys.ch> 2011-12-11 11:20:13 UTC --- (In reply to comment #1)
Created attachment 6705 [details] Proposed patch
That patch works fine. I am now trying to sign it off using git, which is a whole different adventure... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 --- Comment #3 from Marc Balmer <marc@msys.ch> 2011-12-11 16:02:01 UTC --- Created attachment 6708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6708 signed off patch This is signed off by me patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 Marc Balmer <marc@msys.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6705|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Patch Pushed Severity|normal |minor --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 17:39:18 UTC --- QA comment: tiny patch, usefull, works passed QA patch pushed, please test Welcome Marc Balmer, you're 167th Marc: you should not have signed-off this patch by yourself. It's a tiny one, works fine, so i'm pushing it. But usually, the sign-off must not be made by the author. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 --- Comment #5 from Marc Balmer <marc@msys.ch> 2011-12-15 17:42:49 UTC --- (In reply to comment #4)
QA comment: tiny patch, usefull, works
passed QA
patch pushed, please test
Welcome Marc Balmer, you're 167th
Marc: you should not have signed-off this patch by yourself. It's a tiny one, works fine, so i'm pushing it. But usually, the sign-off must not be made by the author.
credit whom credit is due: I reported the problem, it was Fréderic Demians who suggested the patch, I did test it and thus signed it off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 09:17:52 UTC --- (In reply to comment #5)
(In reply to comment #4)
QA comment: tiny patch, usefull, works
passed QA
patch pushed, please test
Welcome Marc Balmer, you're 167th
Marc: you should not have signed-off this patch by yourself. It's a tiny one, works fine, so i'm pushing it. But usually, the sign-off must not be made by the author.
credit whom credit is due: I reported the problem, it was Fréderic Demians who suggested the patch, I did test it and thus signed it off.
mmm... right looking at obsolete attachments. But you did something locally that resulted in Frédéric patch being now your's: From: Marc Balmer <marc@msys.ch> If you sign off another patch (I encourage you to do so !), please catch one of us on IRC to try to understand what you've made that can explain this author change, usual git command don't change author ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7346 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in the 3.6 branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org