[Bug 16920] New: sysprefs.sql - missing comma for MaxOpenSuggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 Bug ID: 16920 Summary: sysprefs.sql - missing comma for MaxOpenSuggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 15128 accidentally missed a comma on MaxOpenSuggestions. diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 29ef9c8..c9a7c7e 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -236,6 +236,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('MaxItemsToDisplayForBatchDel','1000',NULL,'Display up to a given number of items in a single item deletionbatch.','Integer'), ('MaxItemsToProcessForBatchMod','1000',NULL,'Process up to a given number of items in a single item modification batch.','Integer'), ('maxItemsInSearchResults','20',NULL,'Specify the maximum number of items to display for each result on a page of results','free'), +('MaxOpenSuggestions','',NULL,'Limit the number of open suggestions a patron can have at once','Integer') ('maxoutstanding','5','','maximum amount withstanding to be able make holds','Integer'), ('maxRecordsForFacets','20',NULL,NULL,'Integer'), ('maxreserves','50','','Define maximum number of holds a patron can place','Integer'), This just adds it in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15128 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 53391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53391&action=edit Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions TEST PLAN --------- 1) back up DB 2) drop database koha_library; 3) create database koha_library; 4) run web browser install, choose ALL defaults -- notice the SQL syntax warning. 5) apply patch 6) repeat steps 2-4 -- notice SQL syntax warning is gone. 7) run koha qa test tools 8) restore db -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53391|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 53392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53392&action=edit Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions TEST PLAN --------- 1) back up DB 2) drop database koha_library; 3) create database koha_library; 4) run web browser install, choose ALL defaults -- notice the SQL syntax warning. 5) apply patch 6) repeat steps 2-4 -- notice SQL syntax warning is gone. 7) run koha qa test tools 8) restore db Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53392|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 53393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53393&action=edit Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions TEST PLAN --------- 1) back up DB 2) drop database koha_library; 3) create database koha_library; 4) run web browser install, choose ALL defaults -- notice the SQL syntax warning. 5) apply patch 6) repeat steps 2-4 -- notice SQL syntax warning is gone. 7) run koha qa test tools 8) restore db Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 [Bug 14407] Limit web-based self-checkout to specific IP addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org