[Bug 17229] New: ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Bug ID: 17229 Summary: ILS-DI HoldTitle and HoldItem should check if patron is expired Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Web services Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org ILS-DI HoldTitle and HoldItem don't check patron category setting BlockExpiredPatronOpacActions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 55059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55059&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 55060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55060&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Julian Sorry but patch does not apply anymore Applying: Bug 17229: Check if patron is expired in CanItemBeReserved Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Failed to merge in the changes. Patch failed at 0001 Bug 17229: Check if patron is expired in CanItemBeReserved When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17229-Check-if-patron-is-expired-in-CanItemBeR-oomixj.patch You should do this one dependent of bug 16246 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55059|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 62036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62036&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55060|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 62037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62037&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Héctor Eduardo Castro Avalos from comment #3)
You should do this one dependent of bug 16246
Why ? They seem to be independent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m --- Comment #8 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67324&action=edit screenshot with the number saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #9 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67325&action=edit screenshot with the number removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a small conflict in Reserves.pm. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62036|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 70682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70682&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62037|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 70683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70683&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70682|0 |1 is obsolete| | --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72970&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70683|0 |1 is obsolete| | --- Comment #14 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72971&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, can you please add a test plan for this to your commit message? Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal CC| |victor.grousset@biblibre.co | |m --- Comment #16 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Changed from minor to normal as bypassing expiration check (important circulation rule) is bad -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17247 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Pushed for QA --- Comment #17 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- How to test : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1234&bib_id=5678&request_location='127.0.0.1' Should not create a new hold for the patron and report an error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72970|0 |1 is obsolete| | --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85064&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Not sure what I did is right but rebased this patch so that it applies to branch master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72971|0 |1 is obsolete| | --- Comment #20 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85065&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85065|0 |1 is obsolete| | --- Comment #21 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85066&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85066|0 |1 is obsolete| | --- Comment #22 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85070&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85070|0 |1 is obsolete| | --- Comment #23 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85071&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85064|0 |1 is obsolete| | --- Comment #24 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85072&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11999 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85072|0 |1 is obsolete| | --- Comment #25 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85118&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Added test plan to commit message : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1234&bib_id=5678&request_location='127.0.0.1' Should not create a new hold for the patron and report an error. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about reserve/request.tt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same question from me - as this changes a core routine not only used for ILS-DI, what are the consequences in the GUI? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny issue: FAIL t/db_dependent/Holds.t OK critic FAIL forbidden patterns forbidden pattern: tab char (line 142) OK git manipulation OK pod OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #29 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Patch also impacts holds submitted through Intranet, need reworks... Maybe doing the check in ILSDI/Services.pm instead of Reserves.pm would do the job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85118|0 |1 is obsolete| | --- Comment #30 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 85883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85883&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Added test plan to commit message : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1234&bib_id=5678&request_location='127.0.0.1' Should not create a new hold for the patron and report an error. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #31 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Hi :) To preserve the validity of the sign off (and other reasons which I don't remember ^^"), it's usual to do followup patches instead of amending the signed one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #32 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- You need to reconsider the unit test patch. Move to t/db_dependent/ILSDI_Services.t maybe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #33 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 89760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89760&action=edit Bug 17229: moved UnitTest to t/db_dependant/ILSDI_Service.t This reverts commit c968aabc865e9fb9397547f5c12f0017337f7b77. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #34 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Moved unit tests :) Didn't amend previous patch for tests this time ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED Depends on| |23710 CC| |magnus@libriotech.no --- Comment #35 from Magnus Enger <magnus@libriotech.no> --- This can not really be tested before this bug is fixed: Bug 23710 - Holds broken, displays a JSON page with an error Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 [Bug 23710] Holds broken, displays a JSON page with an error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Bug 17229 depends on bug 23710, which changed state. Bug 23710 Summary: Holds broken on intranet, displays a JSON page with an error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #36 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Magnus Enger from comment #35)
This can not really be tested before this bug is fixed: Bug 23710 - Holds broken, displays a JSON page with an error
this bug has been resolved fixed :) Also this could have been tested using curl and trying to put a hold through ILS-DI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #37 from David Nind <david@davidnind.com> --- Patch no longer applies Applying: Bug 17229: Add unit test for BlockExpiredPatronOpacActions check .git/rebase-apply/patch:41: space before tab in indent. dateexpiry => '2000-01-01', warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M t/db_dependent/Holds.t .git/rebase-apply/patch:41: space before tab in indent. dateexpiry => '2000-01-01', .git/rebase-apply/patch:56: new blank line at EOF. + warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds.t CONFLICT (content): Merge conflict in t/db_dependent/Holds.t error: Failed to merge in the changes. Patch failed at 0001 Bug 17229: Add unit test for BlockExpiredPatronOpacActions check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #38 from David Nind <david@davidnind.com> --- You get an error on the patron's page when following the test plan, but before trying to apply the patch - the URL is entered: 1) For the patron, the holds tab heading shows that there is a hold (1). 2) When you click on the patron's holds tab a message pops up with "DataTables warning: table id=holds-table - Ajax error. For more information about this error, please see http://datatables.net/tn/7" 3) The bibliographic record shows that there is a hold. Other notes for testing: - Enable the ILS-DI system preference - The BlockExpiredPatronOpacActions system preference options are now 'Block' and 'Don't block', rather then 'ON' - For the URL, enter the bibliographic record id, not an individual item id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85071|0 |1 is obsolete| | --- Comment #39 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 99701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99701&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85883|0 |1 is obsolete| | --- Comment #40 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 99702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99702&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Added test plan to commit message : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1234&bib_id=5678&request_location='127.0.0.1' Should not create a new hold for the patron and report an error. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89760|0 |1 is obsolete| | --- Comment #41 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 99703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99703&action=edit Bug 17229: moved UnitTest to t/db_dependant/ILSDI_Service.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi David, I've rebased the patch on master, should now applies fine (and I don't have the error on Holds tab in patroninfo page anymore. Kind regards, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99701|0 |1 is obsolete| | --- Comment #43 from David Nind <david@davidnind.com> --- Created attachment 99817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99817&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99702|0 |1 is obsolete| | --- Comment #44 from David Nind <david@davidnind.com> --- Created attachment 99818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99818&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Added test plan to commit message : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1234&bib_id=5678&request_location='127.0.0.1' Should not create a new hold for the patron and report an error. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99703|0 |1 is obsolete| | --- Comment #45 from David Nind <david@davidnind.com> --- Created attachment 99819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99819&action=edit Bug 17229: moved UnitTest to t/db_dependant/ILSDI_Service.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #46 from David Nind <david@davidnind.com> --- Hi Arthur. Just confirming this works. I have created bug 24769 for the DataTables error on the patron's hold page: - this does not occur in 19.11.x; and - this error occurs before applying your patch. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is blocked by bug 24841. Both implementations must be identical. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26463 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #48 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Implementation here is the same as in BZ 17247 which is refered to by 24841... I've rebased the patch on current master, hopping it may pass. If not, can you be more precise on the changes needed for this bz to pass? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99817|0 |1 is obsolete| | Attachment #99818|0 |1 is obsolete| | Attachment #99819|0 |1 is obsolete| | --- Comment #49 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 113741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113741&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #50 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 113742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113742&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Added test plan to commit message : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1234&bib_id=5678&request_location='127.0.0.1' Should not create a new hold for the patron and report an error. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #51 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 113743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113743&action=edit Bug 17229: moved UnitTest to t/db_dependant/ILSDI_Service.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Arthur Suzuki from comment #48)
Implementation here is the same as in BZ 17247 which is refered to by 24841... I've rebased the patch on current master, hopping it may pass. If not, can you be more precise on the changes needed for this bz to pass?
I've tried to explain on bug 24841 comment 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113741|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115081&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113742|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115082&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too Added test plan to commit message : -Set Syspref BlockExpiredPatronOpacActions to "ON", -Set a patron's category variable "Block expired patrons" to "Follow SysPref" or -"Block" (ideally test both). -Get the id of a patron from this category (ie : 1234). -Set this patron's expiration date to a date earlier than today. -Get a biblionumber which can be reserved (ie : 5678). Put the following string in your webbrowser (replacing OpacBaseUrl, 1234 and 5678 by your own values) : http://[OpacBaseUrl]/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1234&bib_id=5678&request_location='127.0.0.1' Should not create a new hold for the patron and report an error. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113743|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115083&action=edit Bug 17229: moved UnitTest to t/db_dependant/ILSDI_Service.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, change of functionality but not a regression. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't think my concerns have been taken into account. QA please have a look at bug 24841 comment 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #57)
I don't think my concerns have been taken into account. QA please have a look at bug 24841 comment 4.
I think this fix is okay. Current code for this check exists in the opac scripts and not the modules. Possibly these checks should be moved to the modules, but that is a larger refactoring. ILS-DI behaviour vs REST API behaviour I think are expected to be different. ILS-DI is unprivileged but meant to act as the OPAC itself (these functions live in Level 3: Elementary OPAC alternative) and presumes the caller has sorted out the rights etc. The REST API is called by a user - that user's privileges decide whether the action can be completed or not. Moving the check into CanItemBeReserved means we need to make that function interface aware and is a bigger change TL/DR: BlockExpiredOpacActions should affect the opac only, ILS-DI is the OPAC, REST API is not -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Here the behaviours are expected to be the same (between ILSDI and REST API), the existence of bug 24841 is proving it. If we go with this patch we will have to fix bug 24841 anyway, and what are we going to do? Add the checks to the controller? So we will end up with the same checks at 3 different places, with eventually other places where the checks are missing. I know it's more work to have things done properly, but it's not a good pro argument :D I don't think I am convinced yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #59)
Here the behaviours are expected to be the same (between ILSDI and REST API), the existence of bug 24841 is proving it.
Unless that bug is incorrect? The holds route is privileged, not public - it behaves as staff, not as OPAC - so it doesn't check if patron restricted/debarred, I will add this comment to that bug
If we go with this patch we will have to fix bug 24841 anyway, and what are we going to do? Add the checks to the controller?
We have to decide what we want to do yes, but we shouldn't enforce that conversation here
I know it's more work to have things done properly, but it's not a good pro argument :D
I don't see it as doing things properly, but fixing a confirmed bug here and making architecture decisions later. We should work towards deprecating ILSDI, but until then we should allow for fixing these outstanding issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Will push as it, but I don't think we are going in the right direction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #63 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115411&action=edit Bug 17229: Fix unit test warning Remove warning : t/db_dependent/ILSDI_Services.t .. 3/10 Null value for biblionumber in Item not allowed at /home/koha/src/t/lib/TestBuilder.pm line 387 $biblio_with_no_item is a Koha::Biblio object. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master for 21.05.00, thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115435&action=edit Bug 17229: Fix perlcritic on ILSDI_Services.t Subroutine "new" called using indirect syntax at line 456, column 14. See page 349 of PBP. (Severity: 4) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master for 21.05.00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #67 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #68 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm getting test failures when trying to apply this to 20.05. Please address for backport. Here's what I see: $ prove t/db_dependent/ILSDI_Services.t t/db_dependent/ILSDI_Services.t .. 1/10 Use of bare << to mean <<"" is deprecated at t/db_dependent/ILSDI_Services.t line 452. Use of bare << to mean <<"" is deprecated at t/db_dependent/ILSDI_Services.t line 452. Bareword found where operator expected at t/db_dependent/ILSDI_Services.t line 466, near "HEAD is" (Might be a runaway multi-line << string starting on line 459) (Do you need to predeclare HEAD?) Global symbol "$module" requires explicit package name (did you forget to declare "my $module"?) at t/db_dependent/ILSDI_Services.t line 454. Global symbol "$module" requires explicit package name (did you forget to declare "my $module"?) at t/db_dependent/ILSDI_Services.t line 455. Global symbol "$issue" requires explicit package name (did you forget to declare "my $issue"?) at t/db_dependent/ILSDI_Services.t line 456. Global symbol "$origin_branch" requires explicit package name (did you forget to declare "my $origin_branch"?) at t/db_dependent/ILSDI_Services.t line 463. syntax error at t/db_dependent/ILSDI_Services.t line 466, near "HEAD is" syntax error at t/db_dependent/ILSDI_Services.t line 466, near ""Patron has issued same book" )" Global symbol "$reply" requires explicit package name (did you forget to declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 467. Global symbol "$biblio_with_no_item" requires explicit package name (did you forget to declare "my $biblio_with_no_item"?) at t/db_dependent/ILSDI_Services.t line 490. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 495. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 496. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 497. Global symbol "$biblio_with_no_item" requires explicit package name (did you forget to declare "my $biblio_with_no_item"?) at t/db_dependent/ILSDI_Services.t line 497. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 498. Global symbol "$reply" requires explicit package name (did you forget to declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 500. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 500. Global symbol "$reply" requires explicit package name (did you forget to declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 501. syntax error at t/db_dependent/ILSDI_Services.t line 503, near ">>" t/db_dependent/ILSDI_Services.t has too many errors. # Looks like your test exited with 255 just after 1. t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 9/10 subtests Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 10 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.67 cusr 0.14 csys = 0.84 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org