[Bug 5870] New: Enhancements to suggestions management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Bug #: 5870 Summary: Enhancements to suggestions management Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Blocks: 5580 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-15 23:54:36 UTC --- * changing suggestedy management * adding a new status field & filter -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-15 23:56:22 UTC --- Created attachment 3308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3308 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-03-16 14:13:28 UTC --- I'm getting a JS error on suggestion.pl: document.getElementById("quantity") is null /intranet-tmpl/prog/en/js/acq.js Line 686 Perhaps because I have no suggestions? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Does not apply --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-16 16:26:03 UTC --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5870 : suggestion management enhancements fatal: corrupt patch at line 138 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5870 : suggestion management enhancements When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-03-16 16:31:56 UTC --- It applied fine for me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-03-16 17:11:52 UTC --- Did you pull from master this morning before applying? Not sure why it's not applying on mine - guess we need someone else to test. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Does not apply |Signed Off --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-24 09:09:34 UTC --- It applies fine for me too and it works well. Signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-27 07:56:36 UTC --- Julian, did you test the error Owen was getting. Id like this error investigated before I push it to master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-28 01:32:18 UTC --- Attaching a follow up patch, * followup debug suggestion management : "accepted by" was not correctly displayed on suggestion's edit page * suggestion's status, document's type and "accepted by" was not correctly displayed on suggestion's edit page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-28 01:34:24 UTC --- Created attachment 3450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3450 Followup patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-28 07:21:11 UTC --- (In reply to comment #8)
Julian, did you test the error Owen was getting. Id like this error investigated before I push it to master
I didn't manage to reproduce the bug, even with no suggestions. So I can't tell you more about this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-02 06:44:12 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5870 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org