[Bug 39441] New: Staff interface cart has wrong max-width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Bug ID: 39441 Summary: Staff interface cart has wrong max-width Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org The staff interface cart "looks funny" at the moment. It's all bunched up on the left side. I'd say the reason is that the max-width for .container from staff-global.css is being applied which restricts it to 540px. I reckon we should add a class or ID to override the max-width for the cart to always be 100%. -- Curious what you think of this one, Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff interface cart has |Some staff interface |wrong max-width |templates have | |div.container instead of | |div.container-fluid Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The Bootstrap class ".container" gives you a <div> with a maximum width. We always want the main part of the page to be full width, using offset classes when necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some staff interface |Some templates have |templates have |div.container instead of |div.container instead of |div.container-fluid |div.container-fluid | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182776&action=edit Bug 39441: Some templates have div.container instead of div.container-fluid This patch updates a few templates so that div.container is replaced with div.container-fluid. div.container gives us a fixed maximum width that isn't consistent the rest of Koha. To test, apply the patch and go to the staff interface. - Perform a catalog search which will return multiple results. - In the search results, check multiple results and click "Add to cart." - Click the cart icon in the top menu to trigger the cart popup. - The contents of the cart popup should fill the whole width of the window. - The other instances of this are less noticeable because of how the pages work. These changes are more about consistency: - The OPAC place hold page - The club enrollment process (both in the OPAC and the staff interface) - As long as these interactions work correctly all is good. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 182936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182936&action=edit Bug 39441: Some staff interface templates have div.container instead of div.container-fluid This patch updates a few templates so that div.container is replaced with div.container-fluid. div.container gives us a fixed maximum width that isn't consistent the rest of Koha. To test, apply the patch and go to the staff interface. - Perform a catalog search which will return multiple results. - In the search results, check multiple results and click "Add to cart." - Click the cart icon in the top menu to trigger the cart popup. - The contents of the cart popup should fill the whole width of the window. - The other instances of this are less noticeable because of how the pages work. These changes are more about consistency: - The OPAC place hold page - The club enrollment process (both in the OPAC and the staff interface) - As long as these interactions work correctly all is good. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates a few release notes| |templates so that | |div.container is replaced | |with div.container-fluid. | |div.container has a fixed | |maximum width that isn't | |consistent with the rest of | |Koha. An example where this | |caused display issues - the | |staff interface cart: the | |action icons were bunched | |up to the left, instead of | |being spread evenly across | |the pop-up window width. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 183656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183656&action=edit Bug 39441: Some staff interface templates have div.container instead of div.container-fluid This patch updates a few templates so that div.container is replaced with div.container-fluid. div.container gives us a fixed maximum width that isn't consistent the rest of Koha. To test, apply the patch and go to the staff interface. - Perform a catalog search which will return multiple results. - In the search results, check multiple results and click "Add to cart." - Click the cart icon in the top menu to trigger the cart popup. - The contents of the cart popup should fill the whole width of the window. - The other instances of this are less noticeable because of how the pages work. These changes are more about consistency: - The OPAC place hold page - The club enrollment process (both in the OPAC and the staff interface) - As long as these interactions work correctly all is good. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182776|0 |1 is obsolete| | Attachment #182936|0 |1 is obsolete| | Attachment #183656|0 |1 is obsolete| | --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 183657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183657&action=edit Bug 39441: Some staff interface templates have div.container instead of div.container-fluid This patch updates a few templates so that div.container is replaced with div.container-fluid. div.container gives us a fixed maximum width that isn't consistent the rest of Koha. To test, apply the patch and go to the staff interface. - Perform a catalog search which will return multiple results. - In the search results, check multiple results and click "Add to cart." - Click the cart icon in the top menu to trigger the cart popup. - The contents of the cart popup should fill the whole width of the window. - The other instances of this are less noticeable because of how the pages work. These changes are more about consistency: - The OPAC place hold page - The club enrollment process (both in the OPAC and the staff interface) - As long as these interactions work correctly all is good. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39441 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org