[Bug 42168] New: Number in patron's Holds tab should reflect true number of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 Bug ID: 42168 Summary: Number in patron's Holds tab should reflect true number of holds Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Currently, if a patron has 5 titles on hold but 2 of them are part of a group, the number on their Holds tab will be 4 (3 individual 'standard' holds + 1 group made up of 2 holds). But since each hold within a group counts individually toward patrons' hold limits, it seems that the number should reflect their total holds count, perhaps with an indication of the number of groups within that total. In the example above, the number could display as '5 (1)' or '5/1' for 5 total holds and 1 group. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I think different libraries likely feel differently about this one. From memory, 2 holds in a group shouldn't count individually towards patrons' hold limits. That could be a separate bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Cook from comment #1)
I think different libraries likely feel differently about this one. From memory, 2 holds in a group shouldn't count individually towards patrons' hold limits. That could be a separate bug.
I've been poking at the code here and found some inconsistency. For limits on holds per record and holds placed per day, Koha counts a hold group as a single hold. But for total holds allowed, individual holds are counted regardless of grouping. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42255 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15516 CC| |emily.lamancusa@montgomeryc | |ountymd.gov See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Andrew Fuerste-Henry from comment #2)
(In reply to David Cook from comment #1)
I think different libraries likely feel differently about this one. From memory, 2 holds in a group shouldn't count individually towards patrons' hold limits. That could be a separate bug.
I've been poking at the code here and found some inconsistency. For limits on holds per record and holds placed per day, Koha counts a hold group as a single hold. But for total holds allowed, individual holds are counted regardless of grouping.
Hmm now I'm trying to remember if that was intentional or not. The code was rebased many times over many years. Probably should be consistent. Guessing that's probably a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Cook from comment #3)
Hmm now I'm trying to remember if that was intentional or not. The code was rebased many times over many years. Probably should be consistent. Guessing that's probably a bug.
Indeed, Bug 42255. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I'm doing some work on a local 25.11.x and I think I missed making this change on 15516 in opac-main.pl: - my $holds_pending = Koha::Holds->search({ borrowernumber => $borrowernumber, found => undef })->count; + my $holds_pending = $patron->holds->count_holds({ found => undef }); So the counts on opac-main.pl will likely different from the ones in opac-user.pl as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Bug 42255 is awaiting signoff and QA, which we hope to have done shortly. Once that code is in place, all hold limits will be enforced based on a count of hold groups + ungrouped hold, which will align with the number that currently shows on the Holds tab of the patron record. To my mind, that removes the need for this specific bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- But I can confirm that the User Summary on the front page of the OPAC shows a count of individual holds rather than a count of groups+holds. That should be a new bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |INVALID --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Bug 42255 is PQA and on track to push to koha main. I'm going to close this bug. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42168 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42570 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org