[Bug 18017] New: [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Bug ID: 18017 Summary: [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This is a unimarc bug only: When importing biblios from Z39.50, related authorities are wrong matched by the linker. This causes duplicates of authorities. The problem come from a bad marc definition in unimarc/authorities/authority-koha-indexdefs.xml which does not create a index for matching an entire heading. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |alex.arnaud@biblibre.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59675&action=edit Bug 18017 - add index_matching_heading to create indexes for matching an entire authority heading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A test plan to help testers? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #3 from Laurence Rault <laurence.rault@biblibre.com> --- If I understand the patch, a test plan could be Test plan BiblioAddsAuthorities ON AutoCreateAuthorities ON 1) Import Z3950 record and save it : authorities are created 2) Import the same record again, when saving say it is not a duplicate : Without the patch : new authorities (duplicates) are created for the same values With the patch : new record should be linked with existing authorities Tested on sandbox : BiblioAddsAuthorities ON AutoCreateAuthorities ON 1) Import Z3950 record and save it : authorities are created 2) Import the same record again, when saving say it is not a duplicate : Without the patch : new authorities (duplicates) are created for the same values With the patch : new authorities (duplicates) are created for the same values : KO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Full test plan is: BiblioAddsAuthorities ON AutoCreateAuthorities ON 1) replace /koha_conf_dir/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml with /koha_clone/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml 2) replace /koha_conf_dir/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl with /koha_clone/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 3) reindex authorities, 4) Import Z3950 record and save it : authorities are created 5) Import the same record again, when saving say it is not a duplicate : Without the patch : new authorities (duplicates) are created for the same values With the patch : new record should be linked with existing authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |unspecified CC| |victor.grousset@biblibre.co | |m --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- After applying the patch, when reimporting, the authority of the main author is still duplicated. (different id on the "Main Author" link) I even re-indexed authorities after applying the patch. ./src/misc/migration_tools/rebuild_zebra.pl -r -a -v -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #6 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Retried: 1) Set sysprefs BiblioAddsAuthorities ON AutoCreateAuthorities ON 2) Replace xsl files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 3) reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 4) Import Z3950 record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 5) Reimport the same record (when asked, say that it's not a duplicate) 6) The authority should have been duplicated (different url) 7) Apply this patch 8) Replace again the xsl files 9) reindex authorities 10) Reimport the same record 11) The authority should have not been duplicated But for me it was. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |carnold@dgiinc.com --- Comment #7 from Cori Lynn Arnold <carnold@dgiinc.com> --- Followed testing steps, but authority is duplicated. Added book "Sometimes I Lie" twice, and got two "Feeney, Alice, author" records in authorities. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |didier.gautheron@biblibre.c | |om --- Comment #8 from Didier Gautheron <didier.gautheron@biblibre.com> --- Hi I can only reproduce https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017#c7 on MARC21 and it's solved by 21958, but this patch is about UNIMARC and it's working for me, so back to needs Signoff. Regards Didier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- As it's an UNIMARC bug and it's getting old, I think it's okay to have a signoff from the same entity, so Didier or someone else at BibLibre, you can sign this off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm on creating more patches so I set to ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Unimarc] Importing biblios |Use index_heading and |from Z39.50 servers |index_match_heading in |duplicates related |UNIMARC authorities zebra |authorities |configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114588&action=edit Bug 18017: Add subdivisions to UNIMARC authorities zebra configuration Like for MARC21, UNIMARC authorities has subdivisions form, general, chronological and geographic. In C4::Heading::UNIMARC, use subdivisions in _get_search_heading like in C4::Heading::MARC21. Adds subdivisions variables into UNIMARC authorities zebra configuration. Note that unlike MARC21 geographic is subfield $y and chronological is subfield $z. See https://www.ifla.org/publications/unimarc-formats-and-related-documentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114589&action=edit Bug 18017: Use index_heading and index_match_heading in UNIMARC authorities zebra configuration For a good management of autorities linking to biblio records, MARC21 uses index_heading and index_match_heading in authorities zebra configuration. UNIMARC configuration must use the same. This patch adds in UNIMARC authorities zebra configuration index_heading and index_match_heading to earch heading in order to be maximum close to MARC21 authorities zebra configuration. See changes made in MARC21 : https://git.koha-community.org/Koha-community/Koha/commit/32cf2af700dfea15d9... It fixes some indexes names : Personal-name-see => Personal-name-see-from Removes useless Term-geographic index, a duplicate of Name-geographic. Sometimes parallel 7xx form whas only on $a, it must contains same subfields has the main heading. Test plan : =========== 1.0) Use a UNIMARC install without patch 1.1) Set sysprefs BiblioAddsAuthorities = ON AutoCreateAuthorities = ON LinkerModule = First Match 1.2) Replace authorities zebra configuration files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 1.3) Restart zebra server and indexer services 1.4) Reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 1.5) Search in Z3950 a record with complex heading (with subdivisions), for example ISBN 2877620115 "Facteurs culturels et sociaux de la santé en Afrique de l'Oues" 1.6) Import this record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 1.7) Reimport the same record (when asked, say that it's not a duplicate) 1.8) The authority should have been duplicated : different url and different $9 value 2.0) Apply this patch 2.1) Replace again the authorities zebra configuration files 2.2) Restart zebra server and indexer services 2.3) Reindex authorities 2.4) Reimport the same record 2.5) The authority should have not been duplicated 3.0) Play with authorities search to check every mode : Search main heading ($a only) Search main heading Search all headings Search entire record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114589|0 |1 is obsolete| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114590&action=edit Bug 18017: Use index_heading and index_match_heading in UNIMARC authorities zebra configuration For a good management of autorities linking to biblio records, MARC21 uses index_heading and index_match_heading in authorities zebra configuration. UNIMARC configuration must use the same. This patch adds in UNIMARC authorities zebra configuration index_heading and index_match_heading to earch heading in order to be maximum close to MARC21 authorities zebra configuration. See changes made in MARC21 : https://git.koha-community.org/Koha-community/Koha/commit/32cf2af700dfea15d9... It fixes some indexes names : Personal-name-see => Personal-name-see-from Removes useless Term-geographic index, a duplicate of Name-geographic. Sometimes parallel 7xx form whas only on $a, it must contains same subfields has the main heading. Test plan : =========== 1.0) Use a UNIMARC install without patch 1.1) Set sysprefs BiblioAddsAuthorities = ON AutoCreateAuthorities = ON LinkerModule = First Match 1.2) Replace authorities zebra configuration files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 1.3) Restart zebra server and indexer services 1.4) Reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 1.5) Search in Z3950 a record with complex heading (with subdivisions), for example ISBN 2877620115 "Facteurs culturels et sociaux de la santé en Afrique de l'Oues" 1.6) Import this record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 1.7) Reimport the same record (when asked, say that it's not a duplicate) 1.8) The authority should have been duplicated : different url and different $9 value 2.0) Apply this patch 2.1) Replace again the authorities zebra configuration files 2.2) Restart zebra server and indexer services 2.3) Reindex authorities 2.4) Reimport the same record 2.5) The authority should have not been duplicated 3.0) Play with authorities search to check every mode : Search main heading ($a only) Search main heading Search all headings Search entire record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- See also https://github.com/indexdata/idzebra/issues/24 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27299 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud@biblibre.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27299 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Bug 18017 depends on bug 27299, which changed state. Bug 27299 Summary: Zebra phrase register is incorrectly tokenized when using ICU https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114588|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117182&action=edit Bug 18017: Add subdivisions to UNIMARC authorities zebra configuration Like for MARC21, UNIMARC authorities has subdivisions form, general, chronological and geographic. In C4::Heading::UNIMARC, use subdivisions in _get_search_heading like in C4::Heading::MARC21. Adds subdivisions variables into UNIMARC authorities zebra configuration. Note that unlike MARC21 geographic is subfield $y and chronological is subfield $z. See https://www.ifla.org/publications/unimarc-formats-and-related-documentation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114590|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117183&action=edit Bug 18017: Use index_heading and index_match_heading in UNIMARC authorities zebra configuration For a good management of autorities linking to biblio records, MARC21 uses index_heading and index_match_heading in authorities zebra configuration. UNIMARC configuration must use the same. This patch adds in UNIMARC authorities zebra configuration index_heading and index_match_heading to earch heading in order to be maximum close to MARC21 authorities zebra configuration. See changes made in MARC21 : https://git.koha-community.org/Koha-community/Koha/commit/32cf2af700dfea15d9... It fixes some indexes names : Personal-name-see => Personal-name-see-from Removes useless Term-geographic index, a duplicate of Name-geographic. Sometimes parallel 7xx form whas only on $a, it must contains same subfields has the main heading. Test plan : =========== 1.0) Use a UNIMARC install without patch 1.1) Set sysprefs BiblioAddsAuthorities = ON AutoCreateAuthorities = ON LinkerModule = First Match 1.2) Replace authorities zebra configuration files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 1.3) Restart zebra server and indexer services 1.4) Reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 1.5) Search in Z3950 a record with complex heading (with subdivisions), for example ISBN 2877620115 "Facteurs culturels et sociaux de la santé en Afrique de l'Oues" 1.6) Import this record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 1.7) Reimport the same record (when asked, say that it's not a duplicate) 1.8) The authority should have been duplicated : different url and different $9 value 2.0) Apply this patch 2.1) Replace again the authorities zebra configuration files 2.2) Restart zebra server and indexer services 2.3) Reindex authorities 2.4) Reimport the same record 2.5) The authority should have not been duplicated 3.0) Play with authorities search to check every mode : Search main heading ($a only) Search main heading Search all headings Search entire record Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I'm pretty familiar with the code around this in MARC21 and it looks like a reasonably good representation for UNIMARC here.. I did some testing to the extent I understand UNIMARC and it all works well.. Signing off.. I'll request Victor to take a look from a QA standpoint, hopefully he'll spot any UNIMARC issues I may not and can get it over the finish line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117182|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 117350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117350&action=edit Bug 18017: Add subdivisions to UNIMARC authorities zebra configuration Like for MARC21, UNIMARC authorities has subdivisions form, general, chronological and geographic. In C4::Heading::UNIMARC, use subdivisions in _get_search_heading like in C4::Heading::MARC21. Adds subdivisions variables into UNIMARC authorities zebra configuration. Note that unlike MARC21 geographic is subfield $y and chronological is subfield $z. See https://www.ifla.org/publications/unimarc-formats-and-related-documentation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117183|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 117351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117351&action=edit Bug 18017: Use index_heading and index_match_heading in UNIMARC authorities zebra configuration For a good management of autorities linking to biblio records, MARC21 uses index_heading and index_match_heading in authorities zebra configuration. UNIMARC configuration must use the same. This patch adds in UNIMARC authorities zebra configuration index_heading and index_match_heading to earch heading in order to be maximum close to MARC21 authorities zebra configuration. See changes made in MARC21 : https://git.koha-community.org/Koha-community/Koha/commit/32cf2af700dfea15d9... It fixes some indexes names : Personal-name-see => Personal-name-see-from Removes useless Term-geographic index, a duplicate of Name-geographic. Sometimes parallel 7xx form whas only on $a, it must contains same subfields has the main heading. Test plan : =========== 1.0) Use a UNIMARC install without patch 1.1) Set sysprefs BiblioAddsAuthorities = ON AutoCreateAuthorities = ON LinkerModule = First Match 1.2) Replace authorities zebra configuration files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 1.3) Restart zebra server and indexer services 1.4) Reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 1.5) Search in Z3950 a record with complex heading (with subdivisions), for example ISBN 2877620115 "Facteurs culturels et sociaux de la santé en Afrique de l'Oues" 1.6) Import this record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 1.7) Reimport the same record (when asked, say that it's not a duplicate) 1.8) The authority should have been duplicated : different url and different $9 value 2.0) Apply this patch 2.1) Replace again the authorities zebra configuration files 2.2) Restart zebra server and indexer services 2.3) Reindex authorities 2.4) Reimport the same record 2.5) The authority should have not been duplicated. Compare with both existing records to see which the 3rd has been matched against. 3.0) Play with authorities search to check every mode : Search main heading ($a only) Search main heading Search all headings Search entire record Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Finally I have an UNIMARC Koha! :D (thanks to koha-testing-docker) And the test plan worked :) So here is a second signoff while I reach out for help to review the UNIMARC stuff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Frido: Will bug 11175 impact this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #21)
Frido: Will bug 11175 impact this one?
I think not. Bug 11175 is a change in XSLT displays. This one is Zebra configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
change in XSLT displays
It actually changes biblio-koha-indexdefs.xml but here it's only authority-koha-indexdefs.xml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This has had a good number of eyes on it now.. including a Unimarc check.. I'm going to take Victors SO and a QA with agreement from Jonathan on IRC already having been reached.. Questions have been answered, QA scripts are happy and this only affects the Unimarc users. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks all. I got help to understand some of the stuff but far from all of it. Also my call for help in the french mailing list didn't yield results ^^" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 A great thank you to Victor ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew@bywatersolutions.com --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908 [Bug 28908] Bug 18017 removed indexing field 245 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29191 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org