https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21285 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |oleonard@myacpl.org |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21285 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 78273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78273&action=edit Bug 21285: Add missing select2x2.png file This file is part of the Select2 jquery plugin, but wasn't added when the use of the plugin was introduced in Koha. To test: - On a high DPI screen (retina mac?) on Chrome or Safari - Edit an item => FAIL: dropdowns using Select2 (like 'Shelving location') don't display the icons (down arrow and cross) and a default value is wrongly selected => FAIL: the inspector says the requested select2x2.png file returned a 400 error. - Apply this patch - Reload the edit page => SUCCESS: Things display correctly! Dropdowns without selected values by default! => SUCCESS: No errors fetching select2x2.png - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21285 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78273|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 78333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78333&action=edit Bug 21285: Add missing select2x2.png file This file is part of the Select2 jquery plugin, but wasn't added when the use of the plugin was introduced in Koha. To test: - On a high DPI screen (retina mac?) on Chrome or Safari - Edit an item => FAIL: dropdowns using Select2 (like 'Shelving location') don't display the icons (down arrow and cross) and a default value is wrongly selected => FAIL: the inspector says the requested select2x2.png file returned a 400 error. - Apply this patch - Reload the edit page => SUCCESS: Things display correctly! Dropdowns without selected values by default! => SUCCESS: No errors fetching select2x2.png - Sign off :-D Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21285 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21285 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21285 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.04 -- You are receiving this mail because: You are watching all bug changes.