[Bug 19977] New: Local Use tab in systempreferences tries to open text editor' s temporary files, and die
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Bug ID: 19977 Summary: Local Use tab in systempreferences tries to open text editor's temporary files, and die Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Steps to reproduce: 1. Open koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Observe the error: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at /home/koha/koha/admin/systempreferences.pl line 413. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 70548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70548&action=edit Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- One would hope this case never happens. And if it does, stop editing the files on a live system. That being said, this is a straight-forward regexp tightening. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70548|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70703&action=edit Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to M. Tompsett from comment #2)
One would hope this case never happens. And if it does, stop editing the files on a live system. That being said, this is a straight-forward regexp tightening.
Of course this should never happen in production, but it can be annoying during development. Thanks for the sign-off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70703|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70749&action=edit Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org