[Bug 18874] New: Add unique constraint to repeatable_holidays and special_holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Bug ID: 18874 Summary: Add unique constraint to repeatable_holidays and special_holidays Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org The calendar doesn't check if holidays already exist before copying/inserting holidays -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 --- Comment #1 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64705&action=edit Bug 18874: Add unicity constraint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Baptiste, please provide a test plan and I will gladly test! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 --- Comment #3 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Hi, 1 - Create holiday for a library 2 - Copy this holidays to a second library 3 - Copy these holidays to the first library Check in base, you should have a duplicate 4 - Undo changes 5 - Apply patch 6 - Update database and database schema 7 repeat 1-3, it should not duplicate datas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64705|0 |1 is obsolete| | --- Comment #4 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64970&action=edit Bug 18874: Add unicity constraint Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- This does work, we get errors in the logs with no feedback for user, if the intention is to replace an existing holiday with a different holiday this could be confusing. Perhaps we should perform the check and offer an error/notification? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Also, this fails to add the constraint for a fresh install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m Assignee|baptiste.wojtkowski@biblibr |koha-bugs@lists.koha-commun |e.com |ity.org --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 18520 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 24289 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org