[Bug 16271] New: Allow more filters on /api/v1/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Bug ID: 16271 Summary: Allow more filters on /api/v1/reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 13903 Actually (with bug 13903) we can only filter reserves using the borrowernumber. And the filter is mandatory (it's not possible to fetch all reserves at once) We should be able to get all reserves, and to filter on other criteria as well Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 50263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50263&action=edit Bug 16271: Allow more filters on /api/v1/reserves borrowernumber parameter is no longer required and you can filter on every column of reserves table Some example requests - GET /api/v1/reserves - GET /api/v1/reserves?biblionumber=123 - GET /api/v1/reserves?borrowernumber=456 - GET /api/v1/reserves?priority=0&found=W -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50263|0 |1 is obsolete| | --- Comment #2 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 50272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50272&action=edit Bug 16271: Allow more filters on /api/v1/reserves borrowernumber parameter is no longer required and you can filter on every column of reserves table Some example requests - GET /api/v1/reserves - GET /api/v1/reserves?biblionumber=123 - GET /api/v1/reserves?borrowernumber=456 - GET /api/v1/reserves?priority=0&found=W Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no Status|Needs Signoff |Signed Off --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Brilliant work Julian! Works perfectly! Let the new API rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow more filters on |Allow more filters on |/api/v1/reserves |/api/v1/holds CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we get a follow-up to change this to holds also? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- see comment#4 - needs a follow-up to be about 'holds' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50272|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 51319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51319&action=edit Bug 16271: Allow more filters on /api/v1/holds borrowernumber parameter is no longer required and you can filter on every column of reserves table Some example requests - GET /api/v1/hols - GET /api/v1/hols?biblionumber=123 - GET /api/v1/hols?borrowernumber=456 - GET /api/v1/hols?priority=0&found=W Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51319|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 51320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51320&action=edit Bug 16271: Allow more filters on /api/v1/holds borrowernumber parameter is no longer required and you can filter on every column of reserves table Some example requests - GET /api/v1/holds - GET /api/v1/holds?biblionumber=123 - GET /api/v1/holds?borrowernumber=456 - GET /api/v1/holds?priority=0&found=W Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master and 'reserves' changed to 'holds' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51320|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52862&action=edit Bug 16271: Allow more filters on /api/v1/holds borrowernumber parameter is no longer required and you can filter on every column of reserves table Some example requests - GET /api/v1/holds - GET /api/v1/holds?biblionumber=123 - GET /api/v1/holds?borrowernumber=456 - GET /api/v1/holds?priority=0&found=W Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Julian! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org