[Bug 18804] New: Selenium tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Bug ID: 18804 Summary: Selenium tests are failing Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org These tests are not run regularly and they are now completely broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Depends on| |13691 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 [Bug 13691] Add some selenium scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64289&action=edit Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64290&action=edit Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64291&action=edit Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64292&action=edit Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16286, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16400, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11088, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13501 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Additional information: To test this patch: % wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standal... % sudo apt-get install xvfb firefox-esr % SELENIUM_PATH=/home/vagrant/selenium-server-standalone-2.53.1.jar % Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & % DISPLAY=:1 java -jar $SELENIUM_PATH Remove the rentalcharge: % UPDATE itemtypes SET rentalcharge = 0; Then you can execute the test file. If you get: Wide character in print at /usr/local/share/perl/5.20.2/Test2/Formatter/TAP.pm line 105. # 'Koha › Patrons › Add patron test_patron_surname (Adult)' # doesn't match '(?^u:Patron details for test_patron_surname)' Ignore and retry (FIXME LATER...) No need to say that this code needs more love. The plan here is to make the tests pass, it will already be a big step. Tested on 17.05.x, 16.11.x and 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Block RM actions (cannot test before pushing stuffs). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64289|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 64358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64358&action=edit Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64290|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 64359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64359&action=edit Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" /> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64291|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 64360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64360&action=edit Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64292|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 64361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64361&action=edit Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64358|0 |1 is obsolete| | --- Comment #11 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64362&action=edit [SIGNED-OFF] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64362|0 |1 is obsolete| | --- Comment #12 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64363&action=edit [SIGNED-OFF] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64363|0 |1 is obsolete| | --- Comment #13 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64365&action=edit Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64359|0 |1 is obsolete| | --- Comment #14 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64366&action=edit Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" /> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64360|0 |1 is obsolete| | --- Comment #15 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64367&action=edit Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64361|0 |1 is obsolete| | --- Comment #16 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64368&action=edit Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64365|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64373&action=edit Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64366|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64374&action=edit Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" /> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64367|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64375&action=edit Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64368|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64376&action=edit Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64417&action=edit Bug 18804: Add additional information to execute successfuly selenium tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #23 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested successfully in 16.11.x. (thx for comment#5, Jonathan!) These patches have been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982 [Bug 18982] selenium tests needs too many prerequisites -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #25 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org