https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And, of course, make sure the filter works! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105406|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105407&action=edit Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" On the "Holds to pull" view there are filters that are built on the value of the cells. Bug 22536 improved the ergonomic by adding a ul list, but the filters are now broken, the ul and li tags are retrieved and put in the filter list. The idea of this patch is to remove the HTML tags and skip if the value is then empty. Test plan: Place a hold on an item Go to Home › Circulation › Holds to pull Open the "libraries" filter => Without this patch you see empty entries => With this patch the filter contain only the libraries Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105407|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105410&action=edit Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" On the "Holds to pull" view there are filters that are built on the value of the cells. Bug 22536 improved the ergonomic by adding a ul list, but the filters are now broken, the ul and li tags are retrieved and put in the filter list. The idea of this patch is to remove the HTML tags and skip if the value is then empty. Test plan: Place a hold on an item Go to Home › Circulation › Holds to pull Open the "libraries" filter => Without this patch you see empty entries => With this patch the filter contain only the libraries Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.