[Bug 24298] New: Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bug ID: 24298 Summary: Record if a transfer was triggered by 'return to homebranch' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Use the new 'trigger' field in branchtransfers to record when a transfer was triggered automatically by the return to home branch settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24287 |24296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 [Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 [Bug 24299] Record if a transfer was triggered by 'rotating collections' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|4234 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|4234 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97450&action=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97451&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97450|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97506&action=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97451|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97507&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test Plan: 1) Enable AutoItemReturn and accompanying system preference 2) Return an item to the wrong branch and note the transfer 3) Check the database for the new trigger value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97506|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97535&action=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97507|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97536&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97535|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98292&action=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97536|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98293&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98294&action=edit Bug 24298: Add tests for ModItemTransfer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bug 24298 depends on bug 24296, which changed state. Bug 24296 Summary: Move stock rotation transfer triggers from `comments` to `reason` https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, qa tools complains FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL filters missing_filter at line 522 ( <input type="hidden" name="trigger" value="[% trigger %]" />) $raw/html? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24434 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98292|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99774&action=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98293|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99775&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98294|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99776&action=edit Bug 24298: Add tests for ModItemTransfer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99777&action=edit Bug 24298: (follow-up) Add missing filter! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #11)
Hi, qa tools complains
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL filters missing_filter at line 522 ( <input type="hidden" name="trigger" value="[% trigger %]" />)
$raw/html?
Thanks for taking a look Bernardo.. all fixed up in the followup :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99774|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99781&action=edit Bug 24298: Add return enums to branchstransfer triggers Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> updatedabase runs Ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99775|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99782&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. Test Plan: 1) Enable AutomaticItemReturn and accompanying system preference 2) Return an item to the wrong branch and note the transfer 3) Check the database for the new trigger value Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Added test plan. Works Ok, trigger saved in database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99776|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99783&action=edit Bug 24298: Add tests for ModItemTransfer Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All 8 tests in 'ModItemTransfer tests' pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99777|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99784&action=edit Bug 24298: (follow-up) Add missing filter! Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Martin Renvoize from comment #5)
1) Enable AutoItemReturn and accompanying system preference
It is AutomaticItemReturn :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99781|0 |1 is obsolete| | Attachment #99782|0 |1 is obsolete| | Attachment #99783|0 |1 is obsolete| | Attachment #99784|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100621&action=edit Bug 24298: Add return enums to branchstransfer triggers Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> updatedabase runs Ok Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100622&action=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. Test Plan: 1) Enable AutomaticItemReturn and accompanying system preference 2) Return an item to the wrong branch and note the transfer 3) Check the database for the new trigger value Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Added test plan. Works Ok, trigger saved in database. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100623&action=edit Bug 24298: Add tests for ModItemTransfer Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All 8 tests in 'ModItemTransfer tests' pass Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100624&action=edit Bug 24298: (follow-up) Add missing filter! Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100625&action=edit Bug 24298: Update test count and use build_sample_item Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- One note here: AddIssue closes existing transfers but doesn't update the reason - probably 'Checkout' should be a transfer reason - this can be done on another bug I think -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens from comment #27)
One note here: AddIssue closes existing transfers but doesn't update the reason - probably 'Checkout' should be a transfer reason - this can be done on another bug I think
Hmm, yeah, I remember spotting that and pondering how to handle it. I think I opted at the time to defer that work.. the 'reason' is really all about what triggered the transfer in the first place rather than if/why it may have been cancelled. It's pretty bad that we wipe out all trace of where the item as meant to be getting transferred to in my opinion.. even if we cancel it we aught to really record where it was meant to go in case we want to restore it later. I think, as you say, I'll open another bug to work no this however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24898 [Bug 24898] AddIssue destructively changes transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #31 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@outlook.com --- Comment #32 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Shouldn't 'TransferTrigger' be included as empty elseif statement inside error messages loop in returns.pl? Now when I try to return item needing transfer with 'AutomaticItemReturn' disabled I get error: 'Unknown error code TransferTrigger at /var/Koha/circ/returns.pl line 542.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Taking a look now, thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103792&action=edit Bug 24298: (RM follow-up) Re-introduce TransferTrigger drop through A rebase lost the fall through for TransferTrigger as a message. This patch simply adds back in the dropped elsif statement. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch.. seems we lost it in a rebase somewhere along the line.. it was in my original local branch :) Pushing as an RM followup now -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org