[Bug 24637] New: Pay selected & Pay amount does not log branchcode in 19.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Bug ID: 24637 Summary: Pay selected & Pay amount does not log branchcode in 19.05 Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When paying a fine (in 19.05.x) and lower branchcode is not properly logged. I believe this is fixed in 19.11.x by bz23321 To Recreate: 1. Have some fines. Pay them using the Pay Amount or Pay Selected buttons. 2. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 3. See that branchcode is NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 98734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98734&action=edit Bug 24637: Add brancode in all pay circumstances To TEST: 1. Have some fines. Pay them using the Pay Amount or Pay Selected buttons. 2. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 3. See that branchcode is NULL 4. Apply patch and restart_all 5. Make a partial payment using both the Pay select and Pay amount buttons. 6. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 7. Now you should see the branchcodes in the table and no NULL values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Lucas, I am getting this error: Could not compile /kohadevbox/koha/members/paycollect.pl: Global symbol "@acc" requires explicit package name (did you forget to declare "my @acc"?) at /kohadevbox/koha/members/paycollect.pl line 214. Global symbol "$select" requires explicit package name (did you forget to declare "my $select"?) at /kohadevbox/koha/members/paycollect.pl line 214. Global symbol "$note" requires explicit package name (did you forget to declare "my $note"?) at /kohadevbox/koha/members/paycollect.pl line 215. Global symbol "@lines" requires explicit package name (did you forget to declare "my @lines"?) at /kohadevbox/koha/members/paycollect.pl line 217. Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at /kohadevbox/koha/members/paycollect.pl line 234. Global symbol "@lines" requires explicit package name (did you forget to declare "my @lines"?) at /kohadevbox/koha/members/paycollect.pl line 235. Global symbol "$note" requires explicit package name (did you forget to declare "my $note"?) at /kohadevbox/koha/members/paycollect.pl line 236. syntax error at /kohadevbox/koha/members/paycollect.pl line 241, near ">>" Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at /kohadevbox/koha/members/paycollect.pl line 251. syntax error at /kohadevbox/koha/members/paycollect.pl line 271, near "if" /kohadevbox/koha/members/paycollect.pl has too many errors. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Kelly, I think this is because this patch is intended for 19.05.x, and maybe you're attempting to apply it to master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98734|0 |1 is obsolete| | --- Comment #4 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 99279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99279&action=edit Bug 24637: Add brancode in all pay circumstances Signed-off-by: Benjamin Daeuber <bdaeuber@fargolibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99279|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99285&action=edit Bug 24637: Add brancode in all pay circumstances To TEST: 1. Have some fines. Pay them using the Pay Amount or Pay Selected buttons. 2. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 3. See that branchcode is NULL 4. Apply patch and restart_all 5. Make a partial payment using both the Pay select and Pay amount buttons. 6. SELECT branchcode FROM accountlines where borrowernumber = '{borrowernumber}'; 7. Now you should see the branchcodes in the table and no NULL values. Signed-off-by: Benjamin Daeuber <bdaeuber@fargolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected.. Passing QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24637 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.08 released in| | Status|Passed QA |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org