[Bug 41849] New: Cancelling filled hold from group does not delete remaining holds from group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Bug ID: 41849 Summary: Cancelling filled hold from group does not delete remaining holds from group Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 --- Comment #1 from Sara Brown <sbrown@bywatersolutions.com> --- When cancelling a filled/waiting hold for an item from a bib or item-level hold group, pending holds on the rest of the bibs/items from that group are not automatically cancelled. Since there's no indication on the cancellation screen that the hold was part of a group, staff will have no way to know that they need to view the patron's account to cancel the other holds from that group. I tested cancelling a filled hold by checking the item in (preferred), cancelling as a staff member from the patron's account, from the bib, and from Holds awaiting pickup. In all cases, the filled hold was cancelled, but the other bibs/items from the group remained pending for the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cancelling filled hold from |Cancelling filled hold from |group does not delete |group does not delete |remaining holds from group |remaining pending holds | |from group -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #2 from Sara Brown <sbrown@bywatersolutions.com> --- Edited to add: This was tested with three bibs or items, so two holds remained in a group after the filled hold was cancelled. It makes sense to retain the group when a hold on a specific bib/item from the group is cancelled for *unfilled* holds, but typically, filled holds are cancelled because the patron hasn't picked the item before it expires (or contacts the library to say that they no longer want the item). For cancellations of filled holds that are part of a group, the rest of the group should be automatically cancelled OR staff should have an indication that they need to view the patron's account to cancel the rest of the group. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cancelling filled hold from |Cancelling filled hold from |group does not delete |group does not cancel |remaining pending holds |remaining pending holds |from group |from group or indicate that | |it's a hyperhold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #3 from Sara Brown <sbrown@bywatersolutions.com> --- Since libraries may not want to cancel the remaining holds in a hyperhold automatically in this situation, the modal that shows when filled holds are checked in to cancel should have 1) an option to cancel the remaining holds in the hyperhold directly from there, 2) a link to the patron's account with the hold group number or hold_group_id so that staff can link to cancel the remaining holds, or 3) both of those. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k CC| |pedro.amorim@openfifth.co.u | |k Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41957 [Bug 41957] Hyperhold/hold group information should show on 'Hold found' modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196644&action=edit Bug 41849: Preparation: DRY the hold_group info block for reusability Added in bug 41957 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196645&action=edit Bug 41849: Add hold_group info to the filled holds check in modal This adds the same hold group info (with a link to the patron's holds) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196646&action=edit Bug 41849: Add cancel hold_group REST API endpoint Patch from commit f8c8d4b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196647&action=edit Bug 41849: Add 'Cancel all holds in this hold group' button To the same filled holds check in modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196648&action=edit Bug 41849: Add tests Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Check-in any eligible barcode e.g.: 39999000005578 8) Click 'Confirm hold'. 9) Check-in that same barcode. 10) Notice the modal now shows 'Part of a hold group' with a link to the patron's holds table 11) Notice the modal now shows a 'Cancel all holds in hold group' button. Click the button. Confirm all holds are cancelled. prove t/db_dependent/api/v1/patrons_hold_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196646|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196647|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196648|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196664&action=edit Bug 41849: Preparation: DRY the hold_group info block for reusability Added in bug 41957 Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196665&action=edit Bug 41849: Add hold_group info to the filled holds check in modal This adds the same hold group info (with a link to the patron's holds) Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196666&action=edit Bug 41849: Add cancel hold_group REST API endpoint Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196667&action=edit Bug 41849: Add 'Cancel all holds in this hold group' button To the same filled holds check in modal Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196668&action=edit Bug 41849: Add tests Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Check-in any eligible barcode e.g.: 39999000005578 8) Click 'Confirm hold'. 9) Check-in that same barcode. 10) Notice the modal now shows 'Part of a hold group' with a link to the patron's holds table 11) Notice the modal now shows a 'Cancel all holds in hold group' button. Click the button. Confirm all holds are cancelled. prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196664|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196667|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196668|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196669&action=edit Bug 41849: Preparation: DRY the hold_group info block for reusability Added in bug 41957 Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196670&action=edit Bug 41849: Add hold_group info to the filled holds check in modal This adds the same hold group info (with a link to the patron's holds) Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196671&action=edit Bug 41849: Add cancel hold_group REST API endpoint Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196672&action=edit Bug 41849: Add 'Cancel all holds in this hold group' button To the same filled holds check in modal Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196673&action=edit Bug 41849: Add tests Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Check-in any eligible barcode e.g.: 39999000005578 8) Click 'Confirm hold'. 9) Check-in that same barcode. 10) Notice the modal now shows 'Part of a hold group' with a link to the patron's holds table 11) Notice the modal now shows a 'Cancel all holds in hold group' button. Click the button. Confirm all holds are cancelled. prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15516 CC| |emily.lamancusa@montgomeryc | |ountymd.gov Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |option to the modal | |displayed when checking in | |an item that is already | |waiting for a hold. If the | |hold is part of a group, | |the modal will offer the | |option to cancel all holds | |in the group rather than | |just the hold for the item | |that has been checked in. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a new |This patch adds a new release notes|option to the modal |option to the modal |displayed when checking in |displayed when checking in |an item that is already |an item that is already |waiting for a hold. If the |waiting for a hold. If the |hold is part of a group, |hold is part of a group, |the modal will offer the |the modal will offer the |option to cancel all holds |option to cancel all holds |in the group rather than |in the group rather than |just the hold for the item |just the hold for the item |that has been checked in. |that has been checked in. | |A new REST API endpoint | |(POST | |/patrons/{patron_id}/hold_g | |roups/{hold_group_id}/cance | |l) has been added to | |achieve this functionality. | |The new endpoint will: | |-Cancel all holds within a | |specified hold group. | |-Accept a cancellation | |reason | |-Return a 204 on success | |-Return a 404 when the hold | |group cannot found or does | |not exist. | | | |The endpoint requires the | |'reserveforothers' | |permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41849 --- Comment #20 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org