[Bug 28487] New: Overdue_notices does not fall back to default language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Bug ID: 28487 Summary: Overdue_notices does not fall back to default language Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org Previously overdue_notices use exclusively the default language but bug 26420 changed this to the opposite, which is to use exclusively the language chosen by the user. But if no translation have been provided for the chosen language, no message is sent. I would expect the behavior to be the same as in GetPreparedLetter: $letter = getletter( $module, $letter_code, $branchcode, $mtt, $lang ); unless ( $letter ) { $letter = getletter( $module, $letter_code, $branchcode, $mtt, 'default' ) or warn( "No $module $letter_code letter transported by " . $mtt ), return; } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this sounds like a major bug - a lot of libraries might only define the default notice in their "main" language. That's the expected behaviour and the described change could be bad trouble espeially as overdues are a sensitive area. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121580&action=edit Bug 28487: Remove getletter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26420 Version|20.11 |master CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch goes way to far but it's the goal we want to reach to prevent future regressions like that. I will try and see if I can come up with a simpler fix. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 [Bug 26420] Overdue notices script does not care about borrower's language, always takes default template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 [Bug 27660] Should getletter not use the fallback to default? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Bug 28487 depends on bug 27660, which changed state. Bug 27660 Summary: Should getletter not use the fallback to default? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27660 Depends on|27660 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 [Bug 27660] Should getletter not use the fallback to default? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121627&action=edit Bug 28487: Fallback to default template in overdue_notices There is no fallback to the "default" language if there is no language-specific template for the lang of the patron. I am not really sure why we are not using GetPreparredLetter here (which defaults), but this needs to be backported into all stable branches and so as small as possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121580|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Andreas, can you test this patch please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 [Bug 28514] C4::Letters::getletter must be rewritten -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Could we get a test plan for this, and I will happily attempt to test 8-). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hi David, Test plan: Hi David, Hi David, - Make sure you have TranslateNotices turned on - Set a default lang for a given patron - Have some overdue rules and translate notice templates - Generate overdues for the patron - Run the overdue_notices.pl script => The translated notice templates is picked - Remove the translated notice templates for the lang of the patron - Run the overdue_notices.pl script => Without this patch no notice is generated => With this patch a notice is generated using the default notice template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #7) Thanks Jonathan! For some reason I couldn't get notices to generate for overdue items I created, so will leave for someone else more familiar with this to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121627|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121726&action=edit Bug 28487: Fallback to default template in overdue_notices There is no fallback to the "default" language if there is no language-specific template for the lang of the patron. I am not really sure why we are not using GetPreparredLetter here (which defaults), but this needs to be backported into all stable branches and so as small as possible. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Code reads well, testing proves it works as expected.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #11 from David Nind <david@davidnind.com> --- Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121726|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121853&action=edit Bug 28487: Fallback to default template in overdue_notices There is no fallback to the "default" language if there is no language-specific template for the lang of the patron. I am not really sure why we are not using GetPreparredLetter here (which defaults), but this needs to be backported into all stable branches and so as small as possible. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28555 CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Previously overdue notices release notes| |exclusively used the | |default language, but bug | |26420 changed this to the | |opposite - to exclusively | |use the language chosen by | |the patron. | | | |However, if | |there is no translation for | |the overdue notice for the | |language chosen by the | |patron then no message is | |sent. | | | |This fixes this so | |that if there is no | |translation of the overdue | |notice for the language | |chosen by the patron, then | |the default language notice | |is used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01,20.11.07, released in| |20.05.13 CC| |victor@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #17 from wainuiwitikapark@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #18 from wainuiwitikapark@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.20? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to wainuiwitikapark from comment #18)
Should this be backported to 19.11.x? For 19.11.20?
Yes, I think so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.01,20.11.07, |21.11.00,21.05.01,20.11.07, released in|20.05.13 |20.05.13,19.11.20 Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #20 from wainuiwitikapark@catalyst.net.nz --- Backported to 19.11.x for 19.11.20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28712 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just found another instance of the issue while printing fine related slips: bug 28712 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org