[Bug 25557] New: Column config table in Acquisitions Order Does not Match the Acq table in Baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Bug ID: 25557 Summary: Column config table in Acquisitions Order Does not Match the Acq table in Baskets Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: lucas@bywatersolutions.com Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The actual way that the Acq table appears in the basket view (basket.pl), 1.Basket # 2. Order information 3. RRP Tax Exc 4. Actual Cost Exc 5. Budgeted Cost Tax Exc 6. RRP Tax Included 7. Actual Cost Tax Inc 8. Budgeted Cost Tax Inc 9. Replacement Price 10. Quantity But in the column config table 1.Basket # 2. Order Info 3. RRP tax Exc 4. Ecost Exc (Actual Exc) 5. RRP tax Included 6. Ecost Tax Included (Actual Inc) 7. Replacement Prie 8. Quantity 9. Total Tax Excluded 10. Total Tax Included We will need to change the column configuration to match the table so it is easy to hide the correct columns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 105235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105235&action=edit Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Column config table in |Column config table in |Acquisitions Order Does not |acquisitions order does not |Match the Acq table in |match the acq table in |Baskets |baskets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
1. Go to Acquisitions and look at basket.pl
Is and individual basket? "Home › Acquisitions › My Vendor › Basket My Basket (1) for My Vendor " Assuming yes.
2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden.
Can't reproduce. I tried to hide and show most of the columns and nothing seemed wrong. (not sure if relevant, Quantity is hidden by default, no idea where the setting is) What is the role of opening another tab? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Victor, Thanks for testing. Are you attempting to hide/show the columns by using the column configuration tool? The only reason I said 'open a new tab' is so the tester can have the column configuration tool open in one tab and the table in another. To make it easier to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Lucas Gass from comment #3)
Are you attempting to hide/show the columns by using the column configuration tool?
Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> ---
Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png
Victor, No, I am referring to the Configure columns tool at Koha Admin > Configure columns. /cgi-bin/koha/admin/columns_settings.pl https://snipboard.io/Hk0N7V.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105235|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 105421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105421&action=edit Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Lucas Gass from comment #5)
No, I am referring to the Configure columns tool at Koha Admin > Configure columns.
/cgi-bin/koha/admin/columns_settings.pl
Hooooooo
3. See that the wrong columns are being hidden.
Indeed, nonsense can happen!
6. Rejoice!
It works! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105425&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105421|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105426&action=edit Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Attachment #105425|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 25714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.07 |19.11.07, 19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #15 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hello, well done for this correction! I was looking forward it :), but our Koha is in French, so the column names are in French in the basket but not the display in the column settings. So I thought I could do the translation on pootle but I can't find the file columns_settings.yml. Is it possible to translate the column names ? Thanks Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hi Sonia, Non you cannot modify "columname" from the yaml, and you should not. It's how we map the settings of the table from the template with the yml, it's more an "ID" than a name. You should open an enhancement request for that, but it's not trivial to implement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #17 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi Jonathan :) I don't want to change the name in the yml, I just want to know if we could translate the display in pootle to have it in French. As you can see in the screen shot, it's sometimes difficult to know exactly which column is which.. https://snipboard.io/lZvsrA.jpg Do you think it's possible ? (By the way, I realize that "replacement price" and "recommended retail price" are translated by "prix public" and that is confusing.. I can at least change that !) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Koha Team University Lyon 3 from comment #17)
Hi Jonathan :) I don't want to change the name in the yml, I just want to know if we could translate the display in pootle to have it in French. As you can see in the screen shot, it's sometimes difficult to know exactly which column is which.. https://snipboard.io/lZvsrA.jpg
Do you think it's possible ?
(By the way, I realize that "replacement price" and "recommended retail price" are translated by "prix public" and that is confusing.. I can at least change that !)
Hi, we recently discussed ways to make those translatable on IRC, but concluded that the first step would be to make the English descriptions nice too, as they are more "code like" at the moment. I think it would be a great to have that. Could you please file a separate bug report for it? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org