http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19417|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19443&action=edit Bug 10544 - stocknumber index is an alias of Number-local-acquisition Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for number 1062. In this case, Number-local-acquisition must be used in record.abs and stocknumber can be an alias of it in ccl.properties. Test plan : - drop zebra database (rebuild_zebra.pl -r ...) - reindex - test in simple search : ccl=Number-local-acquisition,alwaysmatches='' => you get all records with a stocknumber - test in simple search : ccl=stocknumber,alwaysmatches='' => you get the same results Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19924&action=edit Bug 10544 - add Number-local-acquisition in known indexes Adding Number-local-acquisition in C4::Search known indexes allows to search without using "ccl=" prefix. Also corrects in ccl.properties : inv must be an alias of Number-local-acquisition. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19925&action=edit Bug 10544 - add Number-local-acquisition in QueryParser config This patch adds the Number-local-acquisition in QueryParser config to behave like in ccl.properties. See commit message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19925|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 22344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22344&action=edit Bug 10544 - add Number-local-acquisition in QueryParser config This patch adds the Number-local-acquisition into QueryParser configuration file. Like in ccl.properties, "Number-local-acquisition" is the main index name and "stocknumber" and "inv" are aliases. Test plan : Enable QueryParser : - Enable UseQueryParser syspref - Edit your koha-conf.xml - Add to "config" node : <queryparser_config>[your path]/etc/searchengine/queryparser.yaml</queryparser_config>, adapt [your patch] to your install configuration folder - If needed copy from sources "etc/searchengine/queryparser.yaml" into your install configuration folder Test search : - Add Number-local-acquisition on an existing subfield in records.abs. For example on item barcode field - Reindex Zebra database - Choose a value of this field that will match some results. For example : "0*" will match all barcodes beginning with zero - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0*&sort_by=relevance => You get some results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=inv&q=0*&sort_by=relevance => You get the same results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=Number-local-acquisition&q=0*&sort_by=relevance => You get the same results Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19924|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 22346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22346&action=edit Bug 10544 - add Number-local-acquisition in known indexes Adding Number-local-acquisition in C4::Search known indexes allows to search without using "ccl=" prefix. Also corrects in ccl.properties : inv must be an alias of Number-local-acquisition. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Just some comments for QAer: I tested the Zebra changes with MARC21/GRS1. It works as advertised. MARC21 field 037 is mapped to Stock-number. It may be somewhat confusing to have Stocknumber and Stock-number indexing different MARC fields. Can they be merged into the same index? If I search with catalogue/search.pl?idx=number-local-acquisition&q=stock* I have the error: Can't call method "sort" on an undefined value at /usr/share/koha/testclone/C4/Search.pm line 426. This is outside the scope of this report, but I would personally like to receive the same search results (just interpret the idx parameter case insensitive) instead of this error. Your editing of the query parser config file now shows another index variant: number-local-acq. Why not just Number-local-acquisition? Is it really needed to have four names for this index? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22346|0 |1 is obsolete| | --- Comment #15 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 22354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22354&action=edit [SIGNED-OFF] Bug 10544 - add Number-local-acquisition in known indexes No change -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #16)

Please re-sign.

Changing status to reflect that need. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #18)

Can you signoff 3rd patch ?

I still have a question. We had Number-local-acquisition with a capital letter. If I disable QueryParser, I can search with Number-local-acquisition:testmr and find a record. If I enable QueryParser, this will no longer work. The URLs from your commit message do all work, but note that now it is number-local-acquisition with a lower case letter. I am not yet so familiar with the QueryParser configuration, but is it possible to make these indexes case insensitive or so? I am hesitating to sign a patch that makes this index with the capital letter disappear.. I have asked jcamins this same question in an email.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Got the following response from Jared: Upper-case indexes seem odd to me, but it would be easy to add them. For example, the following change in Koha/QueryParser/Driver/PQF.pm: 97 $self->add_search_field_alias( $class => $field => uc $field ); Note btw that I did not mean an uppercase index but actually an index starting with one uppercase letter (in this case: Number-local-acquisition). I have spent some time scrolling through QueryParser and found that we could change its behavior around lines 856-857 in the regexes that parse the query for fields and aliases, but that is certainly outside the scope of this report. I do not think that it is necessary or even appropriate to add the first mixed-case variant just for this field. So in short, I will just sign off the current version. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22353|0 |1 is obsolete| | --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24737&action=edit Bug 10544 - stocknumber index is an alias of Number-local-acquisition Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for number 1062. In this case, Number-local-acquisition must be used in record.abs and stocknumber can be an alias of it in ccl.properties. Test plan : - drop zebra database (rebuild_zebra.pl -r ...) - reindex - test in simple search : ccl=Number-local-acquisition,alwaysmatches='' => you get all records with a stocknumber - test in simple search : ccl=stocknumber,alwaysmatches='' => you get the same results Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22355|0 |1 is obsolete| | --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24739&action=edit Bug 10544 - add Number-local-acquisition in QueryParser config This patch adds the Number-local-acquisition into QueryParser configuration file. Like in ccl.properties, "Number-local-acquisition" is the main index name and "stocknumber" and "inv" are aliases. Test plan : Enable QueryParser : - Enable UseQueryParser syspref - Edit your koha-conf.xml - Add to "config" node : <queryparser_config>[your path]/etc/searchengine/queryparser.yaml</queryparser_config>, adapt [your patch] to your install configuration folder - If needed copy from sources "etc/searchengine/queryparser.yaml" into your install configuration folder Test search : - Add Number-local-acquisition on an existing subfield in records.abs. For example on item barcode field - Reindex Zebra database - Choose a value of this field that will match some results. For example : "0*" will match all barcodes beginning with zero - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0*&sort_by=relevance => You get some results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=inv&q=0*&sort_by=relevance => You get the same results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=number-local-acquisition&q=0*&sort_by=relevance => You get the same results Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Comments on case sensitivity of index names in QueryParser, see Bugzilla. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11619 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11619 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24737|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25276&action=edit Bug 10544 - stocknumber index is an alias of Number-local-acquisition Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for number 1062. In this case, Number-local-acquisition must be used in record.abs and stocknumber can be an alias of it in ccl.properties. Test plan : - drop zebra database (rebuild_zebra.pl -r ...) - reindex - test in simple search : ccl=Number-local-acquisition,alwaysmatches='' => you get all records with a stocknumber - test in simple search : ccl=stocknumber,alwaysmatches='' => you get the same results Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24739|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25278&action=edit Bug 10544 - add Number-local-acquisition in QueryParser config This patch adds the Number-local-acquisition into QueryParser configuration file. Like in ccl.properties, "Number-local-acquisition" is the main index name and "stocknumber" and "inv" are aliases. Test plan : Enable QueryParser : - Enable UseQueryParser syspref - Edit your koha-conf.xml - Add to "config" node : <queryparser_config>[your path]/etc/searchengine/queryparser.yaml</queryparser_config>, adapt [your patch] to your install configuration folder - If needed copy from sources "etc/searchengine/queryparser.yaml" into your install configuration folder Test search : - Add Number-local-acquisition on an existing subfield in records.abs. For example on item barcode field - Reindex Zebra database - Choose a value of this field that will match some results. For example : "0*" will match all barcodes beginning with zero - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0*&sort_by=relevance => You get some results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=inv&q=0*&sort_by=relevance => You get the same results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=number-local-acquisition&q=0*&sort_by=relevance => You get the same results Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Comments on case sensitivity of index names in QueryParser, see Bugzilla. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #30 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to a master, along with a follow-up that updates the MARC21 DOM configuration. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes.