[Bug 18128] New: 'Go to page' option for search results in opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Bug ID: 18128 Summary: 'Go to page' option for search results in opac and staff Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org As suggested in Bug 13205 Comment 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Depends on| |13205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 [Bug 13205] Last/First page options for result list paging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 60301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60301&action=edit Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Signed Off --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- The patch 13205 apply perfectly. There is no problem jumping from any page to first/last/next/previous page on OPAC or staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Blocked by bug 13205. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60301|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64940&action=edit Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64940|0 |1 is obsolete| | --- Comment #5 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64980&action=edit Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Hi Aleisha, When I try this with a bunch of pages (218) the dropdown only lists the visible pages. If I select page 10, then the pages i can select goes up to 20 as does the dropdown, but the screen is very crowded. screenshot to follow My assumption was the dropdown would go from first page # to last page # and the bar would always be 5 on either side? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67778&action=edit after selecting page 10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68306&action=edit Bug 18128: [FOLLOW-UP] Some display fixes This patch addresses some of the display issues brought up in Comment 6. The dropdown list should now include every page number. The bar will only show up to 5 page numbers on each side of the current active page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Nick Clemens from comment #6)
Hi Aleisha,
When I try this with a bunch of pages (218) the dropdown only lists the visible pages. If I select page 10, then the pages i can select goes up to 20 as does the dropdown, but the screen is very crowded. screenshot to follow
My assumption was the dropdown would go from first page # to last page # and the bar would always be 5 on either side?
Hi Nick Thanks for pointing this out! I've added a follow-up patch that you can test. hopefully this is more to your liking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64980|0 |1 is obsolete| | Attachment #68306|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68325&action=edit Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68326&action=edit Bug 18128: [FOLLOW-UP] Some display fixes This patch addresses some of the display issues brought up in Comment 6. The dropdown list should now include every page number. The bar will only show up to 5 page numbers on each side of the current active page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68325|0 |1 is obsolete| | Attachment #68326|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68720&action=edit Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68721&action=edit Bug 18128: [FOLLOW-UP] Some display fixes This patch addresses some of the display issues brought up in Comment 6. The dropdown list should now include every page number. The bar will only show up to 5 page numbers on each side of the current active page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Fixed conflict with bug 19461 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I see only 1 page, maybe I messed up the rebase. (In reply to Nick Clemens from comment #11)
Created attachment 68326 [details] [review] Bug 18128: [FOLLOW-UP] Some display fixes
This patch addresses some of the display issues brought up in Comment 6.
The dropdown list should now include every page number. The bar will only show up to 5 page numbers on each side of the current active page.
Why? 10 was good number IMO. I'd like more opinion about this change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard@myacpl.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org