https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 98421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98421&action=edit Bug 24585: Add suggested on/managed on columns This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, can you please update your patch to include a bug description and test plan? I think you might have done it in the git bz attach step - but that doesn't change the patch file itself and it's still empty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98421|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 98483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98483&action=edit Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Hasina <shumi78@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shumi78@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98483|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98621&action=edit Bug 24585: Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt This patch adds 2 new columns on the suggestions table on purchase-suggestions.tt. These use the data-order attribute to allow for sorting. TEST PLAN: 1. Have a patron with some suggestions that have been managed by staff. (accept or reject the request). 2. View that patrons suggestions from purchase-suggestions.pl. 3. No suggested on or managaed on columns. 4. Apply patch and reload the page. 5. The new columns are there, have multiple suggestions and make sure sorting by the date works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'Managed on' and |Add 'Managed on' and |'Suggested on' columns to |'Suggested on' columns to |pat_purchase_suggestions.tt |suggestions tab in patron | |account in staff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 16535 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.