From fridolyn.somers@biblibre.com Fri Sep 20 11:18:18 2013
From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: [Koha-devel] datatables management in TT
Date: Fri, 20 Sep 2013 11:18:15 +0200
Message-ID: <523C12D7.8090801@biblibre.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0967012622615607343=="

--===============0967012622615607343==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hie,

Looking at datatables in templates, I notices there are two ways it is 
managed.

In some pages of acquisition and in OPAC, the include datatables.inc 
(containing JS links and translatable strings) is used + the css :

   <link rel="stylesheet" type="text/css" href="[% themelang 
%]/css/datatables.css" />
   [% INCLUDE 'datatables.inc' %]

In more cases, this include is not used and datatables-strings.inc is 
used for translatable strings :
   <link rel="stylesheet" type="text/css" href="[% themelang 
%]/css/datatables.css" />
   <script type="text/javascript" src="[% themelang 
%]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
   [% INCLUDE 'datatables-strings.inc' %]
   <script type="text/javascript" src="[% themelang %]/js/datatables.js">

Wouldn't it be better to always use one include containing everything ?
I think adding the CSS to existing datatables.inc can make the point.

-- 
Fridolyn SOMERS
Biblibre - Pôle support
fridolyn.somers@biblibre.com

--===============0967012622615607343==--


From jonathan.druart@biblibre.com Fri Sep 20 11:41:55 2013
From: Jonathan Druart <jonathan.druart@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] datatables management in TT
Date: Fri, 20 Sep 2013 11:41:52 +0200
Message-ID:
 <CAJzKNY5pYmBsZQnPgjqC5=phWTLfiXC11rV30yTDxMGgeFxtTQ@mail.gmail.com>
In-Reply-To: <523C12D7.8090801@biblibre.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3305054740861686600=="

--===============3305054740861686600==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Fridolyn,

Take a look at bugs 10651 and bug 10868, I QAed 1 hour ago :)

Jonathan

2013/9/20 Fridolyn SOMERS <fridolyn.somers@biblibre.com>:
> Hie,
>
> Looking at datatables in templates, I notices there are two ways it is
> managed.
>
> In some pages of acquisition and in OPAC, the include datatables.inc
> (containing JS links and translatable strings) is used + the css :
>
>   <link rel="stylesheet" type="text/css" href="[% themelang
> %]/css/datatables.css" />
>   [% INCLUDE 'datatables.inc' %]
>
> In more cases, this include is not used and datatables-strings.inc is used
> for translatable strings :
>   <link rel="stylesheet" type="text/css" href="[% themelang
> %]/css/datatables.css" />
>   <script type="text/javascript" src="[% themelang
> %]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
>   [% INCLUDE 'datatables-strings.inc' %]
>   <script type="text/javascript" src="[% themelang %]/js/datatables.js">
>
> Wouldn't it be better to always use one include containing everything ?
> I think adding the CSS to existing datatables.inc can make the point.
>
> --
> Fridolyn SOMERS
> Biblibre - Pôle support
> fridolyn.somers@biblibre.com
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/

--===============3305054740861686600==--


From fridolyn.somers@biblibre.com Fri Sep 20 12:14:46 2013
From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] datatables management in TT
Date: Fri, 20 Sep 2013 12:14:41 +0200
Message-ID: <523C2011.30108@biblibre.com>
In-Reply-To:
 <CAJzKNY5pYmBsZQnPgjqC5=phWTLfiXC11rV30yTDxMGgeFxtTQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7473380950619049474=="

--===============7473380950619049474==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Ok, perfect.

But why not include [% themelang %]/css/datatables.css into datatables.inc ?

Le 20/09/2013 11:41, Jonathan Druart a écrit :
> Fridolyn,
>
> Take a look at bugs 10651 and bug 10868, I QAed 1 hour ago :)
>
> Jonathan
>
> 2013/9/20 Fridolyn SOMERS <fridolyn.somers@biblibre.com>:
>> Hie,
>>
>> Looking at datatables in templates, I notices there are two ways it is
>> managed.
>>
>> In some pages of acquisition and in OPAC, the include datatables.inc
>> (containing JS links and translatable strings) is used + the css :
>>
>>    <link rel="stylesheet" type="text/css" href="[% themelang
>> %]/css/datatables.css" />
>>    [% INCLUDE 'datatables.inc' %]
>>
>> In more cases, this include is not used and datatables-strings.inc is used
>> for translatable strings :
>>    <link rel="stylesheet" type="text/css" href="[% themelang
>> %]/css/datatables.css" />
>>    <script type="text/javascript" src="[% themelang
>> %]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
>>    [% INCLUDE 'datatables-strings.inc' %]
>>    <script type="text/javascript" src="[% themelang %]/js/datatables.js">
>>
>> Wouldn't it be better to always use one include containing everything ?
>> I think adding the CSS to existing datatables.inc can make the point.
>>
>> --
>> Fridolyn SOMERS
>> Biblibre - Pôle support
>> fridolyn.somers@biblibre.com
>> _______________________________________________
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : http://www.koha-community.org/
>> git : http://git.koha-community.org/
>> bugs : http://bugs.koha-community.org/

-- 
Fridolyn SOMERS
Biblibre - Pôle support
fridolyn.somers@biblibre.com

--===============7473380950619049474==--


From jonathan.druart@biblibre.com Fri Sep 20 12:16:57 2013
From: Jonathan Druart <jonathan.druart@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] datatables management in TT
Date: Fri, 20 Sep 2013 12:16:54 +0200
Message-ID:
 <CAJzKNY5Un_TXEP5QFgwrgScBxBHOAuCMEa8SwaoBEehaFSbSow@mail.gmail.com>
In-Reply-To: <523C2011.30108@biblibre.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7221260010511970526=="

--===============7221260010511970526==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

See my comment 5 (bug 10651). I asked the same thing to Owen :)

2013/9/20 Fridolyn SOMERS <fridolyn.somers@biblibre.com>:
> Ok, perfect.
>
> But why not include [% themelang %]/css/datatables.css into datatables.inc ?
>
> Le 20/09/2013 11:41, Jonathan Druart a écrit :
>
>> Fridolyn,
>>
>> Take a look at bugs 10651 and bug 10868, I QAed 1 hour ago :)
>>
>> Jonathan
>>
>> 2013/9/20 Fridolyn SOMERS <fridolyn.somers@biblibre.com>:
>>>
>>> Hie,
>>>
>>> Looking at datatables in templates, I notices there are two ways it is
>>> managed.
>>>
>>> In some pages of acquisition and in OPAC, the include datatables.inc
>>> (containing JS links and translatable strings) is used + the css :
>>>
>>>    <link rel="stylesheet" type="text/css" href="[% themelang
>>> %]/css/datatables.css" />
>>>    [% INCLUDE 'datatables.inc' %]
>>>
>>> In more cases, this include is not used and datatables-strings.inc is
>>> used
>>> for translatable strings :
>>>    <link rel="stylesheet" type="text/css" href="[% themelang
>>> %]/css/datatables.css" />
>>>    <script type="text/javascript" src="[% themelang
>>> %]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
>>>    [% INCLUDE 'datatables-strings.inc' %]
>>>    <script type="text/javascript" src="[% themelang %]/js/datatables.js">
>>>
>>> Wouldn't it be better to always use one include containing everything ?
>>> I think adding the CSS to existing datatables.inc can make the point.
>>>
>>> --
>>> Fridolyn SOMERS
>>> Biblibre - Pôle support
>>> fridolyn.somers@biblibre.com
>>> _______________________________________________
>>> Koha-devel mailing list
>>> Koha-devel@lists.koha-community.org
>>> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>> website : http://www.koha-community.org/
>>> git : http://git.koha-community.org/
>>> bugs : http://bugs.koha-community.org/
>
>
> --
> Fridolyn SOMERS
> Biblibre - Pôle support
> fridolyn.somers@biblibre.com
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/

--===============7221260010511970526==--


From oleonard@myacpl.org Fri Sep 20 14:46:06 2013
From: Owen Leonard <oleonard@myacpl.org>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] datatables management in TT
Date: Fri, 20 Sep 2013 08:45:55 -0400
Message-ID:
 <CAO4qe2OnGoT0KvnQ8RZ--2X02_8L139bDYWvp8m8FkLSEewWPQ@mail.gmail.com>
In-Reply-To:
 <CAJzKNY5Un_TXEP5QFgwrgScBxBHOAuCMEa8SwaoBEehaFSbSow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2547431202211955885=="

--===============2547431202211955885==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> Wouldn't it be better to always use one include containing everything ?
> I think adding the CSS to existing datatables.inc can make the point.

Perhaps it would have been better to do it that way. I was thinking of
a time in the future when I would like to move all JavaScript to the
end of each page instead of the beginning, and CSS would need to stay
at the top.

  -- Owen

-- 
Web Developer
Athens County Public Libraries
http://www.myacpl.org

--===============2547431202211955885==--


From fridolyn.somers@biblibre.com Fri Sep 20 17:25:32 2013
From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] datatables management in TT
Date: Fri, 20 Sep 2013 17:25:29 +0200
Message-ID: <523C68E9.2040000@biblibre.com>
In-Reply-To:
 <CAO4qe2OnGoT0KvnQ8RZ--2X02_8L139bDYWvp8m8FkLSEewWPQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7183107217334972536=="

--===============7183107217334972536==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

An HTML page build with a template can not be perfect I'd say.
I prefer a more comprehensive template.
But no big deal.

Le 20/09/2013 14:45, Owen Leonard a écrit :
>> Wouldn't it be better to always use one include containing everything ?
>> I think adding the CSS to existing datatables.inc can make the point.
>
> Perhaps it would have been better to do it that way. I was thinking of
> a time in the future when I would like to move all JavaScript to the
> end of each page instead of the beginning, and CSS would need to stay
> at the top.
>
>    -- Owen
>

-- 
Fridolyn SOMERS
Biblibre - Pôle support
fridolyn.somers@biblibre.com

--===============7183107217334972536==--