From dpavlin@rot13.org Thu Oct 14 17:49:18 2010 From: Dobrica Pavlinusic To: koha-devel@lists.koha-community.org Subject: [Koha-devel] CloneSubfields and problems with it Date: Thu, 14 Oct 2010 17:48:40 +0200 Message-ID: <20101014154840.GA30706@rot13.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2655675534131728529==" --===============2655675534131728529== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable We are running latest git in our production, and we have stumbled upon variation of bug reported at: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D3264 We are having problems with cataloguing/addbiblio.tmpl which doesn't correctly clone subfields (it always clone first one) and after removing one subfield whole JavaScript breaks. After spending a day looking at current code, I decided to try to re-implement it. My motivation is following: - currently code is injected in html page. This makes page load slow, because browser has to stop everything until it parse JavaScript - there is variation of same methods in authorities/authorities.tmpl but it has it's own problems. Splitting code into separate, page-independent reusable code would benefit both of problems To do that I moved selected element into anchor of link, so it can be accessed (and updated) easily from JavaScript. Result is following code: function _subfield_id(a) { console.debug( '_subfield_id', a ); return a.href.substr( a.href.indexOf('#')+1 ); } function clone_subfield( from_a ) { console.debug( 'clone_subfield', from_a ); var subfield_id =3D _subfield_id(from_a); var $original =3D $('#' + subfield_id); var $clone =3D $original.clone(); var new_key =3D CreateKey(); $clone .attr('id', subfield_id + new_key ) .find('input,select,textarea').each( function() { $(this) .attr('id', function() { return this.id + new_key }) .attr('name', function() { return this.name + new_key }) ; }) .end() .find('label').attr('for', function() { return this.for + new_key }) .end() .find('.subfield_controls > a').each( function() { this.href =3D '#' + subfield_id + new_key; console.debug( 'fix href', this.href ); }) ; console.debug( 'clone', $clone ); $clone.insertAfter( $original ); } function remove_subfield( from_a ) { console.debug( 'remove_subfield', from_a ); var subfield_id =3D _subfield_id(from_a); $('#'+subfield_id).remove(); } with html change: " onclick=3D"clone_subfield(this); r= eturn false;">3D"= " onclick=3D"remove_subfield(this); = return false;">=3D"Delete" for comparison, take at look at 77 lines of CloneSubfield alone in current ko= ha code. However, I'm very aware that my solution is very jquery-eske, and might be too much for people who haven't used jquery before. I also used $o notation in JavaScript for jQuery objects, and that might also be confusing. I would also love to use event bubbling using .live instead of attaching all click handlers, but I have to check how reliably it works with jquery 1.3.2 which koha uses. Would such a change be accepted into Koha and does it make sense to peruse this refactoring? If you want to follow along this experiment, there is a branch for it in our git: http://git.rot13.org/?p=3Dkoha.git;a=3Dshortlog;h=3Drefs/heads/clone-subfield= s-jquery --=20 Dobrica Pavlinusic 2share!2flame dpavlin@rot13.org Unix addict. Internet consultant. http://www.rot13.org/~dpavlin --===============2655675534131728529==-- From chris@bigballofwax.co.nz Thu Oct 14 21:18:55 2010 From: Chris Cormack To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] CloneSubfields and problems with it Date: Fri, 15 Oct 2010 08:18:16 +1300 Message-ID: In-Reply-To: <20101014154840.GA30706@rot13.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8833599734810433364==" --===============8833599734810433364== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 15 October 2010 04:48, Dobrica Pavlinusic wrote: > We are running latest git in our production, and we have stumbled upon > variation of bug reported at: > > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D3264 > > We are having problems with cataloguing/addbiblio.tmpl which doesn't > correctly clone subfields (it always clone first one) and after > removing one subfield whole JavaScript breaks. > > After spending a day looking at current code, I decided to try to > re-implement it. My motivation is following: > > > Would such a change be accepted into Koha and does it make sense to > peruse this refactoring? There's nothing in it that sets off my alarm bells, I would of course ask people like Owen who do far more front end work than me to check it. But certainly it is worth pursuing. Anything you can do to make that whole page load faster, would be gratefully received also Chris > > If you want to follow along this experiment, there is a > branch for it in our git: > > http://git.rot13.org/?p=3Dkoha.git;a=3Dshortlog;h=3Drefs/heads/clone-subfie= lds-jquery > > -- > Dobrica Pavlinusic =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2share!= 2flame =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dpavlin@rot13.org > Unix addict. Internet consultant. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= http://www.rot13.org/~dpavlin > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > --===============8833599734810433364==-- From gmcharlt@gmail.com Fri Oct 15 00:15:27 2010 From: Galen Charlton To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] CloneSubfields and problems with it Date: Thu, 14 Oct 2010 18:15:12 -0400 Message-ID: In-Reply-To: <20101014154840.GA30706@rot13.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4230589314341747529==" --===============4230589314341747529== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 14, 2010 at 11:48 AM, Dobrica Pavlinusic wrot= e: > However, I'm very aware that my solution is very jquery-eske, and might > be too much for people who haven't used jquery before. Being "jQuery-esque" isn't a problem at all - Koha uses jQuery anyway, and using a framework is almost almost better than dealing with hand-written JavaScript code to walk the DOM. Regards, Galen --=20 Galen Charlton gmcharlt@gmail.com --===============4230589314341747529==-- From chris.nighswonger@gmail.com Fri Oct 15 00:20:54 2010 From: Christopher Nighswonger To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] CloneSubfields and problems with it Date: Thu, 14 Oct 2010 18:20:03 -0400 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0392616426957763263==" --===============0392616426957763263== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2010 at 3:18 PM, Chris Cormack wro= te: > >> >> Would such a change be accepted into Koha and does it make sense to >> peruse this refactoring? > > There's nothing in it that sets off my alarm bells, I would of course > ask people like Owen who do far more front end work than me to check > it. But certainly it is worth pursuing. > > Anything you can do to make that whole page load faster, would be > gratefully received also I have to agree with Chris here, anything which improves the speed of this page would be a welcomed improvement. Kind Regards, Chris --===============0392616426957763263==-- From oleonard@myacpl.org Fri Oct 15 16:09:47 2010 From: Owen Leonard To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] CloneSubfields and problems with it Date: Fri, 15 Oct 2010 10:09:23 -0400 Message-ID: In-Reply-To: <20101014154840.GA30706@rot13.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4563212059811718167==" --===============4563212059811718167== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > - currently code is injected in html page. This makes page load slow, >  because browser has to stop everything until it parse JavaScript Agreed. However much of the embedded script is reliant on TMPL variables, so it's not possible to eliminate it from the template. > However, I'm very aware that my solution is very jquery-eske, and might > be too much for people who haven't used jquery before. As others have said, we use jQuery in many places in Koha so there's no problem here. > I would also love to use event bubbling using .live instead of attaching > all click handlers, but I have to check how reliably it works with > jquery 1.3.2 which koha uses. Upgrading the version of jQuery Koha uses should be a to-do item for 3.4. > Would such a change be accepted into Koha and does it make sense to > peruse this refactoring? Anything that will improve the performance of this page will be very much welcomed. Thanks for sharing, -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org --===============4563212059811718167==-- From fridolyn.somers@gmail.com Fri Oct 15 17:39:30 2010 From: Fridolyn SOMERS To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] CloneSubfields and problems with it Date: Fri, 15 Oct 2010 17:38:53 +0200 Message-ID: In-Reply-To: <20101014154840.GA30706@rot13.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1506198916080513713==" --===============1506198916080513713== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hie, Notice that I proposed a patch for bug 3264. Indeed, a JQuery-like solution is far better. I also use is at 99% in Javascript. Don't forget to change also Authorities MARC edition. It is nearly the same code a for Biblios. I don't know why there are differences. Regards, --=20 Fridolyn SOMERS ICT engineer PROGILONE SAS - Lyon - France fridolyn.somers@gmail.com On Thu, Oct 14, 2010 at 5:48 PM, Dobrica Pavlinusic wrote: > We are running latest git in our production, and we have stumbled upon > variation of bug reported at: > > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D3264 > > We are having problems with cataloguing/addbiblio.tmpl which doesn't > correctly clone subfields (it always clone first one) and after > removing one subfield whole JavaScript breaks. > > After spending a day looking at current code, I decided to try to > re-implement it. My motivation is following: > > - currently code is injected in html page. This makes page load slow, > because browser has to stop everything until it parse JavaScript > - there is variation of same methods in authorities/authorities.tmpl > but it has it's own problems. Splitting code into separate, > page-independent reusable code would benefit both of problems > > To do that I moved selected element into anchor of link, so it can be > accessed (and updated) easily from JavaScript. Result is following code: > > function _subfield_id(a) { > console.debug( '_subfield_id', a ); > return a.href.substr( a.href.indexOf('#')+1 ); > } > > function clone_subfield( from_a ) { > console.debug( 'clone_subfield', from_a ); > var subfield_id =3D _subfield_id(from_a); > var $original =3D $('#' + subfield_id); > var $clone =3D $original.clone(); > var new_key =3D CreateKey(); > > $clone > .attr('id', subfield_id + new_key ) > .find('input,select,textarea').each( function() { > $(this) > .attr('id', function() { return this.id + new_key }) > .attr('name', function() { return this.name + new_key }) > ; > }) > .end() > .find('label').attr('for', function() { return this.for + new_key }) > .end() > .find('.subfield_controls > a').each( function() { > this.href =3D '#' + subfield_id + new_key; > console.debug( 'fix href', this.href ); > }) > ; > > console.debug( 'clone', $clone ); > > $clone.insertAfter( $original ); > } > > function remove_subfield( from_a ) { > console.debug( 'remove_subfield', from_a ); > var subfield_id =3D _subfield_id(from_a); > $('#'+subfield_id).remove(); > } > > > with html change: > > > " onclick=3D"clone_subfield(this); retu= rn > false;">3D"Clon= title=3D"Clone this subfield" /> > " onclick=3D"remove_subfield(this); ret= urn > false;">3D"Del= title=3D"Delete this subfield" /> > > > for comparison, take at look at 77 lines of CloneSubfield alone in current > koha code. > > However, I'm very aware that my solution is very jquery-eske, and might > be too much for people who haven't used jquery before. I also used $o > notation in JavaScript for jQuery objects, and that might also be > confusing. > > I would also love to use event bubbling using .live instead of attaching > all click handlers, but I have to check how reliably it works with > jquery 1.3.2 which koha uses. > > Would such a change be accepted into Koha and does it make sense to > peruse this refactoring? > > If you want to follow along this experiment, there is a > branch for it in our git: > > > http://git.rot13.org/?p=3Dkoha.git;a=3Dshortlog;h=3Drefs/heads/clone-subfie= lds-jquery > > -- > Dobrica Pavlinusic 2share!2flame > dpavlin@rot13.org > Unix addict. Internet consultant. > http://www.rot13.org/~dpavlin > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > --===============1506198916080513713== Content-Type: text/html Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.html" MIME-Version: 1.0 SGllLDxicj48YnI+Tm90aWNlIHRoYXQgSSBwcm9wb3NlZCBhIHBhdGNoIGZvciBidWcgMzI2NC48 YnI+PGJyPkluZGVlZCwgYSBKUXVlcnktbGlrZSBzb2x1dGlvbiBpcyBmYXIgYmV0dGVyLjxicj5J IGFsc28gdXNlIGlzIGF0IDk5JSBpbiBKYXZhc2NyaXB0Ljxicj48YnI+RG9uJiMzOTt0IGZvcmdl dCB0byBjaGFuZ2UgYWxzbyBBdXRob3JpdGllcyBNQVJDIGVkaXRpb24uPGJyPkl0IGlzIG5lYXJs eSB0aGUgc2FtZSBjb2RlIGEgZm9yIEJpYmxpb3MuIEkgZG9uJiMzOTt0IGtub3cgd2h5IHRoZXJl IGFyZSBkaWZmZXJlbmNlcy48YnI+Cgo8YnI+UmVnYXJkcyw8YnI+PGJyPi0tIDxicj5Gcmlkb2x5 biBTT01FUlM8YnI+SUNUIGVuZ2luZWVyPGJyPlBST0dJTE9ORSBTQVMgLSBMeW9uIC0gRnJhbmNl PGJyPjxhIGhyZWY9Im1haWx0bzpmcmlkb2x5bi5zb21lcnNAZ21haWwuY29tIiB0YXJnZXQ9Il9i bGFuayI+ZnJpZG9seW4uc29tZXJzQGdtYWlsLmNvbTwvYT48YnI+PGJyPjxkaXYgY2xhc3M9Imdt YWlsX3F1b3RlIj5PbiBUaHUsIE9jdCAxNCwgMjAxMCBhdCA1OjQ4IFBNLCBEb2JyaWNhIFBhdmxp bnVzaWMgPHNwYW4gZGlyPSJsdHIiPiZsdDs8YSBocmVmPSJtYWlsdG86ZHBhdmxpbkByb3QxMy5v cmciPmRwYXZsaW5Acm90MTMub3JnPC9hPiZndDs8L3NwYW4+IHdyb3RlOjxicj4KCjxibG9ja3F1 b3RlIGNsYXNzPSJnbWFpbF9xdW90ZSIgc3R5bGU9Im1hcmdpbjogMHB0IDBwdCAwcHQgMC44ZXg7 IGJvcmRlci1sZWZ0OiAxcHggc29saWQgcmdiKDIwNCwgMjA0LCAyMDQpOyBwYWRkaW5nLWxlZnQ6 IDFleDsiPldlIGFyZSBydW5uaW5nIGxhdGVzdCBnaXQgaW4gb3VyIHByb2R1Y3Rpb24sIGFuZCB3 ZSBoYXZlIHN0dW1ibGVkIHVwb248YnI+CnZhcmlhdGlvbiBvZiBidWcgcmVwb3J0ZWQgYXQ6PGJy Pgo8YnI+CjxhIGhyZWY9Imh0dHA6Ly9idWdzLmtvaGEtY29tbXVuaXR5Lm9yZy9idWd6aWxsYTMv c2hvd19idWcuY2dpP2lkPTMyNjQiIHRhcmdldD0iX2JsYW5rIj5odHRwOi8vYnVncy5rb2hhLWNv bW11bml0eS5vcmcvYnVnemlsbGEzL3Nob3dfYnVnLmNnaT9pZD0zMjY0PC9hPjxicj4KPGJyPgpX ZSBhcmUgaGF2aW5nIHByb2JsZW1zIHdpdGggY2F0YWxvZ3VpbmcvYWRkYmlibGlvLnRtcGwgd2hp Y2ggZG9lc24mIzM5O3Q8YnI+CmNvcnJlY3RseSBjbG9uZSBzdWJmaWVsZHMgKGl0IGFsd2F5cyBj bG9uZSBmaXJzdCBvbmUpIGFuZCBhZnRlcjxicj4KcmVtb3Zpbmcgb25lIHN1YmZpZWxkIHdob2xl IEphdmFTY3JpcHQgYnJlYWtzLjxicj4KPGJyPgpBZnRlciBzcGVuZGluZyBhIGRheSBsb29raW5n IGF0IGN1cnJlbnQgY29kZSwgSSBkZWNpZGVkIHRvIHRyeSB0bzxicj4KcmUtaW1wbGVtZW50IGl0 LiBNeSBtb3RpdmF0aW9uIGlzIGZvbGxvd2luZzo8YnI+Cjxicj4KLSBjdXJyZW50bHkgY29kZSBp cyBpbmplY3RlZCBpbiBodG1sIHBhZ2UuIFRoaXMgbWFrZXMgcGFnZSBsb2FkIHNsb3csPGJyPgog oGJlY2F1c2UgYnJvd3NlciBoYXMgdG8gc3RvcCBldmVyeXRoaW5nIHVudGlsIGl0IHBhcnNlIEph dmFTY3JpcHQ8YnI+Ci0gdGhlcmUgaXMgdmFyaWF0aW9uIG9mIHNhbWUgbWV0aG9kcyBpbiBhdXRo b3JpdGllcy9hdXRob3JpdGllcy50bXBsPGJyPgogoGJ1dCBpdCBoYXMgaXQmIzM5O3Mgb3duIHBy b2JsZW1zLiBTcGxpdHRpbmcgY29kZSBpbnRvIHNlcGFyYXRlLDxicj4KIKBwYWdlLWluZGVwZW5k ZW50IHJldXNhYmxlIGNvZGUgd291bGQgYmVuZWZpdCBib3RoIG9mIHByb2JsZW1zPGJyPgo8YnI+ ClRvIGRvIHRoYXQgSSBtb3ZlZCBzZWxlY3RlZCBlbGVtZW50IGludG8gYW5jaG9yIG9mIGxpbmss IHNvIGl0IGNhbiBiZTxicj4KYWNjZXNzZWQgKGFuZCB1cGRhdGVkKSBlYXNpbHkgZnJvbSBKYXZh U2NyaXB0LiBSZXN1bHQgaXMgZm9sbG93aW5nIGNvZGU6PGJyPgo8YnI+CmZ1bmN0aW9uIF9zdWJm aWVsZF9pZChhKSB7PGJyPgogoCCgIKAgoGNvbnNvbGUuZGVidWcoICYjMzk7X3N1YmZpZWxkX2lk JiMzOTssIGEgKTs8YnI+CiCgIKAgoCCgcmV0dXJuIGEuaHJlZi5zdWJzdHIoIGEuaHJlZi5pbmRl eE9mKCYjMzk7IyYjMzk7KSsxICk7PGJyPgp9PGJyPgo8YnI+CmZ1bmN0aW9uIGNsb25lX3N1YmZp ZWxkKCBmcm9tX2EgKSB7PGJyPgogoCCgIKAgoGNvbnNvbGUuZGVidWcoICYjMzk7Y2xvbmVfc3Vi ZmllbGQmIzM5OywgZnJvbV9hICk7PGJyPgogoCCgIKAgoHZhciBzdWJmaWVsZF9pZCA9IF9zdWJm aWVsZF9pZChmcm9tX2EpOzxicj4KIKAgoCCgIKB2YXIgJG9yaWdpbmFsIKAgPSAkKCYjMzk7IyYj Mzk7ICsgc3ViZmllbGRfaWQpOzxicj4KIKAgoCCgIKB2YXIgJGNsb25lIKAgoCCgPSAkb3JpZ2lu YWwuY2xvbmUoKTs8YnI+CiCgIKAgoCCgdmFyIG5ld19rZXkgoCCgID0gQ3JlYXRlS2V5KCk7PGJy Pgo8YnI+CiCgIKAgoCCgJGNsb25lPGJyPgogoCCgIKAgoC5hdHRyKCYjMzk7aWQmIzM5Oywgc3Vi ZmllbGRfaWQgKyBuZXdfa2V5ICk8YnI+CiCgIKAgoCCgLmZpbmQoJiMzOTtpbnB1dCxzZWxlY3Qs dGV4dGFyZWEmIzM5OykuZWFjaCggZnVuY3Rpb24oKSB7PGJyPgogoCCgIKAgoCCgIKAgoCCgJCh0 aGlzKTxicj4KIKAgoCCgIKAgoCCgIKAgoC5hdHRyKCYjMzk7aWQmIzM5OywgoCBmdW5jdGlvbigp IHsgcmV0dXJuIDxhIGhyZWY9Imh0dHA6Ly90aGlzLmlkIiB0YXJnZXQ9Il9ibGFuayI+dGhpcy5p ZDwvYT4goCArIG5ld19rZXkgfSk8YnI+CiCgIKAgoCCgIKAgoCCgIKAuYXR0cigmIzM5O25hbWUm IzM5OywgZnVuY3Rpb24oKSB7IHJldHVybiA8YSBocmVmPSJodHRwOi8vdGhpcy5uYW1lIiB0YXJn ZXQ9Il9ibGFuayI+dGhpcy5uYW1lPC9hPiArIG5ld19rZXkgfSk8YnI+CiCgIKAgoCCgIKAgoCCg IKA7PGJyPgogoCCgIKAgoH0pPGJyPgogoCCgIKAgoC5lbmQoKTxicj4KIKAgoCCgIKAuZmluZCgm IzM5O2xhYmVsJiMzOTspLmF0dHIoJiMzOTtmb3ImIzM5OywgZnVuY3Rpb24oKSB7IHJldHVybiB0 aGlzLmZvciArIG5ld19rZXkgfSk8YnI+CiCgIKAgoCCgLmVuZCgpPGJyPgogoCCgIKAgoC5maW5k KCYjMzk7LnN1YmZpZWxkX2NvbnRyb2xzICZndDsgYSYjMzk7KS5lYWNoKCBmdW5jdGlvbigpIHs8 YnI+CiCgIKAgoCCgIKAgoCCgIKB0aGlzLmhyZWYgPSAmIzM5OyMmIzM5OyArIHN1YmZpZWxkX2lk ICsgbmV3X2tleTs8YnI+CiCgIKAgoCCgIKAgoCCgIKBjb25zb2xlLmRlYnVnKCAmIzM5O2ZpeCBo cmVmJiMzOTssIHRoaXMuaHJlZiApOzxicj4KIKAgoCCgIKB9KTxicj4KIKAgoCCgIKA7PGJyPgo8 YnI+CiCgIKAgoCCgY29uc29sZS5kZWJ1ZyggJiMzOTtjbG9uZSYjMzk7LCAkY2xvbmUgKTs8YnI+ Cjxicj4KIKAgoCCgIKAkY2xvbmUuaW5zZXJ0QWZ0ZXIoICRvcmlnaW5hbCApOzxicj4KfTxicj4K PGJyPgpmdW5jdGlvbiByZW1vdmVfc3ViZmllbGQoIGZyb21fYSApIHs8YnI+CiCgIKAgoCCgY29u c29sZS5kZWJ1ZyggJiMzOTtyZW1vdmVfc3ViZmllbGQmIzM5OywgZnJvbV9hICk7PGJyPgogoCCg IKAgoHZhciBzdWJmaWVsZF9pZCA9IF9zdWJmaWVsZF9pZChmcm9tX2EpOzxicj4KIKAgoCCgIKAk KCYjMzk7IyYjMzk7K3N1YmZpZWxkX2lkKS5yZW1vdmUoKTs8YnI+Cn08YnI+Cjxicj4KPGJyPgp3 aXRoIGh0bWwgY2hhbmdlOjxicj4KPGJyPgombHQ7c3BhbiBjbGFzcz0mcXVvdDtzdWJmaWVsZF9j b250cm9scyZxdW90OyZndDs8YnI+CiZsdDthIGhyZWY9JnF1b3Q7I3N1YmZpZWxkJmx0OyEtLSBU TVBMX1ZBUiBOQU1FPSYjMzk7dGFnJiMzOTsgLS0mZ3Q7Jmx0OyEtLSBUTVBMX1ZBUiBOQU1FPSYj Mzk7c3ViZmllbGQmIzM5OyAtLSZndDsmbHQ7IS0tIFRNUExfVkFSIG5hbWU9JnF1b3Q7cmFuZG9t JnF1b3Q7IC0tJmd0OyZxdW90OyBvbmNsaWNrPSZxdW90O2Nsb25lX3N1YmZpZWxkKHRoaXMpOyBy ZXR1cm4gZmFsc2U7JnF1b3Q7Jmd0OyZsdDtpbWcgc3JjPSZxdW90Oy9pbnRyYW5ldC10bXBsL3By b2cvaW1nL2Nsb25lLXN1YmZpZWxkLnBuZyZxdW90OyBhbHQ9JnF1b3Q7Q2xvbmUmcXVvdDsgdGl0 bGU9JnF1b3Q7Q2xvbmUgdGhpcyBzdWJmaWVsZCZxdW90OyAvJmd0OyZsdDsvYSZndDs8YnI+CgoK Jmx0O2EgaHJlZj0mcXVvdDsjc3ViZmllbGQmbHQ7IS0tIFRNUExfVkFSIE5BTUU9JiMzOTt0YWcm IzM5OyAtLSZndDsmbHQ7IS0tIFRNUExfVkFSIE5BTUU9JiMzOTtzdWJmaWVsZCYjMzk7IC0tJmd0 OyZsdDshLS0gVE1QTF9WQVIgbmFtZT0mcXVvdDtyYW5kb20mcXVvdDsgLS0mZ3Q7JnF1b3Q7IG9u Y2xpY2s9JnF1b3Q7cmVtb3ZlX3N1YmZpZWxkKHRoaXMpOyByZXR1cm4gZmFsc2U7JnF1b3Q7Jmd0 OyZsdDtpbWcgc3JjPSZxdW90Oy9pbnRyYW5ldC10bXBsL3Byb2cvaW1nL2RlbGV0ZS1zdWJmaWVs ZC5wbmcmcXVvdDsgYWx0PSZxdW90O0RlbGV0ZSZxdW90OyB0aXRsZT0mcXVvdDtEZWxldGUgdGhp cyBzdWJmaWVsZCZxdW90OyAvJmd0OyZsdDsvYSZndDs8YnI+CgoKJmx0Oy9zcGFuJmd0Ozxicj4K PGJyPgpmb3IgY29tcGFyaXNvbiwgdGFrZSBhdCBsb29rIGF0IDc3IGxpbmVzIG9mIENsb25lU3Vi ZmllbGQgYWxvbmUgaW4gY3VycmVudCBrb2hhIGNvZGUuPGJyPgo8YnI+Ckhvd2V2ZXIsIEkmIzM5 O20gdmVyeSBhd2FyZSB0aGF0IG15IHNvbHV0aW9uIGlzIHZlcnkganF1ZXJ5LWVza2UsIGFuZCBt aWdodDxicj4KYmUgdG9vIG11Y2ggZm9yIHBlb3BsZSB3aG8gaGF2ZW4mIzM5O3QgdXNlZCBqcXVl cnkgYmVmb3JlLiBJIGFsc28gdXNlZCAkbzxicj4Kbm90YXRpb24gaW4gSmF2YVNjcmlwdCBmb3Ig alF1ZXJ5IG9iamVjdHMsIGFuZCB0aGF0IG1pZ2h0IGFsc28gYmU8YnI+CmNvbmZ1c2luZy48YnI+ Cjxicj4KSSB3b3VsZCBhbHNvIGxvdmUgdG8gdXNlIGV2ZW50IGJ1YmJsaW5nIHVzaW5nIC5saXZl IGluc3RlYWQgb2YgYXR0YWNoaW5nPGJyPgphbGwgY2xpY2sgaGFuZGxlcnMsIGJ1dCBJIGhhdmUg dG8gY2hlY2sgaG93IHJlbGlhYmx5IGl0IHdvcmtzIHdpdGg8YnI+CmpxdWVyeSAxLjMuMiB3aGlj aCBrb2hhIHVzZXMuPGJyPgo8YnI+CldvdWxkIHN1Y2ggYSBjaGFuZ2UgYmUgYWNjZXB0ZWQgaW50 byBLb2hhIGFuZCBkb2VzIGl0IG1ha2Ugc2Vuc2UgdG88YnI+CnBlcnVzZSB0aGlzIHJlZmFjdG9y aW5nPzxicj4KPGJyPgpJZiB5b3Ugd2FudCB0byBmb2xsb3cgYWxvbmcgdGhpcyBleHBlcmltZW50 LCB0aGVyZSBpcyBhPGJyPgpicmFuY2ggZm9yIGl0IGluIG91ciBnaXQ6PGJyPgo8YnI+CjxhIGhy ZWY9Imh0dHA6Ly9naXQucm90MTMub3JnLz9wPWtvaGEuZ2l0O2E9c2hvcnRsb2c7aD1yZWZzL2hl YWRzL2Nsb25lLXN1YmZpZWxkcy1qcXVlcnkiIHRhcmdldD0iX2JsYW5rIj5odHRwOi8vZ2l0LnJv dDEzLm9yZy8/cD1rb2hhLmdpdDthPXNob3J0bG9nO2g9cmVmcy9oZWFkcy9jbG9uZS1zdWJmaWVs ZHMtanF1ZXJ5PC9hPjxicj4KPGZvbnQgY29sb3I9IiM4ODg4ODgiPjxicj4KLS08YnI+CkRvYnJp Y2EgUGF2bGludXNpYyCgIKAgoCCgIKAgoCCgIDJzaGFyZSEyZmxhbWUgoCCgIKAgoCCgIKA8YSBo cmVmPSJtYWlsdG86ZHBhdmxpbkByb3QxMy5vcmciPmRwYXZsaW5Acm90MTMub3JnPC9hPjxicj4K VW5peCBhZGRpY3QuIEludGVybmV0IGNvbnN1bHRhbnQuIKAgoCCgIKAgoCCgIDxhIGhyZWY9Imh0 dHA6Ly93d3cucm90MTMub3JnLyU3RWRwYXZsaW4iIHRhcmdldD0iX2JsYW5rIj5odHRwOi8vd3d3 LnJvdDEzLm9yZy9+ZHBhdmxpbjwvYT48YnI+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fPGJyPgpLb2hhLWRldmVsIG1haWxpbmcgbGlzdDxicj4KPGEgaHJl Zj0ibWFpbHRvOktvaGEtZGV2ZWxAbGlzdHMua29oYS1jb21tdW5pdHkub3JnIj5Lb2hhLWRldmVs QGxpc3RzLmtvaGEtY29tbXVuaXR5Lm9yZzwvYT48YnI+CjxhIGhyZWY9Imh0dHA6Ly9saXN0cy5r b2hhLWNvbW11bml0eS5vcmcvY2dpLWJpbi9tYWlsbWFuL2xpc3RpbmZvL2tvaGEtZGV2ZWwiIHRh cmdldD0iX2JsYW5rIj5odHRwOi8vbGlzdHMua29oYS1jb21tdW5pdHkub3JnL2NnaS1iaW4vbWFp bG1hbi9saXN0aW5mby9rb2hhLWRldmVsPC9hPjxicj4KPC9mb250PjwvYmxvY2txdW90ZT48L2Rp dj48YnI+Cg== --===============1506198916080513713==-- From robin@catalyst.net.nz Sun Oct 17 23:33:29 2010 From: Robin Sheat To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] CloneSubfields and problems with it Date: Mon, 18 Oct 2010 10:31:57 +1300 Message-ID: <1287351117.20544.6.camel@zarathud> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0735680055935493045==" --===============0735680055935493045== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Owen Leonard schreef op vr 15-10-2010 om 10:09 [-0400]: > Upgrading the version of jQuery Koha uses should be a to-do item for 3.4. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 :) -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5957 6D23 8B16 EFAB FEF8 7175 14D3 6485 A99C EB6D --===============0735680055935493045== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEuNC4xMCAoR05V L0xpbnV4KQoKaUVZRUFSRUNBQVlGQWt5N2EwZ0FDZ2tRRk5Oa2hhbWM2MjFUY2dDZ2lMeUtUYjls YzgxQW9iVDNIWmNGdHlQOApWTGtBb0k0K2trY1lMeE5paWRPZjdOTzFCUmZRU2tTUAo9T2ZYNwot LS0tLUVORCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============0735680055935493045==--