From oleonard@athenscounty.lib.oh.us Wed Jan 22 14:56:07 2003 From: Owen Leonard To: koha-devel@lists.koha-community.org Subject: [Koha-devel] Quoting in templates Date: Wed, 22 Jan 2003 14:57:03 +0000 Message-ID: <200301222259.h0MMxVU07464@alma.athenscounty.lib.oh.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1694725655340954913==" --===============1694725655340954913== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I'm going through the default [English] templates looking for things to clean= =20 up, and I'm finding a variety of ways of handling quoting. For example: &type=3Dintra>() I'm assuming that the href=3D value isn't double-quoted because TMPL_VAR NAME= is.=20 This won't validate, nor will instances where single quotes are used=20 (href=3D''). Is this really necessary? Isn't Perl looking for the = =20 blocks and ignoring the HTML around it? -- Owen --===============1694725655340954913==-- From chris@katipo.co.nz Wed Jan 22 15:05:07 2003 From: Chris Cormack To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] Quoting in templates Date: Wed, 22 Jan 2003 15:06:02 +0000 Message-ID: <20030122230410.GQ5641@katipo.co.nz> In-Reply-To: <200301222259.h0MMxVU07464@alma.athenscounty.lib.oh.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5679350162321747954==" --===============5679350162321747954== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 22, 2003 at 05:54:20PM -0800, Owen Leonard said: > I'm going through the default [English] templates looking for things to cle= an=20 > up, and I'm finding a variety of ways of handling quoting. For example: >=20 > href=3D/cgi-bin/koha/detail.pl?bib=3D NAME=3D"biblionumber">&type=3Dintra>( NAME=3D"author">) >=20 > I'm assuming that the href=3D value isn't double-quoted because TMPL_VAR NA= ME is.=20 > This won't validate, nor will instances where single quotes are used=20 > (href=3D''). Is this really necessary? Isn't Perl looking for the =20 > blocks and ignoring the HTML around it? >=20 Yep you are right. The missing " on the href are a mistake.=20 Fixing those would be good :-) Chris --=20 Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris@katipo.co.nz www.katipo.co.nz --===============5679350162321747954==-- From bobby@bofh.dk Wed Jan 22 23:26:58 2003 From: Bobby Billingsley To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] Quoting in templates Date: Wed, 22 Jan 2003 23:27:03 +0000 Message-ID: <20030123072638.GG20359@beastie.bofh.dk> In-Reply-To: <20030122230410.GQ5641@katipo.co.nz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0517418509175515890==" --===============0517418509175515890== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi folks ... On Thu, 23 Jan 2003, Chris Cormack wrote: > On Wed, Jan 22, 2003 at 05:54:20PM -0800, Owen Leonard said: > > I'm going through the default [English] templates looking for things to c= lean=20 > > up, and I'm finding a variety of ways of handling quoting. For example: > >=20 > > > href=3D/cgi-bin/koha/detail.pl?bib=3D > NAME=3D"biblionumber">&type=3Dintra>( > NAME=3D"author">) > >=20 > > I'm assuming that the href=3D value isn't double-quoted because TMPL_VAR = NAME is.=20 > > This won't validate, nor will instances where single quotes are used=20 > > (href=3D''). Is this really necessary? Isn't Perl looking for the =20 > > blocks and ignoring the HTML around it? > >=20 > Yep you are right. > The missing " on the href are a mistake.=20 > Fixing those would be good :-) That's part of what I'm attempting to do. Owen, maybe we should compare notes in the near future? I've gotten as far as getting Tidy (http://tidy.sourceforge.net/) to be almost co-operative, using a small perl-wrapper (www.bofh.dk/koha/html-beautify.pl) - it's not quite there yet, but almost :-) /bobby -- -- -- -- -- -- -- Bobby Billingsley, General Specialist -- -- -- -- -- -- = -- ___ .--.- \ | | = _=20 `-,_`--'__/ x./_ | Remember to love while you dare | ASCII ribbon campaign (= ) //-_`--/ //\ \ | remember to live while you do | - against HTML email = X=20 \__/ `---' \__/ | -- Piet Hein | & vcards /= \ Lat: 55=C2=B0 40' 52" N Lon: 12=C2=B0 32' 56" E=20 Anyone without a sense of humor is at the mercy of the rest of us :-> --===============0517418509175515890==--