From rangi@users.sourceforge.net Sat Mar 30 18:48:22 2002
From: Chris Cormack <rangi@users.sourceforge.net>
To: koha-devel@lists.koha-community.org
Subject: [Koha-devel] CVS: koha/acqui.simple addbookslccn.pl,1.1,1.2
Date: Sat, 30 Mar 2002 18:49:04 +0000
Message-ID: <E16rVOG-0002VW-00@usw-pr-cvs1.sourceforge.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5721759291935063512=="

--===============5721759291935063512==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Update of /cvsroot/koha/koha/acqui.simple
In directory usw-pr-cvs1:/tmp/cvs-serv9617

Modified Files:
	addbookslccn.pl=20
Log Message:
Fixing branches


Index: addbookslccn.pl
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/koha/koha/acqui.simple/addbookslccn.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** addbookslccn.pl	6 Nov 2001 18:15:00 -0000	1.1
--- addbookslccn.pl	31 Mar 2002 02:48:18 -0000	1.2
***************
*** 12,16 ****
  use C4::Acquisitions;
  use C4::Output;
!=20
 =20
  my $input =3D new CGI;
--- 12,16 ----
  use C4::Acquisitions;
  use C4::Output;
! use C4::Circulation::Circ2;
 =20
  my $input =3D new CGI;
***************
*** 311,315 ****
  <input type=3Dhidden name=3Dbiblioitemnumber value=3D$biblioitemnumber>
  <table>
! <tr><td>BARCODE</td><td><input name=3Dbarcode size=3D10 value=3D$maxbarcode=
> Home Branch: <select name=3Dhomebranch><option value=3D'STWE'>Stewart Eleme=
ntary<option value=3D'MEZ'>Meziadin Elementary</select></td></tr>
  </tr><td colspan=3D2>Replacement Price: <input name=3Dreplacementprice size=
=3D10></td></tr>
  <tr><td>Notes</td><td><textarea name=3Dnotes rows=3D4 cols=3D40
--- 311,322 ----
  <input type=3Dhidden name=3Dbiblioitemnumber value=3D$biblioitemnumber>
  <table>
! <tr><td>BARCODE</td><td><input name=3Dbarcode size=3D10 value=3D$maxbarcode=
> Home Branch: <select name=3Dhomebranch>
! EOF
! my $branches=3Dgetbranches();                                              =
                                 =20
! 	foreach my $key (sort(keys %$branches)) {                                 =
                                =20
! 	    print "<option value=3D\"$key\">$branches->{$key}->{'branchname'}</opt=
ion>";                           =20
! 	}
! print << "EOF";
! 	</select></td></tr>
  </tr><td colspan=3D2>Replacement Price: <input name=3Dreplacementprice size=
=3D10></td></tr>
  <tr><td>Notes</td><td><textarea name=3Dnotes rows=3D4 cols=3D40



--===============5721759291935063512==--


From rog@saas.nsw.edu.au Sat Mar 30 19:35:57 2002
From: Roger Buck <rog@saas.nsw.edu.au>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] CVS: koha/acqui.simple addbookslccn.pl,1.1,1.2
Date: Sat, 30 Mar 2002 19:36:04 +0000
Message-ID: <3CA68416.DAB9B932@saas.nsw.edu.au>
In-Reply-To: <E16rVOG-0002VW-00@usw-pr-cvs1.sourceforge.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4915920808093643284=="

--===============4915920808093643284==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Chris Cormack wrote:
> 
> Update of /cvsroot/koha/koha/acqui.simple

There seem to be some lingering addbooks.pl problems with my
implementation:

When I click on "Enter book with no ISBN" I get this in http error log:

DBD::mysql::st execute failed: You have an error in your SQL syntax near
'' at line 2 at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 280.
DBD::mysql::st fetchrow failed: fetch() without execute() at
/var/www/cgi-bin/koha/acqui.simple/addbooks.pl line
281.                                           

If I change this from:

  biblioitems where bibiloitemnumber=$biblioitemnumber

(around line number 275)

...to a valid hard-coded value, say:

  biblioitems where bibiloitemnumber=8

then I get no error... and an extra table:

 "Existing Items with ISBN NULL" 

appears in the web page (which I assume signifies correct completion - I
have not previously seen that table appear :-)

I was wondering if someone (who understands perl better than I do) could
have a look at the logic there and see if it's suspect?

Thanks,

R.


--===============4915920808093643284==--


From chris@katipo.co.nz Sat Mar 30 19:56:56 2002
From: Chris Cormack <chris@katipo.co.nz>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] CVS: koha/acqui.simple addbookslccn.pl,1.1,1.2
Date: Sat, 30 Mar 2002 19:57:03 +0000
Message-ID: <20020331035648.GE26189@katipo.co.nz>
In-Reply-To: <3CA68416.DAB9B932@saas.nsw.edu.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1688006148472571088=="

--===============1688006148472571088==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Sun, Mar 31, 2002 at 01:35:50PM +1000, Roger Buck said:
> Chris Cormack wrote:
> > 
> > Update of /cvsroot/koha/koha/acqui.simple
> 
> There seem to be some lingering addbooks.pl problems with my
> implementation:
> 
> When I click on "Enter book with no ISBN" I get this in http error log:
> 
> DBD::mysql::st execute failed: You have an error in your SQL syntax near
> '' at line 2 at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 280.
> DBD::mysql::st fetchrow failed: fetch() without execute() at
> /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line
> 281.                                           
> 
> If I change this from:
> 
>   biblioitems where bibiloitemnumber=$biblioitemnumber
> 
> (around line number 275)
> 
> ...to a valid hard-coded value, say:
> 
>   biblioitems where bibiloitemnumber=8
> 
> then I get no error... and an extra table:
> 
>  "Existing Items with ISBN NULL" 
> 
> appears in the web page (which I assume signifies correct completion - I
> have not previously seen that table appear :-)
> 
> I was wondering if someone (who understands perl better than I do) could
> have a look at the logic there and see if it's suspect?
> 
Looks suspect to me.

Im the problem is $biblioitemnumber is empty ... im not sure what is
supposed to happen but that query is never going to work from that link.

Chris

-- 
Chris Cormack                                                     Programmer
025 500 789                                        Katipo Communications Ltd
chris@katipo.co.nz                                          www.katipo.co.nz


--===============1688006148472571088==--


From rog@saas.nsw.edu.au Sat Mar 30 22:06:17 2002
From: Roger Buck <rog@saas.nsw.edu.au>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] CVS: koha/acqui.simple addbookslccn.pl,1.1,1.2
Date: Sat, 30 Mar 2002 22:07:02 +0000
Message-ID: <3CA6A74F.E3E9A73E@saas.nsw.edu.au>
In-Reply-To: <E16rVOG-0002VW-00@usw-pr-cvs1.sourceforge.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7694036596243930609=="

--===============7694036596243930609==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Chris Cormack wrote:
> 
> Update of /cvsroot/koha/koha/acqui.simple

I think addbooks.pl and addbookslccn.pl do not appear to add the
selected branch information to the db from the drop-down options.

Im also pretty sure that the biblioitemnumber routine is broken when
adding a new item using NULL value for ISBN and /or LCCN

I've spent a long time playing around with various options but have come
to a dead end.

R.


--===============7694036596243930609==--


From chris@katipo.co.nz Sat Mar 30 22:45:21 2002
From: Chris Cormack <chris@katipo.co.nz>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] CVS: koha/acqui.simple addbookslccn.pl,1.1,1.2
Date: Sat, 30 Mar 2002 22:46:03 +0000
Message-ID: <20020331064513.GF26189@katipo.co.nz>
In-Reply-To: <3CA6A74F.E3E9A73E@saas.nsw.edu.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7796325853818203461=="

--===============7796325853818203461==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Sun, Mar 31, 2002 at 04:06:07PM +1000, Roger Buck said:
> Chris Cormack wrote:
> > 
> > Update of /cvsroot/koha/koha/acqui.simple
> 
> I think addbooks.pl and addbookslccn.pl do not appear to add the
> selected branch information to the db from the drop-down options.
> 
> Im also pretty sure that the biblioitemnumber routine is broken when
> adding a new item using NULL value for ISBN and /or LCCN
> 
Yep working on them now.

Bear in mind the cvs files are in the cvs not the tarball release just yet
since lots of them arent deemed stable enuff for release.
So its good to go through testing them now, before we do a relase.

Chris
-- 
Chris Cormack                                                     Programmer
025 500 789                                        Katipo Communications Ltd
chris@katipo.co.nz                                          www.katipo.co.nz


--===============7796325853818203461==--