A new request with request id 17108 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is :
Title : Koha-devel Digest, Vol 188, Issue 11
Category :
Description : Send Koha-devel mailing list submissions to
koha-devel@lists.koha-community.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
koha-devel-request@lists.koha-community.org
You can reach the person managing the list at
koha-devel-owner@lists.koha-community.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."
Today's Topics:
1. Re: Bug 17600 (Standardize the EXPORT) is pushed
(Victor Grousset/tuxayo)
2. Re: Helper/Static methods for objects (dcook@prosentient.com.au)
----------------------------------------------------------------------
Message: 1
Date: Sun, 18 Jul 2021 17:56:18 +0200
From: Victor Grousset/tuxayo <victor@tuxayo.net>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Bug 17600 (Standardize the EXPORT) is pushed
Message-ID: <dce8e418-5e29-4b38-79e9-5c26f083f588@tuxayo.net>
Content-Type: text/plain; charset=utf-8; format=flowed
On 21-07-16 09:02, Jonathan Druart wrote:
> I've described in the commit message what it is doing, please read it.
thanks for the guidelines about conflict resolution :)
Cheers,
--
Victor Grousset/tuxayo
------------------------------
Message: 2
Date: Mon, 19 Jul 2021 10:00:27 +1000
From: <dcook@prosentient.com.au>
To: "'Nick Clemens'" <nick@bywatersolutions.com>, "'Koha Devel'"
<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Helper/Static methods for objects
Message-ID: <00fa01d77c31$166be350$4343a9f0$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"
Thanks, Nick.
I added a comment on 20817 about why I think static/class methods are preferable to a Util module.
Cheers,
David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Nick Clemens
Sent: Saturday, 17 July 2021 5:20 AM
To: Koha Devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Helper/Static methods for objects
Hi All,
On two different bugs we have run into similar issues where a method was needed that didn't use the object directly.
On bug 28709 I proposed checking the ref of $self to see if this was called via the object - David Cook proposed adding a second method that is always called directly and calling that from the object method
On bug 20817 Kyle proposed a Koha::Util::Acquisition class and we could utilize that for other object as well, e.g. Koha::Util::Biblio, Koha::Util::Item
I put this on the agenda for the next dev meeting, I am sending it out here to get opinions and encourage attendance at that meeting to vote on a path forward.
-Nick
--
Nick Clemens
ByWater Solutions
bywatersolutions.com <http://bywatersolutions.com>
Phone: (888) 900-8944
Pronouns: (he/him/his)
Timezone: Eastern
Follow us:
<https://www.facebook.com/ByWaterSolutions/> <https://www.instagram.com/bywatersolutions/> <https://www.youtube.com/user/bywatersolutions> <https://twitter.com/ByWaterSolution>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210719/48064a71/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ~WRD0001.jpg
Type: image/jpeg
Size: 823 bytes
Desc: not available
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210719/48064a71/attachment-0002.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 435 bytes
Desc: not available
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210719/48064a71/attachment-0003.jpg>
------------------------------
Subject: Digest Footer
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
------------------------------
End of Koha-devel Digest, Vol 188, Issue 11
*******************************************
NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.