+1 for going into this direction

Probably, there is too much logic in the templates too? And related to translation as well? Take e.g. some statuses; if the template decides in nested if-then-else's how to display a status (in various languages), we'd better move the logic into a module and send the translated status to the template or have something unified and more intelligent deal with translating that message.

 

Marcel

 

Van: koha-devel-bounces@lists.koha-community.org [koha-devel-bounces@lists.koha-community.org] namens Kyle Hall [kyle.m.hall@gmail.com]
Verzonden: woensdag 10 april 2013 13:23
To: MJ Ray
Cc: Koha Devel
Onderwerp: Re: [Koha-devel] Koha.next: Consolidate OPAC themes?

This these have been my thoughts exactly as well. I think it would be best if the templates were pure unstyled html that are well classed and all elements should have unique id's as well. Each theme should just be css and presentation javascript.

In addition, I think we should completely remove the necessity of passing in system preferences to the templates from perl scripts, and switch to using a TT plugin for accessing system preferences.

Ian also has a very good point about standard naming conventions. It would be great to get all the variations on naming wrangled into one standard version.

Another thought I've had that would simplify Koha and keep it more DRY would be to implement ajax based widgets. For instance, both circulation.pl and moremember.pl display a list of holds in a tab, but each is a separate implementation. If we just made this code a widget ( or even just a .inc file with all the required html and javascript ) we could reuse it on any page we wanted to.

Kyle

http://www.kylehall.info
ByWater Solutions ( http://bywatersolutions.com )
Meadville Public Library ( http://www.meadvillelibrary.org )
Crawford County Federated Library System ( http://www.ccfls.org )
Mill Run Technology Solutions ( http://millruntech.com )


On Mon, Apr 8, 2013 at 12:17 PM, MJ Ray <mjr@phonecoop.coop> wrote:
Galen Charlton <gmc@esilibrary.com>
> Consequently, I think the next version of Koha should unify the
> templates of the prog and CCSR themes.  If we decide to continue
> offering both appearances as stock options, the visual and layout
> differences between the two should be managed strictly through the use
> of CSS.  [...]
> Thoughts?

I think this is right.  Having a good base theme, especially if there
are basically examples of the right way to adapt it with CSS,
would be a good way for Koha to learn from Evergreen's experience.

Thanks,
--
MJ Ray (slef), member of www.software.coop, a for-more-than-profit co-op.
http://koha-community.org supporter, web and library systems developer.
In My Opinion Only: see http://mjr.towers.org.uk/email.html
Available for hire (including development) at http://www.software.coop/
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/