+1 for the cases where all patches are signed off.
I think there might be a lot of our documentation describing adding the [SIGNED OFF] label - could we additionally teach git bz to ignore those and obsolete correctly?
I think that there's an alias in the gitconfig on kohadevbox (among other places) that adds the [SIGNED_OFF] label. This is from my gitconfig on a different box, but kohadevbox has something similar IIRC:
[alias]so = "!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter \"echo -n \\\"[SIGNED-OFF] \\\" && cat && echo \\\"\nSigned-off-by: Barton Chittenden <barton@bywatersolutions.com>\\\"\" HEAD~$c^..; }; f"
On Fri, Aug 25, 2017 at 6:17 AM, Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
+1
On vie., 25 de ago. de 2017 4:07 AM Marc Véron <veron@veron.ch> wrote:
+1
______________________________
Am 25.08.2017 um 08:52 schrieb David Cook:
+1
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St
Ultimo, NSW 2007
Australia
Office: 02 9212 0899
Direct: 02 8005 0595
From: koha-devel-bounces@lists.koha-
community.org [mailto:koha-devel-bounces@lists.koha-community.org ] On Behalf Of Marcel de Rooy
Sent: Friday, 25 August 2017 4:29 PM
To: Koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] [SIGNED_OFF] labels
Hi all,
I would favor stopping the use of adding [SIGNED_OFF] labels to patches when it is not strictly needed (which normally is the case).
Only when (exceptionally) a few patches are signed and a few are not on one report, I could see its use.
At this moment they need to be obsoleted manually with git bz.
Can we stop adding them ?
Marcel
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha- community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/ website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.koha-devel org/
_________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/ koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/ --
Tomás Cohen Arazi
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/ koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/