A new request with request id 17731 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is :
Title : Koha-devel Digest, Vol 187, Issue 4
Category :
Description : Send Koha-devel mailing list submissions to
koha-devel@lists.koha-community.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
koha-devel-request@lists.koha-community.org
You can reach the person managing the list at
koha-devel-owner@lists.koha-community.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."
Today's Topics:
1. Re: Follow-up patches and why not to use them (Joonas Kylmälä)
2. Increasing Debian Package Compatibility Levels
(dcook@prosentient.com.au)
3. Re: Increasing Debian Package Compatibility Levels
(dcook@prosentient.com.au)
----------------------------------------------------------------------
Message: 1
Date: Mon, 7 Jun 2021 07:26:19 +0300
From: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
To: Julian Maurice <julian.maurice@biblibre.com>,
koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Follow-up patches and why not to use them
Message-ID: <7965dba3-c0b1-1cba-457e-9508d0f39ac9@helsinki.fi>
Content-Type: text/plain; charset=utf-8
Hi,
On 04/06/2021 15:42, Julian Maurice wrote:
> Do you know you can revert multiple commits at once (ie. only one
> "revert commit" that revert a series of commits) ? Would that make it
> easier for cases like that ?
> And when trying to find all commits of a particular bug, git log --grep
> is your friend.
Yup, however you still need to verify all the changes make sense on top
of the new code base so that doesn't help.
> By enforcing a "1 commit" rule we would lose the (often) logical
> separation of patches that makes review easier.
I didn't suggest 1 commit hard rule per bug. I'm after commits
containing one logical change also.
Joonas
------------------------------
Message: 2
Date: Mon, 7 Jun 2021 16:22:46 +1000
From: <dcook@prosentient.com.au>
To: <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Increasing Debian Package Compatibility Levels
Message-ID: <048b01d75b65$882c2d20$98848760$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"
Hi all,
I've been noticing lately some of the following warnings when I'm building
Koha Debian packages:
dh_install: Compatibility levels before 9 are deprecated (level 7 in use)
dh_installdocs
dh_installdocs: Compatibility levels before 9 are deprecated (level 7 in
use)
dh_installchangelogs
dh_installchangelogs: Compatibility levels before 9 are deprecated (level 7
in use)
dh_compress
dh_fixperms
dh_installdeb
dh_installdeb: Compatibility levels before 9 are deprecated (level 7 in use)
dh_gencontrol
It seems to me that we should look at upping our compatibility level.
We can see the changes between v7, 8, and 9 at
https://manpages.debian.org/testing/debhelper/debhelper.7.en.html.
At a glance, I think that we'd probably be OK moving up to 9 from 7. But
we'd want to do some testing.
David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210607/1f452d15/attachment-0001.htm>
------------------------------
Message: 3
Date: Mon, 7 Jun 2021 16:26:33 +1000
From: <dcook@prosentient.com.au>
To: <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Increasing Debian Package Compatibility
Levels
Message-ID: <049001d75b66$0fa8c6f0$2efa54d0$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"
Note that those warnings are from Debian Stretch. Since it's oldstable, it's
probably still OK to be building on it.
What OS do the Koha CI servers use?
David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
From: dcook@prosentient.com.au <dcook@prosentient.com.au>
Sent: Monday, 7 June 2021 4:23 PM
To: 'koha-devel@lists.koha-community.org'
<koha-devel@lists.koha-community.org>
Cc: 'Mason James' <mtj@kohaaloha.com>
Subject: Increasing Debian Package Compatibility Levels
Hi all,
I've been noticing lately some of the following warnings when I'm building
Koha Debian packages:
dh_install: Compatibility levels before 9 are deprecated (level 7 in use)
dh_installdocs
dh_installdocs: Compatibility levels before 9 are deprecated (level 7 in
use)
dh_installchangelogs
dh_installchangelogs: Compatibility levels before 9 are deprecated (level 7
in use)
dh_compress
dh_fixperms
dh_installdeb
dh_installdeb: Compatibility levels before 9 are deprecated (level 7 in use)
dh_gencontrol
It seems to me that we should look at upping our compatibility level.
We can see the changes between v7, 8, and 9 at
https://manpages.debian.org/testing/debhelper/debhelper.7.en.html.
At a glance, I think that we'd probably be OK moving up to 9 from 7. But
we'd want to do some testing.
David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210607/9c87cae6/attachment-0001.htm>
------------------------------
Subject: Digest Footer
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
------------------------------
End of Koha-devel Digest, Vol 187, Issue 4
******************************************
NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.