Nope, that file won't exist in stable, and every patch that references it will fail to apply.
I repeat I am not pushing anything to do with 7167 to stable . Including a file that we ignore.

Chris

Jared Camins-Esakov <jcamins@cpbibliography.com> wrote:
Chris,

> Also, I have a correction to Chris's response: we will not need two separate sets of DB changes because I will be copying every non-linear update into updatedatabase.pl. That was the reason for the CheckVersion() routine.
>

Hi

While that is a good idea, and will mean the packages aren't totally busted on master. A commit that has both the old safe updatedatabase and the new system is no use for cherry-picking to stable.  It won't apply. So we will need a commit with just the bug fix, then another 2 commits, one doing old db update, one doing new, and I will just cherry pick the old one.

IE if something is needed for 3.10.x or 3.8.x it can't combine the db update part of the patch with the rest, for it to be able to apply.


Sure it can. The DB update for 3.12+ will be a new file (which will be ignored by every version up until 3.12), every time. Any patches that make changes to the update system itself will have to be on different bugs, of course, but I was going to require that anyway.

Regards,
Jared
 
--
Jared Camins-Esakov
Bibliographer, C & P Bibliography Services, LLC
(phone) +1 (917) 727-3445
(e-mail) jcamins@cpbibliography.com
(web) http://www.cpbibliography.com/



Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/