Send Koha-devel mailing list submissions to
    koha-devel@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
    https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
    koha-devel-request@lists.koha-community.org

You can reach the person managing the list at
    koha-devel-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."


Today's Topics:

1. QA : List::Util any ? (Fridolin SOMERS)
2. Re: QA : List::Util any ? (Tomas Cohen Arazi)
3. stylus on bugzilla (Fridolin SOMERS)


----------------------------------------------------------------------

Message: 1
Date: Fri, 19 Nov 2021 11:20:22 -1000
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] QA : List::Util any ?
Message-ID: <3afe05a3-e663-9031-b42b-16b5e1240337@biblibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed

Hi,

This message is mainly for QA team but feel free to comment :)

In https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127606
... unless grep( /^$i$/, @branchcodes );

In my opinion seeing two veru different $ is disturbing.

Should we tell to use List::Util any ?
It is already used in many places.

Best regards,

--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France


------------------------------

Message: 2
Date: Fri, 19 Nov 2021 20:41:29 -0300
From: Tomas Cohen Arazi <tomascohen@gmail.com>
To: Fridolin SOMERS <fridolin.somers@biblibre.com>
Cc: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] QA : List::Util any ?
Message-ID:
    <CABZfb=UJYDbTaZa+umPVA2ezKvvyQKz=8TzJb9gW-Ng8NdxypA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

If you are not using the output of grep (it returns all matching elements)
you should be using 'any', which short-circuits on the first match. And
List::Util is a core library nowadays.

That's why I use it in those scenarios and suggest it on QA as well.

Best regards

El vie., 19 nov. 2021 18:20, Fridolin SOMERS <fridolin.somers@biblibre.com>
escribió:

> Hi,
>
> This message is mainly for QA team but feel free to comment :)
>
> In https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127606
> ... unless grep( /^$i$/, @branchcodes );
>
> In my opinion seeing two veru different $ is disturbing.
>
> Should we tell to use List::Util any ?
> It is already used in many places.
>
> Best regards,
>
> --
> Fridolin SOMERS <fridolin.somers@biblibre.com>
> Software and system maintainer 🦄
> BibLibre, France
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20211119/279761c7/attachment-0001.htm>

------------------------------

Message: 3
Date: Fri, 19 Nov 2021 16:31:50 -1000
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] stylus on bugzilla
Message-ID: <01271d72-871b-c312-296d-deb216c9266e@biblibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed

Hi,

I'd like to share a trick very useful for our bugzilla.

When backporting, bug dependencies are very important.
You see that when there is no dependency there is an input field and
there are hyperlinks for dependencies.

So I had the idea of adding CSS via Stylus FF plugin :
https://addons.mozilla.org/en/firefox/addon/styl-us/

Here is the rule :
====
#field_label_dependson + td > a.bz_bug_link::after {
content: '⚠️';
}
====

It adds a warning emoji next to link.
When there is no dependency there is no warning.

I have also some other cosmetic rules :
====
body, td, th, input, select, dt, #titles {
font-size: 16px;
}
.bz_comment_text {
width: 100em;
}
.bz_time_tracking_table {
display: none;
}
====

Best regards,

--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France


------------------------------

Subject: Digest Footer

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


------------------------------

End of Koha-devel Digest, Vol 192, Issue 15
*******************************************