Send Koha-devel mailing list submissions to
koha-devel@lists.koha-community.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
koha-devel-request@lists.koha-community.org
You can reach the person managing the list at
koha-devel-owner@lists.koha-community.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."
Today's Topics:
1. Re: Updating SCSS lint process to use stylelint (BFL Catalog)
2. Re: Updating SCSS lint process to use stylelint (Renvoize, Martin)
----------------------------------------------------------------------
Message: 1
Date: Tue, 19 Jul 2022 11:35:36 -0400
From: BFL Catalog <catalog@bfli.org>
To: Paul Derscheid <paul.derscheid@lmscloud.de>
Cc: Owen Leonard <oleonard@myacpl.org>, Koha Devel
<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Updating SCSS lint process to use stylelint
Message-ID:
<CAMigdofCd+krU-hpehGem=XrqFuxrDqYVxykvNyQVRKS7Z6xDQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
What exactly is stylelint? Is this what you get after washing clothes too
many times? You know the laundry lint builds up so much it cramps your
style!
Wendy Sharkey
Head of Circulation/ Cataloging and IT
Bennington Free Library
101 Silver Street
Bennington, VT 05201
(802) 442-9051
On Tue, Jul 19, 2022 at 4:29 AM Paul Derscheid <paul.derscheid@lmscloud.de>
wrote:
> Hi Owen,
>
> I recently played around with the SCSS to create a more minimalist version
> of the bootstrap OPAC for LMSCloud.
> I used the predefined rules and I think they’re reasonable choices
> (Although I didn’t cross every rule for sure).
>
> Looking forward to stylint in Koha which I already use for some projects
> where I use stylus instead of SCSS. It’s a great tool.
>
> Kind regards
>
> Paul
>
> --
> LMSCloud GmbH
> Paul Derscheid - Software Engineer
> Konrad-Zuse-Platz 8 - D-81829 München
> m +49 174 2436308
> e paul.derscheid@lmscloud.de
> w www.lmscloud.de
>
> > On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
> >
> > Hi all,
> >
> > Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I
> > added a linting configuration, .scss-lint.yml. I've always configured
> > my editor to automatically lint SCSS using this configuration. I don't
> > know if anyone else does this too.
> >
> > In VS Code I was using scss-lint for this, but it's now deprecated.
> > They suggest stylelint instead: https://stylelint.io. I'd like to
> > propose replacing .scss-lint.yml with .stylelintrc.json, transferring
> > most of the same rules.
> >
> > It could be left up to the individual to install the dependencies, or
> > I could update package.json. One nice thing about stylelint is that it
> > has a "--fix" feature for some simple rules. This could be build into
> > our gulp tasks.
> >
> > Has anyone else been linting SCSS? If so, does anyone have opinions
> > about how our current rule set is working?
> >
> > -- Owen
> >
> > --
> > Web Developer
> > Athens County Public Libraries
> > (740) 737-6006
> > https://www.myacpl.org
> > _______________________________________________
> > Koha-devel mailing list
> > Koha-devel@lists.koha-community.org
> > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> > website : https://www.koha-community.org/
> > git : https://git.koha-community.org/
> > bugs : https://bugs.koha-community.org/
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220719/5b4f9de4/attachment-0001.htm>
------------------------------
Message: 2
Date: Tue, 19 Jul 2022 22:20:38 +0100
From: "Renvoize, Martin" <martin.renvoize@ptfs-europe.com>
To: Koha Devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Updating SCSS lint process to use stylelint
Message-ID:
<CAB7SL8Bf3JecoiDQRLEyyKcXOzqjEVC_V-7f3YW3huk9K0KtHg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
I'm in a similar camp to David, though I have touched it a few times here
and there.. I wasn't aware of a linter, but would take your lead Owen, I
like linters and tidies in general.. having consistent code is clearer code
in my book.
On Tue, 19 Jul 2022, 4:36 pm BFL Catalog, <catalog@bfli.org> wrote:
> What exactly is stylelint? Is this what you get after washing clothes too
> many times? You know the laundry lint builds up so much it cramps your
> style!
>
> Wendy Sharkey
> Head of Circulation/ Cataloging and IT
> Bennington Free Library
> 101 Silver Street
> Bennington, VT 05201
> (802) 442-9051
>
>
> On Tue, Jul 19, 2022 at 4:29 AM Paul Derscheid <paul.derscheid@lmscloud.de>
> wrote:
>
>> Hi Owen,
>>
>> I recently played around with the SCSS to create a more minimalist
>> version of the bootstrap OPAC for LMSCloud.
>> I used the predefined rules and I think they’re reasonable choices
>> (Although I didn’t cross every rule for sure).
>>
>> Looking forward to stylint in Koha which I already use for some projects
>> where I use stylus instead of SCSS. It’s a great tool.
>>
>> Kind regards
>>
>> Paul
>>
>> --
>> LMSCloud GmbH
>> Paul Derscheid - Software Engineer
>> Konrad-Zuse-Platz 8 - D-81829 München
>> m +49 174 2436308
>> e paul.derscheid@lmscloud.de
>> w www.lmscloud.de
>>
>> > On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
>> >
>> > Hi all,
>> >
>> > Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I
>> > added a linting configuration, .scss-lint.yml. I've always configured
>> > my editor to automatically lint SCSS using this configuration. I don't
>> > know if anyone else does this too.
>> >
>> > In VS Code I was using scss-lint for this, but it's now deprecated.
>> > They suggest stylelint instead: https://stylelint.io. I'd like to
>> > propose replacing .scss-lint.yml with .stylelintrc.json, transferring
>> > most of the same rules.
>> >
>> > It could be left up to the individual to install the dependencies, or
>> > I could update package.json. One nice thing about stylelint is that it
>> > has a "--fix" feature for some simple rules. This could be build into
>> > our gulp tasks.
>> >
>> > Has anyone else been linting SCSS? If so, does anyone have opinions
>> > about how our current rule set is working?
>> >
>> > -- Owen
>> >
>> > --
>> > Web Developer
>> > Athens County Public Libraries
>> > (740) 737-6006
>> > https://www.myacpl.org
>> > _______________________________________________
>> > Koha-devel mailing list
>> > Koha-devel@lists.koha-community.org
>> > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> > website : https://www.koha-community.org/
>> > git : https://git.koha-community.org/
>> > bugs : https://bugs.koha-community.org/
>>
>> _______________________________________________
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : https://www.koha-community.org/
>> git : https://git.koha-community.org/
>> bugs : https://bugs.koha-community.org/
>>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220719/70d3728d/attachment-0001.htm>
------------------------------
Subject: Digest Footer
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
------------------------------
End of Koha-devel Digest, Vol 200, Issue 20
*******************************************