Ian,
My difficulty with this patch is that it sets precedent for implementing both commandline and staff client interfaces for a single script. Up until now, that's not be the case (as far as my research has shown; counter-examples welcome). I just think we need, for consistency sake, to either make this the standard practice, or require separate cronjobs.
So, I don't have any issue with the feature, but the potential shift in coding practices that the patch represents. Is the rest of the Koha developer community comfortable with having dual-purpose scripts like this? Are there are any best practices that can be cited for or against such practice?