Send Koha-devel mailing list submissions to
    koha-devel@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
    https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
    koha-devel-request@lists.koha-community.org

You can reach the person managing the list at
    koha-devel-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."


Today's Topics:

1. Koha::Item->is_notforloan (see Bug 30636)
(dcook@prosentient.com.au)


----------------------------------------------------------------------

Message: 1
Date: Thu, 28 Apr 2022 14:48:07 +1000
From: <dcook@prosentient.com.au>
To: "'Koha-devel'" <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Koha::Item->is_notforloan (see Bug 30636)
Message-ID: <076901d85abb$2ab6d900$80248b00$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"

Hi all,



While working on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636, I noticed
that our usage of Koha::Item->notforloan is problematic. Sometimes we use it
as a Boolean and sometimes we use it for descriptive information.



When we use it as a Boolean, we really should be taking into account the
"Not for loan" status by "Item Type" as well.



I'm noticing there are places in Koha which show an item as "Available" if
the item is "Not for loan" by item type and that's a problem. (It looks like
the new recalls feature from Bug 19532 has this same problem.)



Anyway, I'm thinking a new method like Koha::Item->is_notforloan might be a
good idea for covering the Boolean condition rather than trying to remember
to implement Koha::Item->notforloan and Koha::Item->notforloan_per_itemtype
(this method doesn't even exist) for all relevant use cases.



One way or another, I'll be fixing the ILS-DI API locally, but I'd like to
get people's input first, so that it's easier for me to upstream and
benefit everyone else too.



David Cook

Senior Software Engineer

Prosentient Systems

Suite 7.03

6a Glen St

Milsons Point NSW 2061

Australia



Office: 02 9212 0899

Online: 02 8005 0595



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220428/e1ba7542/attachment-0001.htm>

------------------------------

Subject: Digest Footer

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


------------------------------

End of Koha-devel Digest, Vol 197, Issue 15
*******************************************