A new request with request id 19218 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is :
Title : Koha-devel Digest, Vol 184, Issue 24
Category :
Description : Send Koha-devel mailing list submissions to
koha-devel@lists.koha-community.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
koha-devel-request@lists.koha-community.org
You can reach the person managing the list at
koha-devel-owner@lists.koha-community.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."
Today's Topics:
1. Second look needed on a few (2!) lines related to plugins
(Victor Grousset/tuxayo)
2. Re: Second look needed on a few (2!) lines related to plugins
(Mason James)
3. Re: Second look needed on a few (2!) lines related to plugins
(Fridolin SOMERS)
4. Bug 28022 - MARC subfield 9 not honoring visibility
(Thomas Klausner)
5. Re: Bug 28022 - MARC subfield 9 not honoring visibility
(Nicolas Legrand)
6. Re: Switching from SysV to Systemd for koha-common service
(Fridolin SOMERS)
----------------------------------------------------------------------
Message: 1
Date: Mon, 29 Mar 2021 18:25:15 +0200
From: Victor Grousset/tuxayo <victor@tuxayo.net>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Second look needed on a few (2!) lines related
to plugins
Message-ID: <565e5e29-2ebc-2490-aaec-c5aa1e4def97@tuxayo.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
[% PROCESS plugin_pars %]
[...]
$plugin? ( public => 1 ): ()
Does this look familiar to anyone?
Cheers,
--
Victor Grousset/tuxayo
------------------------------
Message: 2
Date: Tue, 30 Mar 2021 12:31:08 +1300
From: Mason James <mtj@kohaaloha.com>
To: Victor Grousset/tuxayo <victor@tuxayo.net>, koha-devel
<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Second look needed on a few (2!) lines
related to plugins
Message-ID: <0b274655-7c51-8e25-48ab-619cf77fcc83@kohaaloha.com>
Content-Type: text/plain; charset=utf-8; format=flowed
hiya, here's some info...
https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm
On 30/03/21 5:25 am, Victor Grousset/tuxayo wrote:
> Hi :)
>
> It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
>
> There are two lines in the patch that are out of my knowledge to QA:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
>
> [% PROCESS plugin_pars %]
> [...]
> $plugin? ( public => 1 ): ()
>
> Does this look familiar to anyone?
>
> Cheers,
>
------------------------------
Message: 3
Date: Tue, 30 Mar 2021 09:08:21 +0200
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Second look needed on a few (2!) lines
related to plugins
Message-ID: <ba0659bf-bf3b-56a2-6f2c-ae319460ee4c@biblibre.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
In my opinion this syntax looks strange.
I'd prefer :
my $filter = { uploadcategorycode => $browsecategory };
$filter{public} = 1 if $plugin;
$uploads = Koha::UploadedFiles->search($filter)->unblessed;
Super cool enhancement BTW ;)
Best regards,
Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
> Hi :)
>
> It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
>
> There are two lines in the patch that are out of my knowledge to QA:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
>
> [% PROCESS plugin_pars %]
> [...]
> $plugin? ( public => 1 ): ()
>
> Does this look familiar to anyone?
>
> Cheers,
>
--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France
------------------------------
Message: 4
Date: Tue, 30 Mar 2021 09:28:13 +0200
From: Thomas Klausner <domm@plix.at>
To: koha-devel@lists.koha-community.org
Subject: [Koha-devel] Bug 28022 - MARC subfield 9 not honoring
visibility
Message-ID: <YGLTDU2S01n5x5fn@plix.at>
Content-Type: text/plain; charset=us-ascii
Hi!
Can anybody here maybe review / comment on my bug report & patch 28022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022
Here's the patch:
https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f
Greetings,
domm
--
#!/usr/bin/perl http://domm.plix.at
for(ref bless{},just'another'perl'hacker){s-:+-$"-g&&print$_.$/}
------------------------------
Message: 5
Date: Tue, 30 Mar 2021 09:34:03 +0200
From: Nicolas Legrand <nicolas.legrand@bulac.fr>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Bug 28022 - MARC subfield 9 not honoring
visibility
Message-ID:
<CAODBKZfZxdO+QTONGM=JJr+a3yu0vqDVZ4sFKynUBuFNNZzvoA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hiya Thomas,
Le mar. 30 mars 2021 à 09:28, Thomas Klausner <domm@plix.at> a écrit :
> Hi!
>
> Can anybody here maybe review / comment on my bug report & patch 28022
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022
>
>
> Here's the patch:
>
> https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f
Here is the doc explaining how to submit a patch for Koha :
https://wiki.koha-community.org/wiki/Git_bz_configuration
You have to install a utility (git bz) that uploads your patches to
Bugzilla. Then other people will be able to test, comment or sign your
patch, also using git bz.
Regards,
--
Nicolas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210330/503d6455/attachment-0001.htm>
------------------------------
Message: 6
Date: Tue, 30 Mar 2021 10:08:10 +0200
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Switching from SysV to Systemd for
koha-common service
Message-ID: <5788f577-0831-90cf-4696-444268910a3e@biblibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Hi,
Very good idea :D
We at Biblibre have build a systemd unit for Starman and Zebra, it is
quite simple. But we dont use several Koha.
In ordre to implement for several Koha, I think we should use %i vars in
systemd unit.
Like it is in openvpn :
https://github.com/OpenVPN/openvpn/blob/master/distro/systemd/openvpn-client%40.service.in
It allows to call any unit (for example demo Koha) :
systemctl start koha-common@demo.
About restart :
I see you can define a different kill signal than stop :
https://www.freedesktop.org/software/systemd/man/systemd.kill.html#RestartKillSignal=
But you may use "reload" action instead :
https://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecReload=
We use reload for starman it is more soft (it acts like apache gracefull
restart).
I attach some files here :
https://git.biblibre.com/biblibre/koha-nginx/src/branch/master/etc/systemd/system
Feel free to ask for help.
Best regards,
Le 25/03/2021 à 04:42, dcook@prosentient.com.au a écrit :
> Hi all,
>
> I was just installing koha-common, as you do, and I noticed the
> following warning:
>
> Failed to enable unit: Unit
> /run/systemd/generator.late/koha-common.service is transient or generated.
>
> This is the product of the following command: “update-rc.d koha-common
> enable”
>
> I think I was able to work around it by running the following:
> “/lib/systemd/systemd-sysv-install enable koha-common”
>
> However, I’m thinking it is probably time to switch koha-common from
> SysV to Systemd. We’ll lose a bit of functionality for the “status”
> option, but otherwise it shouldn’t be too bad. I think we’ll lose the
> “restart” as well as I think the systemd restart is a “stop” and “start”.
>
> David Cook
>
> Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France
------------------------------
Subject: Digest Footer
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
------------------------------
End of Koha-devel Digest, Vol 184, Issue 24
*******************************************
NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.