Send Koha-devel mailing list submissions to
	koha-devel@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
	koha-devel-request@lists.koha-community.org

You can reach the person managing the list at
	koha-devel-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."

Today's Topics:

   1. Plack graceful restart / reload (Bug 21366)
      (dcook@prosentient.com.au)
   2. Bug 30684: Requesting community feedback on change to restart
      behaviour of koha-* scripts (Alex Buckley)
   3. Re: Bug 30684: Requesting community feedback on change to
      restart behaviour of koha-* scripts (dcook@prosentient.com.au)

----------------------------------------------------------------------

Message: 1
Date: Fri, 20 May 2022 11:35:47 +1000
From: <dcook@prosentient.com.au>
To: "'Koha-devel'" <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Plack graceful restart / reload (Bug 21366)
Message-ID: <08bd01d86be9$fb41b8d0$f1c52a70$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"

Hi all,

For years, we've been talking about providing a graceful restart for
Starman.  

Today, I needed it for a production instance to enable plugins without
disrupting anyone's Koha usage, so I ran: kill -SIGHUP $(cat
/var/run/koha/<instance name>/plack.pid)

It worked so well.

I'd be happy to provide a patch, but I imagine there might be some debate
about the precise implementation. So if folk could comment on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 that would
be great.

David Cook

Senior Software Engineer

Prosentient Systems

Suite 7.03

6a Glen St

Milsons Point NSW 2061

Australia

Office: 02 9212 0899

Online: 02 8005 0595

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220520/be83ea2a/attachment-0001.htm>

------------------------------

Message: 2
Date: Fri, 20 May 2022 16:11:18 +1200
From: Alex Buckley <alexbuckley@catalyst.net.nz>
To: koha-devel@lists.koha-community.org
Subject: [Koha-devel] Bug 30684: Requesting community feedback on
	change to restart behaviour of koha-* scripts
Message-ID: <6ea69452-e75a-0841-b52f-2b31e3b87fc4@catalyst.net.nz>
Content-Type: text/plain; charset="utf-8"

Kia ora Koha community,

I'd love to hear your thoughts please on adding the following behaviour
across all koha-* scripts when passing the --restart parameter:

1. If the service is not running

2. You run sudo koha-<service> --restart <instancename> , e.g. sudo
koha-plack --restart kohadev

3. Koha stops the service, then starts it

*Context*

Bug 30684 was initially written to resolve the below error that is
thrown when you try restarting plack, if it's not already running:

/[FAIL] Error: Plack not running for <instancename>: failed!/

However, as Marcel noted the error is thrown by design: If you didn't
start it, you cannot restart it.

So it would be better to stop and then start the service. Also to ensure
this change was consistent, it should be implemented in all koha-*
scripts, not just koha-plack.

Is everyone happy for this change to be implemented in all koha-* scripts?

Thanks,

Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220520/80daba67/attachment-0001.htm>

------------------------------

Message: 3
Date: Fri, 20 May 2022 14:46:50 +1000
From: <dcook@prosentient.com.au>
To: "'Alex Buckley'" <alexbuckley@catalyst.net.nz>,
	<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Bug 30684: Requesting community feedback on
	change to restart behaviour of koha-* scripts
Message-ID: <08cd01d86c04$a5d29520$f177bf60$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"

I’m happy for this change. I think it would make the koha-* scripts more in line with the standard methodology of restarting Linux services.

Another reason to do this… *I think* if you try to do a “koha-plack --restart" against 10 instances where the 5th instance isn’t running, the first 4 will restart but then the script will error out, and it won’t restart the last 5 instances. So this change would make batch updates much safer.

(As an aside, Bug 21366 is about adding a --reload (ie graceful restart) to koha-plack, so I’m also holding off on doing that patch until Bug 30684 is resolved…)

David Cook

Senior Software Engineer

Prosentient Systems

Suite 7.03

6a Glen St

Milsons Point NSW 2061

Australia

Office: 02 9212 0899

Online: 02 8005 0595

From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Alex Buckley
Sent: Friday, 20 May 2022 2:11 PM
To: koha-devel@lists.koha-community.org
Subject: [Koha-devel] Bug 30684: Requesting community feedback on change to restart behaviour of koha-* scripts

Kia ora Koha community,

I'd love to hear your thoughts please on adding the following behaviour across all koha-* scripts when passing the --restart parameter:

1. If the service is not running

2. You run sudo koha-<service> --restart <instancename> , e.g. sudo koha-plack --restart kohadev

3. Koha stops the service, then starts it

Context

Bug 30684 was initially written to resolve the below error that is thrown when you try restarting plack, if it's not already running:

[FAIL] Error: Plack not running for <instancename>: failed!

However, as Marcel noted the error is thrown by design: If you didn't start it, you cannot restart it. 

So it would be better to stop and then start the service. Also to ensure this change was consistent, it should be implemented in all koha-* scripts, not just koha-plack.

Is everyone happy for this change to be implemented in all koha-* scripts?

Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220520/1a82a87d/attachment-0001.htm>

------------------------------

Subject: Digest Footer

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/

------------------------------

End of Koha-devel Digest, Vol 198, Issue 14
*******************************************