A new request with request id 8011 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is :

Title : Koha-devel Digest, Vol 200, Issue 19
Category :
Description :
Send Koha-devel mailing list submissions to
    koha-devel@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
    https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
    koha-devel-request@lists.koha-community.org

You can reach the person managing the list at
    koha-devel-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."


Today's Topics:

1. Updating SCSS lint process to use stylelint (Owen Leonard)
2. Re: Updating SCSS lint process to use stylelint
(dcook@prosentient.com.au)
3. Re: Updating SCSS lint process to use stylelint (Paul Derscheid)


----------------------------------------------------------------------

Message: 1
Date: Mon, 18 Jul 2022 10:32:46 -0400
From: Owen Leonard <oleonard@myacpl.org>
To: Koha Devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Updating SCSS lint process to use stylelint
Message-ID:
    <CAO4qe2PJWOq7cL=_eyLiQ37D41Ob2ffg3GmbXnFg02DeFESdZA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"

Hi all,

Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I
added a linting configuration, .scss-lint.yml. I've always configured
my editor to automatically lint SCSS using this configuration. I don't
know if anyone else does this too.

In VS Code I was using scss-lint for this, but it's now deprecated.
They suggest stylelint instead: https://stylelint.io. I'd like to
propose replacing .scss-lint.yml with .stylelintrc.json, transferring
most of the same rules.

It could be left up to the individual to install the dependencies, or
I could update package.json. One nice thing about stylelint is that it
has a "--fix" feature for some simple rules. This could be build into
our gulp tasks.

Has anyone else been linting SCSS? If so, does anyone have opinions
about how our current rule set is working?

-- Owen

--
Web Developer
Athens County Public Libraries
(740) 737-6006
https://www.myacpl.org


------------------------------

Message: 2
Date: Tue, 19 Jul 2022 09:56:05 +1000
From: <dcook@prosentient.com.au>
To: "'Owen Leonard'" <oleonard@myacpl.org>, "'Koha Devel'"
    <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Updating SCSS lint process to use stylelint
Message-ID: <017f01d89b01$fc3390a0$f49ab1e0$@prosentient.com.au>
Content-Type: text/plain;    charset="utf-8"

For what it's worth, I don't touch the SCSS. I try to avoid it wherever possible and leave it up to people who know it better than me.

Curious to hear about others...

David Cook
Senior Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia

Office: 02 9212 0899
Online: 02 8005 0595

-----Original Message-----
From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Owen Leonard
Sent: Tuesday, 19 July 2022 12:33 AM
To: Koha Devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Updating SCSS lint process to use stylelint

Hi all,

Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too.

In VS Code I was using scss-lint for this, but it's now deprecated.
They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules.

It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks.

Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working?

-- Owen

--
Web Developer
Athens County Public Libraries
(740) 737-6006
https://www.myacpl.org
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/



------------------------------

Message: 3
Date: Tue, 19 Jul 2022 10:29:44 +0200
From: Paul Derscheid <paul.derscheid@lmscloud.de>
To: Owen Leonard <oleonard@myacpl.org>
Cc: Koha Devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Updating SCSS lint process to use stylelint
Message-ID: <EA9BA921-209D-4937-ADFB-1972BB6DB492@lmscloud.de>
Content-Type: text/plain;    charset=utf-8

Hi Owen,

I recently played around with the SCSS to create a more minimalist version of the bootstrap OPAC for LMSCloud.
I used the predefined rules and I think they’re reasonable choices (Although I didn’t cross every rule for sure).

Looking forward to stylint in Koha which I already use for some projects where I use stylus instead of SCSS. It’s a great tool.

Kind regards

Paul

--
LMSCloud GmbH
Paul Derscheid - Software Engineer
Konrad-Zuse-Platz 8 - D-81829 München
m +49 174 2436308
e paul.derscheid@lmscloud.de
w www.lmscloud.de

> On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
>
> Hi all,
>
> Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I
> added a linting configuration, .scss-lint.yml. I've always configured
> my editor to automatically lint SCSS using this configuration. I don't
> know if anyone else does this too.
>
> In VS Code I was using scss-lint for this, but it's now deprecated.
> They suggest stylelint instead: https://stylelint.io. I'd like to
> propose replacing .scss-lint.yml with .stylelintrc.json, transferring
> most of the same rules.
>
> It could be left up to the individual to install the dependencies, or
> I could update package.json. One nice thing about stylelint is that it
> has a "--fix" feature for some simple rules. This could be build into
> our gulp tasks.
>
> Has anyone else been linting SCSS? If so, does anyone have opinions
> about how our current rule set is working?
>
> -- Owen
>
> --
> Web Developer
> Athens County Public Libraries
> (740) 737-6006
> https://www.myacpl.org
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/



------------------------------

Subject: Digest Footer

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


------------------------------

End of Koha-devel Digest, Vol 200, Issue 19
*******************************************


NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.