Hi all,

Today's update:

Good news, master is no longer broken, but not fixed! :)

A new entry from koha-conf is going to be used: without <strict_sql_modes>1</strict_sql_modes> you will not be impacted by the recent failures.

We are going to turn it on for Jenkins.

I still recommend you to turn it on in order to catch inconsistencies in our code.

If you find bugs, you can create a new one and link it to the existing omnibus (bug 17258). Make sure it's not fixed yet, there a quite a bunch waiting in the bug tracker.

Waiting for a signoff:
Bug 21603 - Remove Group by clause in SearchCourses
Bug 21604 - Cannot add/edit funds, cannot add budgets
Bug 21606 - Issues with matching rules
Bug 21610 - Koha::Object->store needs to handle incorrect values
Bug 21612 - Incorrect GROUP BY in Koha::Virtualshelves

Waiting for a patch:

Bug 21605 - Cannot create EDI account

Cheers,

Jonathan

On Wed, 17 Oct 2018 at 20:38 Jonathan Druart <jonathan.druart@bugs.koha-community.org> wrote:

Hi devs,

I quick email to let you know that master and tests are (completely) broken because of the recent push of bug 20521.
It turned on the "problematic SQL modes" for dev installs (I let you search for that in your emails if it did not ring you the bell).

I am working on fixing the different test failures (the ones we introduced since bug 20144, 6 months ago). They are all regressions and there are a lot!

This shows us that we absolutely need this change, to alert us when we are doing something wrong, that's why I would not recommend a revert.

If you are stuck in something urgent/important you can revert
commit aafd0476342ca9691fd8a7c2c754c425ae1cf61f
Bug 20521: Enable problematic SQL modes for dev installs
Or easier, remove the dev_install flag in your koha-conf (but do not forget to switch it back in a few days!).

Cheers,
Jonathan