A new request with request id 18145 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is :

Title : Koha-devel Digest, Vol 186, Issue 19
Category :
Description :
Send Koha-devel mailing list submissions to
    koha-devel@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
    https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
    koha-devel-request@lists.koha-community.org

You can reach the person managing the list at
    koha-devel-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."


Today's Topics:

1. Release of Koha 20.11.06 (Fridolin SOMERS)
2. Release of Koha 20.05.12 (Andrew Fuerste-Henry)
3. Deadlock issues when running the tests in parallel, and maybe
not only in the tests? (Victor Grousset/tuxayo)
4. Re: Deadlock issues when running the tests in parallel, and
maybe not only in the tests? (Joonas Kylmälä)
5. Re: Deadlock issues when running the tests in parallel, and
maybe not only in the tests? (Joonas Kylmälä)
6. Re: Deadlock issues when running the tests in parallel, and
maybe not only in the tests? (Victor Grousset/tuxayo)


----------------------------------------------------------------------

Message: 1
Date: Tue, 25 May 2021 16:25:18 +0200
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel <koha-devel@lists.koha-community.org>,
    "koha@lists.katipo.co.nz" <koha@lists.katipo.co.nz>
Subject: [Koha-devel] Release of Koha 20.11.06
Message-ID: <6b3ad47c-f965-0bd8-bedc-82b68ae46e14@biblibre.com>
Content-Type: text/plain; charset=utf-8; format=flowed

Hello everyone 🤗

The Koha community is proud to announce the release of Koha 20.11.06.

It is a maintenance release with 3 security fixes.

The full release notes are available here:
https://koha-community.org/koha-20-11-06-released/

Debian packages should be available in a few days.

PS : 🌼

This is last release of 21.05 cycle.
I'll continue maintaining 20.11.x that will switch to 'oldstable'.

In 20.11.1889 was born Mr. Hubble https://en.wikipedia.org/wiki/Edwin_Hubble
So 20.11 is going to infinity ... and beyond 🚀

Best regards 🤓

--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France


------------------------------

Message: 2
Date: Tue, 25 May 2021 10:29:38 -0500
From: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Release of Koha 20.05.12
Message-ID:
    <CANGX5Dw8WE2bPQnvvrHvuEJuGQo4Lvgg-LK_F+=D02kBOE-jWw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

Hi all!

The Koha community is pleased to announce the release of Koha 20.05.12!
The full release notes can be found here:
https://koha-community.org/koha-20-05-12-released/

Thanks!
Andrew

--
Andrew Fuerste-Henry
Educator
(he/him/his)
ByWater Solutions
bywatersolutions.com
Phone:(888)900-8944 <(888)%20900-8944>

What is Koha? <http://bywatersolutions.com/what-is-koha/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210525/dfd9f8ab/attachment-0001.htm>

------------------------------

Message: 3
Date: Tue, 25 May 2021 17:45:20 +0200
From: Victor Grousset/tuxayo <victor@tuxayo.net>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Deadlock issues when running the tests in
    parallel, and maybe not only in the tests?
Message-ID: <b87d154b-1545-65f9-3549-94d9fcd8d164@tuxayo.net>
Content-Type: text/plain; charset=utf-8; format=flowed

Hi :)

IIUC this is where the CI calls "prove" to run the tests
https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L213

And this is the place where KOHA_PROVE_CPUS is set.
https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L155
It's not set in ".env" file so it should use "nproc" and this calls
"prove" with more than one thread.

Is that really the case? I tried locally use to "prove -j 4" and I'm
getting deadlocks with the database after a few minutes.

And do these deadlock in tests mean that Koha can hit them while running
in production?

I expect the tests to fail due to messing up with each other data but a
deadlock is something else.


Cheers,

--
Victor Grousset/tuxayo


------------------------------

Message: 4
Date: Tue, 25 May 2021 18:54:36 +0300
From: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
To: Victor Grousset/tuxayo <victor@tuxayo.net>
Cc: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Deadlock issues when running the tests in
    parallel, and maybe not only in the tests?
Message-ID: <bae47af1-fd40-9711-51bd-248837964ada@helsinki.fi>
Content-Type: text/plain; charset=utf-8

Hey Victor,

can you please check whether the $ENV{KOHA_TESTING} variable is set
correctly in your CI setup, and if it is not, does it fix the issue?
Please see the code in C4::Circulation::SendCirculationAlert(), it is
the only place where we do manual db locking as far as I know. It is
something we should fix by re-architecturing the message_queue database
table for digest messages. However, I'm interested in knowing if the
deadlocks now happen because of this and whether it is unit test
specific issue because at least based on the comments in
SendCirculationAlert() it appears to be so.

Regards,
Joonas

On 25/05/2021 18:45, Victor Grousset/tuxayo wrote:
> Hi :)
>
> IIUC this is where the CI calls "prove" to run the tests
> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L213
>
>
> And this is the place where KOHA_PROVE_CPUS is set.
> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L155
>
> It's not set in ".env" file so it should use "nproc" and this calls
> "prove" with more than one thread.
>
> Is that really the case? I tried locally use to "prove -j 4" and I'm
> getting deadlocks with the database after a few minutes.
>
> And do these deadlock in tests mean that Koha can hit them while running
> in production?
>
> I expect the tests to fail due to messing up with each other data but a
> deadlock is something else.
>
>
> Cheers,
>

--
Joonas Kylmälä
Tietojärjestelmäasiantuntija

Kansalliskirjasto
Kirjastoverkkopalvelut
PL 15 (Unioninkatu 36)
00014 Helsingin yliopisto


------------------------------

Message: 5
Date: Tue, 25 May 2021 19:00:50 +0300
From: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
To: Victor Grousset/tuxayo <victor@tuxayo.net>
Cc: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Deadlock issues when running the tests in
    parallel, and maybe not only in the tests?
Message-ID: <f563d919-2ee4-76c4-2b0a-cf164f3f959f@helsinki.fi>
Content-Type: text/plain; charset=utf-8

Hmm, based on the line
https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L204
I would think the ENV variable is actually set so maybe it is not this.
Any more info on the tables it locks on?

Regards,
Joonas

On 25/05/2021 18:54, Joonas Kylmälä wrote:
> Hey Victor,
>
> can you please check whether the $ENV{KOHA_TESTING} variable is set
> correctly in your CI setup, and if it is not, does it fix the issue?
> Please see the code in C4::Circulation::SendCirculationAlert(), it is
> the only place where we do manual db locking as far as I know. It is
> something we should fix by re-architecturing the message_queue database
> table for digest messages. However, I'm interested in knowing if the
> deadlocks now happen because of this and whether it is unit test
> specific issue because at least based on the comments in
> SendCirculationAlert() it appears to be so.
>
> Regards,
> Joonas
>
> On 25/05/2021 18:45, Victor Grousset/tuxayo wrote:
>> Hi :)
>>
>> IIUC this is where the CI calls "prove" to run the tests
>> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L213
>>
>>
>> And this is the place where KOHA_PROVE_CPUS is set.
>> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L155
>>
>> It's not set in ".env" file so it should use "nproc" and this calls
>> "prove" with more than one thread.
>>
>> Is that really the case? I tried locally use to "prove -j 4" and I'm
>> getting deadlocks with the database after a few minutes.
>>
>> And do these deadlock in tests mean that Koha can hit them while running
>> in production?
>>
>> I expect the tests to fail due to messing up with each other data but a
>> deadlock is something else.
>>
>>
>> Cheers,
>>
>

--
Joonas Kylmälä
Tietojärjestelmäasiantuntija

Kansalliskirjasto
Kirjastoverkkopalvelut
PL 15 (Unioninkatu 36)
00014 Helsingin yliopisto


------------------------------

Message: 6
Date: Tue, 25 May 2021 18:05:52 +0200
From: Victor Grousset/tuxayo <victor@tuxayo.net>
To: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Cc: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Deadlock issues when running the tests in
    parallel, and maybe not only in the tests?
Message-ID: <d4db783b-ca6c-a942-92e3-d03753839ad8@tuxayo.net>
Content-Type: text/plain; charset=utf-8; format=flowed

Hi :)

On 21-05-25 18:00, Joonas Kylmälä wrote:
> Hmm, based on the line
> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L204
> I would think the ENV variable is actually set so maybe it is not this.
> Any more info on the tables it locks on?

I did yet processed your previous message but here quickly the error
messages. Important info, it has been ran on 19.11.x

t/db_dependent/Charset.t ................................................ ok
===( 4190;485 797/? 0/? 17/47 2/15
)============================DBD::mysql::db do failed: Deadlock found
when trying to get lock; try restarting transaction [for Statement
"DELETE FROM issues"] at t/db_dependent/Circulation/Branch.t line 49.
===( 4191;486 797/? 0/? 17/47 3/15
)============================DBD::mysql::db do failed: Deadlock found
when trying to get lock; try restarting transaction [for Statement
"DELETE FROM items"] at t/db_dependent/Circulation.t line 1174.
# No tests run!

# Failed test 'No tests run for subtest
"AllowRenewalIfOtherItemsAvailable tests"'
# at t/db_dependent/Circulation.t line 1269.
DBD::mysql::db do failed: Deadlock found when trying to get lock; try
restarting transaction [for Statement "DELETE FROM items"] at
t/db_dependent/Circulation.t line 1174.
# Looks like your test exited with 255 just after 18.
t/db_dependent/Circulation.t
............................................ Dubious, test returned 255
(wstat 65280, 0xff00)






--
Victor Grousset/tuxayo


------------------------------

Subject: Digest Footer

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


------------------------------

End of Koha-devel Digest, Vol 186, Issue 19
*******************************************


NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.