Hi David,

could you expand on this? It’s intentional that autorenewal stops when a hold is placed. Do you want to change this behaviour?

Or would you like to get the “too soon” error message instead of the “on reserve” error message if both apply? Or a new message informing you about both?

What’s the benefit of checking whether it’s too early first?

Regards,

Holger

Von: koha-devel-bounces@lists.koha-community.org <koha-devel-bounces@lists.koha-community.org> Im Auftrag von David Cook
Gesendet: Freitag, 16. November 2018 05:58
An: koha-devel@lists.koha-community.org
Betreff: [Koha-devel] Autorenewals renewing an item then sending a renew failure email the next day

Hi all,

I’ve found a case where autorenewals will renew an item one day (e.g. Monday) and the next day (e.g. Tuesday) it will say that a hold has been found and that it can’t renew the item. (Someone must’ve put a hold on the item between the two cronjob runs.)

It seems to me this is a bug in how C4::Circulation::CanBookBeRenewed is written.

The first check it makes is for holds and if it finds a hold it returns an error.

However, if you’re using autorenewals, you should first check to see if it’s too early to even bother renewing.

I’m just emailing here to see if anyone else is having this issue, or if anyone knows if there is already a Bugzilla issue open for it. It seems like there are a lot of autorenewal Bugzilla issues but I couldn’t find anything. Figure asking first lessens the need for someone to mark one as a duplicate later.

David Cook

Systems Librarian

Prosentient Systems

72/330 Wattle St

Ultimo, NSW 2007

Australia

Office: 02 9212 0899

Direct: 02 8005 0595