Great many thanks for the patch, Jonathan!

Philippe Blouin,
Responsable du développement informatique

Tél.  : (888) 604-2627
philippe.blouin@inLibro.com

On 06/12/2018 12:11 PM, Jonathan Druart wrote:
 I opened it, see bug 20922.
I am going to provide a patch very soon.

On Tue, 12 Jun 2018 at 12:55 Jonathan Druart <jonathan.druart@bugs.koha-community.org> wrote:
It's a bug, please open a new bug report.
Indeed we should not use Koha::Object packages during the update database process, they are using the DBIx::Class schema. It's in the coding guidelines already ;)


On Tue, 12 Jun 2018 at 12:41 Philippe Blouin <philippe.blouin@inlibro.com> wrote:

Holà!

Currently migrating some 3.0 DB to 18.05.  A single hiccup with message_transport, no biggie.  Until...

16.06.00.042

Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher)
DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in 'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`, `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`, `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE ( `active` = ? )" with ParamValues: 0=1] at /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836.
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.p_sep_by_space' in 'field list' at /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209

Basically, the update code uses Koha::Number::Price, which in full modern object mode goes for its newly added p_sep_by_space in the 18.05 code.  But the DB doesn't have it yet (it comes with 17.12.00.022).

Big crash big time.  The process stops.

Any workaround? (didn't see anything in the list, nor bugzilla, did I miss it?).

Thanks,

PS this is bound to happen whenever Koha objects are used in updatedatabase.pl.

--
Philippe Blouin,
Responsable du développement informatique

Tél.  : (888) 604-2627
philippe.blouin@inLibro.com

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/