Thanks, Nick.
I added a comment on 20817 about why I think static/class methods are preferable to a Util module.
Cheers,
David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Nick Clemens
Sent: Saturday, 17 July 2021 5:20 AM
To: Koha Devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Helper/Static methods for objects
Hi All,
On two different bugs we have run into similar issues where a method was needed that didn't use the object directly.
On bug 28709 I proposed checking the ref of $self to see if this was called via the object - David Cook proposed adding a second method that is always called directly and calling that from the object method
On bug 20817 Kyle proposed a Koha::Util::Acquisition class and we could utilize that for other object as well, e.g. Koha::Util::Biblio, Koha::Util::Item
I put this on the agenda for the next dev meeting, I am sending it out here to get opinions and encourage attendance at that meeting to vote on a path forward.
-Nick
--
Phone: (888) 900-8944
Pronouns: (he/him/his)
Timezone: Eastern
Follow us:
