On 9/01/2014 7:11 am, "Jonathan Druart" <jonathan.druart@biblibre.com> wrote:
>
> Hi developers !
>
> I just finished to rewrite the discharge management system (bug 8007).
> It is my first try using DBIx Class into Koha and I really hope to have feedback on what I did.
> Please have a look to the unit tests file too, I found a big problem I did not manage to fix (/FIXME). So I cannot provide unit tests for all routines/methods and it was really boring to test :-/
> I hope we could find a way to fix this issue.
>
> It is more a poc than a clean patch series, I am completely open-minded on all changes in the code and the architecture. It is certainly not perfect and I am waiting for criticism.
>

I put some quick comments on the bug, using splinter review. Hopefully it is useful

Chris
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/