Send Koha-devel mailing list submissions to
koha-devel@lists.koha-community.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
koha-devel-request@lists.koha-community.org
You can reach the person managing the list at
koha-devel-owner@lists.koha-community.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."
Today's Topics:
1. Re: PUT /holds/:hold_id (Ere Maijala)
2. Koha logging out staff users (dcook@prosentient.com.au)
3. Re: Koha logging out staff users (Magnus Enger)
----------------------------------------------------------------------
Message: 1
Date: Wed, 19 May 2021 09:06:38 +0300
From: Ere Maijala <ere.maijala@helsinki.fi>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] PUT /holds/:hold_id
Message-ID: <aa9852a6-abf4-72c2-8546-3fec21fea3b3@helsinki.fi>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
Looks like bug 28369 is moving in the right direction. Whatever is
eventually done, it's important to not just remove or change existing
API functionality in the current API version. An API version should
remain back-compatible. Functionality can be deprecated, but it should
not be removed between Koha versions.
I think Innovative has found an acceptable balance with their Sierra
REST api versioning and deprecation policy. I'm not sure of all the
details, but basicly they've added a new version whenever there's a
backwards-incompatible change and kept the older API versions available
for a few versions. Then the oldest one gets deprecated, and in the next
major version or so it is removed. They also indicate which one is the
recommended API version to target.
A further note about the holds API endpoints: I can see the reasoning
behind the different endpoints for suspension, priority etc. but from an
API user's endpoint it's really convoluted to use. I'd really like a
PATCH method that would allow one to update priority, suspension and
it's end date and pickup location in a single request.
--Ere
Arthur kirjoitti 18.5.2021 klo 12.58:
> Hi Thomas, David,
>
> I vote for making it a PATCH route and either document the PUT method as
> "do-not-use" or making it a real "PUT".
>
> In my opinion making the api a v2 is going to make things confusing for
> consumers as there are already several web-services available for Koha
> (ILS-DI, OAI-PMH, SRU, Rest...).
>
> For each API version, consumer app must develop a new connector and a
> mechanism to select which connector is appropriate to use, this is going
> to be quite confusing + added complexity for api consumers.
>
> Unnecessary complexity in my opinion.
>
> Arthur Suzuki,
>
> BibLibre Support Developper
>
> On 18/05/2021 05:31, dcook@prosentient.com.au wrote:
>>
>> I’m not sure that I have much to contribute.
>>
>> One comment I would have is… what is the threshold for creating a V2
>> of the REST API?
>>
>> And maybe a breaking change for the API is OK for a major version
>> change in Koha but just not a minor version change? (That said, I’ve
>> encountered breaking changes in PostgreSQL on minor version updates.
>> They’re annoying, but they are a fact of life I suppose.)
>>
>> David Cook
>>
>> Software Engineer
>>
>> Prosentient Systems
>>
>> Suite 7.03
>>
>> 6a Glen St
>>
>> Milsons Point NSW 2061
>>
>> Australia
>>
>> Office: 02 9212 0899
>>
>> Online: 02 8005 0595
>>
>> *From:*Koha-devel <koha-devel-bounces@lists.koha-community.org> *On
>> Behalf Of *Tomas Cohen Arazi
>> *Sent:* Tuesday, 18 May 2021 7:05 AM
>> *To:* koha-devel <koha-devel@lists.koha-community.org>
>> *Subject:* [Koha-devel] PUT /holds/:hold_id
>>
>> Hi all, I wanted to gather some opinions about the mentioned route.
>>
>> We've made sure all routes have the additionalProperties: false
>> setting, and some routes, like this one, don't have it. In the task to
>> add it we noticed:
>>
>> 1. Theroute doesn't work as expected: the documented attributes don't
>> match the coding guidelines (i.e. terminology hasn't been adjusted on
>> the spec) but it did in the code, it just works because we don't set
>> additionalProperties: false. TL;DR no one following the spec can use it.
>> 2. The route seems to be wrong regarding how our RESTful
>> implementation works in the rest of the routes: PUT should get a
>> Koha::Hold object for updating it. Instead, it only 'accepts':
>> 'priority', 'pickup_library_id' and 'suspended_until'. If we wanted to
>> allow to selectively change those attributes, we should do a PATCH
>> instead.
>> 3. We already have individual routes for changing those things on the
>> hold:
>> PUT /holds/:hold_id/pickup_location
>> PUT /holds/:hold_id/priority
>> POST /holds/:hold_id/suspension
>>
>> The route itself doesn't work now. And any change will break things
>> for people 'using' it. And tests pass only because the spec is loose.
>> The options are:
>>
>> - 'Fix' the route so the attributes match the code, i.e. change the
>> spec as bug 20006 intended to do.
>>
>> - Leave it as-is (probably documenting it should not be used).
>>
>> - Remove the route until we really need to implement that PUT for
>> something.
>>
>> - Make it a PATCH route, in which we could add new attributes without
>> breaking anyone's dev (besides the verb change, that should be advertised)
>>
>> - Fully implement a PUT, making it mandatory to send all the
>> attributes (this would be an important breaking change).
>>
>> I would vote removing it, or making it a PATCH route. But I still
>> don't see the use case in the UI, for the latter. Most places in Koha
>> do atomic updates for priority, pickup location or hold suspension for
>> which we clearly have routes already.
>>
>> Looking forward to your comments.
>>
>> --
>>
>> Tomás Cohen Arazi
>>
>> Theke Solutions (http://theke.io <http://theke.io/>)
>> ✆+54 9351 3513384
>> GPG: B2F3C15F
>>
>>
>> _______________________________________________
>> Koha-devel mailing list
>> Koha-devel@lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website :https://www.koha-community.org/
>> git :https://git.koha-community.org/
>> bugs :https://bugs.koha-community.org/
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
--
Ere Maijala
Kansalliskirjasto / The National Library of Finland
------------------------------
Message: 2
Date: Wed, 19 May 2021 17:28:36 +1000
From: <dcook@prosentient.com.au>
To: "'koha-devel'" <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Koha logging out staff users
Message-ID: <02bd01d74c80$94cb3830$be61a890$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"
Hi all,
Does anyone have an issue where staff users are being logged out of Koha?
The session timeout threshold is 1d, and AutoLocation and
SessionRestrictionByIP are both disabled.
I can't think of any reason why they're getting logged out.
I also cannot reproduce the problem on my own workstation.
So just curious if people have heard of this happening. I've heard it from 2
libraries now.
David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210519/dca34f34/attachment-0001.htm>
------------------------------
Message: 3
Date: Wed, 19 May 2021 10:44:07 +0200
From: Magnus Enger <magnus@libriotech.no>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Koha logging out staff users
Message-ID: <cf9ebf79-dce6-c565-a4bc-76fc095ef94d@libriotech.no>
Content-Type: text/plain; charset=windows-1252; format=flowed
Den 19.05.2021 09:28, skrev dcook@prosentient.com.au:
> Hi all,
>
>
>
> Does anyone have an issue where staff users are being logged out of Koha?
What is the setting for SessionStorage?
Is everyone logged out at the same time, or is it more random?
Best regards,
Magnus
Libriotech AS
------------------------------
Subject: Digest Footer
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
------------------------------
End of Koha-devel Digest, Vol 186, Issue 16
*******************************************