Send Koha-devel mailing list submissions to
    koha-devel@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
    https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
    koha-devel-request@lists.koha-community.org

You can reach the person managing the list at
    koha-devel-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."


Today's Topics:

1. New pushes, new KTD images (Tomas Cohen Arazi)
2. ERM - workflow change (Tomas Cohen Arazi)
3. Re: OIDC client pushed to master! (Tomas Cohen Arazi)
4. Re: ERM - workflow change (Renvoize, Martin)
5. Re: ERM - workflow change (David Cook)


----------------------------------------------------------------------

Message: 1
Date: Wed, 9 Nov 2022 09:42:37 -0300
From: Tomas Cohen Arazi <tomascohen@gmail.com>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] New pushes, new KTD images
Message-ID:
    <CABZfb=Vf1U4v94Xq0QZB=hHANnHpgci8dF4zA81trymmid9ZPA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

Hi all, both ERM and the OIDC/OAuth2 integration have been pushed. As some
of you noted, they have new dependencies. New KTD images have been built
before pushing to avoid issues, so please do the usual so things keep
working:

$ ktd pull

Best regards

PS: If you use other ktd flags, you can also pull like:

$ ktd --selenium --es7 --sso pull

--
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20221109/840e0c5a/attachment-0001.htm>

------------------------------

Message: 2
Date: Wed, 9 Nov 2022 12:53:49 -0300
From: Tomas Cohen Arazi <tomascohen@gmail.com>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] ERM - workflow change
Message-ID:
    <CABZfb=Wn5xjvZ4rOuSYsaEzsz8XX-aOLwxz-41aRhUWD2WEMAg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

Hi all, we pushed ERM but didn't communicate some decisions made:

- For running the ERM component (and in the future any other Vue-driven
thing) a build step needs to happen. Either:

$ yarn build_js

or (the dev-oriented version):

$ yarn watch_js

- We could've gone 'the SCSS' way, in which the RM(aint) compiles the thing
and pushes to Git along with the changes. But we decided it would have an
impact on the size of the repository pretty fast. So for now, the decision
is we will do it at release time. This is also common practice on Vue
projects.

- We could add the build as part of the 'reset_all' command KTD users are
familiar with. TBD

- Yes, now that running Koha requires a build step, we could just add SCSS
there, that's to be discussed early next cycle.

- We need a way to pre-bundle all the dependencies in KTD, so people can
fire up KTD while being offline. Agustín is wrapping up a proposal for
this. TBD

Please share your thoughts, and sorry for not communicating this earlier.

--
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20221109/973145bb/attachment-0001.htm>

------------------------------

Message: 3
Date: Wed, 9 Nov 2022 13:32:08 -0300
From: Tomas Cohen Arazi <tomascohen@gmail.com>
To: David Cook <dcook@prosentient.com.au>
Cc: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] OIDC client pushed to master!
Message-ID:
    <CABZfb=U0jV==mx3qv=i8AGO0rTJvpdXN-m5ZtpjYYTFSqiB7Ew@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

Thank you David for all your valuable input. Looking forward to those
follow-ups.

El mar, 8 nov 2022 a las 23:36, David Cook (<dcook@prosentient.com.au>)
escribió:

> I was pumped to see this morning that the OIDC client was pushed to master!
>
>
>
> I have 2 very easy follow-ups that I think are necessary before the
> feature is prod ready, so if someone could take a look at those, that would
> be awesome.
>
>
>
> Bug 32138 - OIDC client uses backwards default mapping
>
> Bug 32139 - "Update on login" setting not set when creating domain from
> new IdP page
>
>
>
> A nice to have would also be the following although not necessary from a
> functionality point of view:
>
> Bug 32141 - New and Edit Identity Provider UIs inconsistent
>
>
>
> Thanks!
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>


--
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20221109/3dbcf76f/attachment-0001.htm>

------------------------------

Message: 4
Date: Wed, 9 Nov 2022 17:33:30 +0000
From: "Renvoize, Martin" <martin.renvoize@ptfs-europe.com>
To: Koha Devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] ERM - workflow change
Message-ID:
    <CAB7SL8DLU-kOp9EYDhWCWUwT+csR12XR28eciizhY7G4G5LWmw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

To get up and running fast in k-t-d,

kshell
$ kshell
k$ yarn install
k$ yarn build_js



On Wed, 9 Nov 2022, 3:54 pm Tomas Cohen Arazi, <tomascohen@gmail.com> wrote:

> Hi all, we pushed ERM but didn't communicate some decisions made:
>
> - For running the ERM component (and in the future any other Vue-driven
> thing) a build step needs to happen. Either:
>
> $ yarn build_js
>
> or (the dev-oriented version):
>
> $ yarn watch_js
>
> - We could've gone 'the SCSS' way, in which the RM(aint) compiles the
> thing and pushes to Git along with the changes. But we decided it would
> have an impact on the size of the repository pretty fast. So for now, the
> decision is we will do it at release time. This is also common practice on
> Vue projects.
>
> - We could add the build as part of the 'reset_all' command KTD users are
> familiar with. TBD
>
> - Yes, now that running Koha requires a build step, we could just add SCSS
> there, that's to be discussed early next cycle.
>
> - We need a way to pre-bundle all the dependencies in KTD, so people can
> fire up KTD while being offline. Agustín is wrapping up a proposal for
> this. TBD
>
> Please share your thoughts, and sorry for not communicating this earlier.
>
> --
> Tomás Cohen Arazi
> Theke Solutions (http://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20221109/10c7835e/attachment-0001.htm>

------------------------------

Message: 5
Date: Thu, 10 Nov 2022 09:28:00 +1100
From: "David Cook" <dcook@prosentient.com.au>
To: "'Tomas Cohen Arazi'" <tomascohen@gmail.com>, "'koha-devel'"
    <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] ERM - workflow change
Message-ID: <044a01d8f48a$8779cbc0$966d6340$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"

I’ll have to think more about it and have a play…



In terms of regular koha-testing-docker dev/test usage, I think that you’d only need to build once in a while (unless you’re changing ERM code)? So I’m not too worried about this.



But how does the yarn build factor into building Koha packages? Do we need to add the yarn build to the debian/rules file? Or would we change “debian/build-git-snapshot” to unpack the “git archive”, do the yarn build, and then re-package and pass to pdebuild?



David Cook

Senior Software Engineer

Prosentient Systems

Suite 7.03

6a Glen St

Milsons Point NSW 2061

Australia



Office: 02 9212 0899

Online: 02 8005 0595



From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Tomas Cohen Arazi
Sent: Thursday, 10 November 2022 2:54 AM
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] ERM - workflow change



Hi all, we pushed ERM but didn't communicate some decisions made:



- For running the ERM component (and in the future any other Vue-driven thing) a build step needs to happen. Either:



$ yarn build_js



or (the dev-oriented version):



$ yarn watch_js



- We could've gone 'the SCSS' way, in which the RM(aint) compiles the thing and pushes to Git along with the changes. But we decided it would have an impact on the size of the repository pretty fast. So for now, the decision is we will do it at release time. This is also common practice on Vue projects.



- We could add the build as part of the 'reset_all' command KTD users are familiar with. TBD



- Yes, now that running Koha requires a build step, we could just add SCSS there, that's to be discussed early next cycle.



- We need a way to pre-bundle all the dependencies in KTD, so people can fire up KTD while being offline. Agustín is wrapping up a proposal for this. TBD




Please share your thoughts, and sorry for not communicating this earlier.



--

Tomás Cohen Arazi

Theke Solutions (http://theke.io <http://theke.io/> )
✆ +54 9351 3513384
GPG: B2F3C15F

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20221110/e540fc42/attachment.htm>

------------------------------

Subject: Digest Footer

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


------------------------------

End of Koha-devel Digest, Vol 204, Issue 4
******************************************