Send Koha-devel mailing list submissions to
    koha-devel@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
    https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
    koha-devel-request@lists.koha-community.org

You can reach the person managing the list at
    koha-devel-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."


Today's Topics:

1. Re: Second look needed on a few (2!) lines related to plugins
(Victor Grousset/tuxayo)
2. Re: Second look needed on a few (2!) lines related to plugins
(dcook@prosentient.com.au)
3. Re: Switching from SysV to Systemd for koha-common service
(dcook@prosentient.com.au)


----------------------------------------------------------------------

Message: 1
Date: Tue, 30 Mar 2021 17:48:43 +0200
From: Victor Grousset/tuxayo <victor@tuxayo.net>
To: Mason James <mtj@kohaaloha.com>, koha-devel
    <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Second look needed on a few (2!) lines
    related to plugins
Message-ID: <44ddc466-06b9-8915-f3cd-e8a420eb465c@tuxayo.net>
Content-Type: text/plain; charset=utf-8; format=flowed

On 21-03-30 01:31, Mason James wrote:
> hiya, here's some info...
>
> https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm

Indeed there is a trinary, but it's about if it makes sense to do "those
things" related to plugins. Is that useful, is that valid, is that enough?

Cheers,

--
Victor Grousset/tuxayo


------------------------------

Message: 2
Date: Wed, 31 Mar 2021 09:20:05 +1100
From: <dcook@prosentient.com.au>
To: "'Fridolin SOMERS'" <fridolin.somers@biblibre.com>,
    <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Second look needed on a few (2!) lines
    related to plugins
Message-ID: <02d401d725b2$d6242b60$826c8220$@prosentient.com.au>
Content-Type: text/plain;    charset="utf-8"

I wrote the patch close to a year ago so I have no idea why I used the syntax that I did. I think maybe I was copying what was already there for the search feature at the time.

But I'm happy for people to change it!

And thanks for the compliment. I do like this feature!

David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia

Office: 02 9212 0899
Online: 02 8005 0595

-----Original Message-----
From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS
Sent: Tuesday, 30 March 2021 6:08 PM
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins

Hi,

In my opinion this syntax looks strange.
I'd prefer :
my $filter = { uploadcategorycode => $browsecategory };
$filter{public} = 1 if $plugin;
$uploads = Koha::UploadedFiles->search($filter)->unblessed;

Super cool enhancement BTW ;)

Best regards,

Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
> Hi :)
>
> It's about Bug 25476 - Uploaded files can't be easily browsed via
> upload.pl
>
> There are two lines in the patch that are out of my knowledge to QA:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
>
> [% PROCESS plugin_pars %]
> [...]
> $plugin? ( public => 1 ): ()
>
> Does this look familiar to anyone?
>
> Cheers,
>

--
Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄
BibLibre, France
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/




------------------------------

Message: 3
Date: Wed, 31 Mar 2021 09:35:22 +1100
From: <dcook@prosentient.com.au>
To: "'Fridolin SOMERS'" <fridolin.somers@biblibre.com>,
    <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Switching from SysV to Systemd for
    koha-common service
Message-ID: <02d501d725b4$f8abd230$ea037690$@prosentient.com.au>
Content-Type: text/plain;    charset="utf-8"

Hi Frido,

You only have 1 Koha per server? That's amazing.

I agree about using %i. With the koha-worker systemd service, we've done that. (Bug 26363 and 27844)

I suppose the way to make a global koha-common would be to have individual systemd units for each of the individual services and then have koha-common as the parent service. I manage a different system where I control a few daemons via a parent systemd service and it works quite well.

The only thing with that is that we'd have to re-write everything to use systemd heh. Not that I'm opposed to that, although - as Tomas noted - it would make things tougher to do in containers in the short-term.

Sometimes, I wish that I had all the time and money to make these things happen. I am extra short on time at the moment, so no plans to work on this any time soon.

David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia

Office: 02 9212 0899
Online: 02 8005 0595

-----Original Message-----
From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS
Sent: Tuesday, 30 March 2021 7:08 PM
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Switching from SysV to Systemd for koha-common service

Hi,

Very good idea :D

We at Biblibre have build a systemd unit for Starman and Zebra, it is quite simple. But we dont use several Koha.

In ordre to implement for several Koha, I think we should use %i vars in systemd unit.
Like it is in openvpn :
https://github.com/OpenVPN/openvpn/blob/master/distro/systemd/openvpn-client%40.service.in

It allows to call any unit (for example demo Koha) :
systemctl start koha-common@demo.

About restart :
I see you can define a different kill signal than stop :
https://www.freedesktop.org/software/systemd/man/systemd.kill.html#RestartKillSignal=

But you may use "reload" action instead :
https://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecReload=

We use reload for starman it is more soft (it acts like apache gracefull restart).

I attach some files here :
https://git.biblibre.com/biblibre/koha-nginx/src/branch/master/etc/systemd/system

Feel free to ask for help.

Best regards,

Le 25/03/2021 à 04:42, dcook@prosentient.com.au a écrit :
> Hi all,
>
> I was just installing koha-common, as you do, and I noticed the
> following warning:
>
> Failed to enable unit: Unit
> /run/systemd/generator.late/koha-common.service is transient or generated.
>
> This is the product of the following command: “update-rc.d koha-common
> enable”
>
> I think I was able to work around it by running the following:
> “/lib/systemd/systemd-sysv-install enable koha-common”
>
> However, I’m thinking it is probably time to switch koha-common from
> SysV to Systemd. We’ll lose a bit of functionality for the “status”
> option, but otherwise it shouldn’t be too bad. I think we’ll lose the
> “restart” as well as I think the systemd restart is a “stop” and “start”.
>
> David Cook
>
> Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/ git :
> https://git.koha-community.org/ bugs :
> https://bugs.koha-community.org/
>

--
Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄
BibLibre, France
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/




------------------------------

Subject: Digest Footer

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/


------------------------------

End of Koha-devel Digest, Vol 184, Issue 25
*******************************************