My personal preference if to write the most portable code practical. As such, I'd prefer changing the prompt to "Press enter to continue.", and keep the hashbang set to #!/bin/sh, but that's more because I lean toward the old school "more portability is better" and less because I think that there's a *real* argument to be made there, given that we've already decided that debian is the standard platform for Koha... (and realistically, who *doesn't* have bash? You can run it under Windows, even).

dash is the Debian implementation of POSIX shell. It tends to adhere strictly to the POSIX standard. I would say that it should preferred over bash in the following cases:

* The script might, at some point in the future be run from /etc/init.d/

* The script itself is processor intensive - dash is faster than bash.

--Barton