A new request with request id 16566 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is :
Title : Koha-devel Digest, Vol 189, Issue 4
Category :
Description : Send Koha-devel mailing list submissions to
koha-devel@lists.koha-community.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
koha-devel-request@lists.koha-community.org
You can reach the person managing the list at
koha-devel-owner@lists.koha-community.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."
Today's Topics:
1. Check of syspref editor with DB columns (Fridolin SOMERS)
2. Re: Zebra Trivia (Fridolin SOMERS)
3. Re: Bug 17600 (Standardize the EXPORT) is pushed (Fridolin SOMERS)
4. Re: Check of syspref editor with DB columns
(dcook@prosentient.com.au)
5. Re: Zebra Trivia (dcook@prosentient.com.au)
6. Re: Bug 17600 (Standardize the EXPORT) is pushed (Jonathan Druart)
----------------------------------------------------------------------
Message: 1
Date: Tue, 10 Aug 2021 11:33:41 -1000
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Check of syspref editor with DB columns
Message-ID: <20d38b1d-c6ec-59a5-51c1-3879e80254e3@biblibre.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
Since 22844, preferences like BorrowerUnwantedField and
BorrowerMandatoryField show a modal selection of DB columns.
This relies on
/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json
Unwanted fields are hidden in template using :
[% UNLESS nofield %]
Mandatory fields have attribute require in template using :
[% IF mandatoryfield %]
Big problem is how do we maintain this ???
For example I see in template memberentrygen.tt :
[% UNLESS noautorenew_checkouts %]
But this column is not in borrowers.json :(
I'm made some checks :
grep '% UNLESS no'
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | awk
-F 'UNLESS ' '{print $2}' | tr -d '%]' | sort -u
egrep 'mandatory\w'
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | awk
-F 'mandatory' '{print $2}' | tr -d ' %])' | sort -u
Plus some manual work.
My conclusion :
Are missing from borrowers.json (used by nofield and/or mandatoryfield) :
- autorenew_checkouts
- relationship
- sms_provider_id
- sort1
- sort2
Are useless in borrowers.json :
- categorycode : obviously mandatory ?
- smsalertnumber : in form the field is now SMSnumber, but no
noSMSnumber/mandarorySMSnumber in template
I will create a bug report for autorenew_checkouts first.
Maybe we could add something in QA tools ?
Best regards,
PS :
Also not very clear, BorrowerMandatoryField shows all fields but in
template there is only :
mandatoryborrowernotes
mandatorycardnumber
mandatorycontactfirstname
mandatorycontactname
mandatorydateenrolled
mandatorydateexpiry
mandatorydateofbirth
mandatoryemail
mandatoryemailpro
mandatoryfax
mandatoryfirstname
mandatoryinitials
mandatorymobile
mandatoryopacnote
mandatoryothernames
mandatorypassword
mandatoryphone
mandatoryphonepro
mandatoryprimary_contact_method
mandatorysort1
mandatorysort2
mandatorysurname
mandatorytitle
mandatoryuserid
mandatorypassword
We should add other fields in exclusions ?
--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France
------------------------------
Message: 2
Date: Tue, 10 Aug 2021 12:56:33 -1000
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Zebra Trivia
Message-ID: <4b569fb8-fd53-fbdd-5e75-0e189b192270@biblibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Beuuuuuu (sound of a GNU looking at a Zebra).
Why on earth is there this 4=6 in ccl.properties ?
THis is usefull for field type (date, numeric ...) or truncation, but
never for phrase/wrdl ...
The (only) doc from Indexdata :
https://software.indexdata.com/zebra/doc/querymodel-rpn.html#querymodel-bib1-structure
Best regards,
Le 21/07/2021 Ă 13:36, dcook@prosentient.com.au a Ă©crit :
> Hi all,
>
> Today I learned (or maybe re-learned) something about Zebra CCL syntax:
>
> “Identifier-standard,phr” does not do a phrase search. It does a word
> list search. Now you might this this is impossible, but it’s not,
> because Identifier-standard is hard-coded with 4=6 in ccl.properties:
> Identifier-standard 1=1007 4=6
>
> Since Identifier-standard has already set the “4” structure attribute,
> “phr” does nothing.u
>
> However, if you write “phr,Identifier-standard”, it will do a phrase
> search. That’s because the “phr” sets the “4” structure attribute before
> the “Identifier-standard” gets converted into PQF/RPN.
>
> Cool, n’est-ce pas?
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France
------------------------------
Message: 3
Date: Tue, 10 Aug 2021 13:04:09 -1000
From: Fridolin SOMERS <fridolin.somers@biblibre.com>
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Bug 17600 (Standardize the EXPORT) is pushed
Message-ID: <79b769c4-172d-a12e-d38c-3e5bfb8eb501@biblibre.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
Do we need to impact Koha plugins ?
Best regards,
Le 15/07/2021 Ă 21:02, Jonathan Druart a Ă©crit :
> Hi,
> I've just pushed bug 17600, it's a massive patch (1311 files changed,
> 4077 insertions(+), 4362 deletions(-)) that will cause conflicts with
> a lot of other patches in the queue.
>
> I've described in the commit message what it is doing, please read it.
>
> Most of the time the changes it brings are trivial but be careful when
> you resolve the conflicts. Ping me if you need help.
>
> Enjoy your weekend!
> Jonathan
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
--
Fridolin SOMERS <fridolin.somers@biblibre.com>
Software and system maintainer 🦄
BibLibre, France
------------------------------
Message: 4
Date: Wed, 11 Aug 2021 09:56:45 +1000
From: <dcook@prosentient.com.au>
To: "'Fridolin SOMERS'" <fridolin.somers@biblibre.com>, "'koha-devel'"
<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Check of syspref editor with DB columns
Message-ID: <032901d78e43$60455af0$20d010d0$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"
Good questions, Fridolin. I ended up adding sort1 and sort2 locally to borrowers.json. I've been so busy I hadn't even thought of upstreaming yet I think.
David Cook
Senior Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
-----Original Message-----
From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS
Sent: Wednesday, 11 August 2021 7:34 AM
To: koha-devel <koha-devel@lists.koha-community.org>
Subject: [Koha-devel] Check of syspref editor with DB columns
Hi,
Since 22844, preferences like BorrowerUnwantedField and BorrowerMandatoryField show a modal selection of DB columns.
This relies on
/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json
Unwanted fields are hidden in template using :
[% UNLESS nofield %]
Mandatory fields have attribute require in template using :
[% IF mandatoryfield %]
Big problem is how do we maintain this ???
For example I see in template memberentrygen.tt :
[% UNLESS noautorenew_checkouts %]
But this column is not in borrowers.json :(
I'm made some checks :
grep '% UNLESS no'
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | awk -F 'UNLESS ' '{print $2}' | tr -d '%]' | sort -u egrep 'mandatory\w'
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | awk -F 'mandatory' '{print $2}' | tr -d ' %])' | sort -u Plus some manual work.
My conclusion :
Are missing from borrowers.json (used by nofield and/or mandatoryfield) :
- autorenew_checkouts
- relationship
- sms_provider_id
- sort1
- sort2
Are useless in borrowers.json :
- categorycode : obviously mandatory ?
- smsalertnumber : in form the field is now SMSnumber, but no noSMSnumber/mandarorySMSnumber in template
I will create a bug report for autorenew_checkouts first.
Maybe we could add something in QA tools ?
Best regards,
PS :
Also not very clear, BorrowerMandatoryField shows all fields but in template there is only :
mandatoryborrowernotes
mandatorycardnumber
mandatorycontactfirstname
mandatorycontactname
mandatorydateenrolled
mandatorydateexpiry
mandatorydateofbirth
mandatoryemail
mandatoryemailpro
mandatoryfax
mandatoryfirstname
mandatoryinitials
mandatorymobile
mandatoryopacnote
mandatoryothernames
mandatorypassword
mandatoryphone
mandatoryphonepro
mandatoryprimary_contact_method
mandatorysort1
mandatorysort2
mandatorysurname
mandatorytitle
mandatoryuserid
mandatorypassword
We should add other fields in exclusions ?
--
Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄
BibLibre, France
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
------------------------------
Message: 5
Date: Wed, 11 Aug 2021 09:58:21 +1000
From: <dcook@prosentient.com.au>
To: "'Fridolin SOMERS'" <fridolin.somers@biblibre.com>,
<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Zebra Trivia
Message-ID: <032a01d78e43$9995bfc0$ccc13f40$@prosentient.com.au>
Content-Type: text/plain; charset="utf-8"
Hahaha. That made my morning, Frido.
I have no idea why Identifier-standard is set up that way. It might be worth doing a git-blame at some point.
David Cook
Senior Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
-----Original Message-----
From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS
Sent: Wednesday, 11 August 2021 8:57 AM
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Zebra Trivia
Beuuuuuu (sound of a GNU looking at a Zebra).
Why on earth is there this 4=6 in ccl.properties ?
THis is usefull for field type (date, numeric ...) or truncation, but never for phrase/wrdl ...
The (only) doc from Indexdata :
https://software.indexdata.com/zebra/doc/querymodel-rpn.html#querymodel-bib1-structure
Best regards,
Le 21/07/2021 Ă 13:36, dcook@prosentient.com.au a Ă©crit :
> Hi all,
>
> Today I learned (or maybe re-learned) something about Zebra CCL syntax:
>
> “Identifier-standard,phr” does not do a phrase search. It does a word
> list search. Now you might this this is impossible, but it’s not,
> because Identifier-standard is hard-coded with 4=6 in ccl.properties:
> Identifier-standard 1=1007 4=6
>
> Since Identifier-standard has already set the “4” structure attribute,
> “phr” does nothing.u
>
> However, if you write “phr,Identifier-standard”, it will do a phrase
> search. That’s because the “phr” sets the “4” structure attribute
> before the “Identifier-standard” gets converted into PQF/RPN.
>
> Cool, n’est-ce pas?
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/ git :
> https://git.koha-community.org/ bugs :
> https://bugs.koha-community.org/
>
--
Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄
BibLibre, France
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
------------------------------
Message: 6
Date: Wed, 11 Aug 2021 11:48:28 +0200
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
To: Fridolin SOMERS <fridolin.somers@biblibre.com>
Cc: koha-devel <koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Bug 17600 (Standardize the EXPORT) is pushed
Message-ID:
<CAJzKNY6BNUNPfGyA0tKR-R86_WKSR_Sdh8rsSKaqys8a_zhxfg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
It may break plugins using modules that were using EXPORT and now EXPORT_OK
Le mer. 11 août 2021 à 01:04, Fridolin SOMERS <fridolin.somers@biblibre.com>
a Ă©crit :
> Hi,
>
> Do we need to impact Koha plugins ?
>
> Best regards,
>
> Le 15/07/2021 Ă 21:02, Jonathan Druart a Ă©crit :
> > Hi,
> > I've just pushed bug 17600, it's a massive patch (1311 files changed,
> > 4077 insertions(+), 4362 deletions(-)) that will cause conflicts with
> > a lot of other patches in the queue.
> >
> > I've described in the commit message what it is doing, please read it.
> >
> > Most of the time the changes it brings are trivial but be careful when
> > you resolve the conflicts. Ping me if you need help.
> >
> > Enjoy your weekend!
> > Jonathan
> > _______________________________________________
> > Koha-devel mailing list
> > Koha-devel@lists.koha-community.org
> > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> > website : https://www.koha-community.org/
> > git : https://git.koha-community.org/
> > bugs : https://bugs.koha-community.org/
> >
>
> --
> Fridolin SOMERS <fridolin.somers@biblibre.com>
> Software and system maintainer 🦄
> BibLibre, France
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210811/aae5a225/attachment.htm>
------------------------------
Subject: Digest Footer
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
------------------------------
End of Koha-devel Digest, Vol 189, Issue 4
******************************************
NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.