A new request with request id 17508 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is :
Title : Koha-devel Digest, Vol 187, Issue 15
Category :
Description : Send Koha-devel mailing list submissions to
koha-devel@lists.koha-community.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
koha-devel-request@lists.koha-community.org
You can reach the person managing the list at
koha-devel-owner@lists.koha-community.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."
Today's Topics:
1. Re: Follow-up patches and why not to use them (Joonas Kylmälä)
2. Re: Follow-up patches and why not to use them (Marcel de Rooy)
----------------------------------------------------------------------
Message: 1
Date: Fri, 18 Jun 2021 10:35:39 +0300
From: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
To: Marcel de Rooy <M.de.Rooy@rijksmuseum.nl>, koha-devel
<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Follow-up patches and why not to use them
Message-ID: <56d5f1a4-3d99-a851-c044-6184e949ba19@helsinki.fi>
Content-Type: text/plain; charset=utf-8
Hi Marcel,
On 18/06/2021 09:45, Marcel de Rooy wrote:
> Agree with Julian here. It depends.
> You could squash follow-up patches yourself too before reverting them?
> In some cases patches tell us a nice story, in a lot of cases it might
> be confusing or messy..
I think you might not have seen yet my follow-up email yet to Julian
sent on the 7th of June. Basically squashing or reverting blindly is not
an option when you want to review that the changes make sense on top of
the new code base. Then the "nice story" or "confusing/messy story"
part: as I said in the follow-up email to Julian my wish was to have as
well commits with one logical change in each so then we should have
*always* a nice story to read.
Would love to hear your opinion now with these points clarified.
Joonas
------------------------------
Message: 2
Date: Fri, 18 Jun 2021 09:40:47 +0200
From: Marcel de Rooy <rooy.de.m@gmail.com>
To: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Cc: Marcel de Rooy <M.de.Rooy@rijksmuseum.nl>, koha-devel
<koha-devel@lists.koha-community.org>
Subject: Re: [Koha-devel] Follow-up patches and why not to use them
Message-ID:
<CAGv4ghb7_mjPPRO8XK+9gG=dkh5=VG6=w28h-JpCrExWfqKz7g@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Yeah I probably missed it while catching up ;)
What you say makes sense, but the problem probably boils down to the gap
between theory and practice.
Op vr 18 jun. 2021 om 09:36 schreef Joonas Kylmälä <
joonas.kylmala@helsinki.fi>:
> Hi Marcel,
>
> On 18/06/2021 09:45, Marcel de Rooy wrote:
> > Agree with Julian here. It depends.
> > You could squash follow-up patches yourself too before reverting them?
> > In some cases patches tell us a nice story, in a lot of cases it might
> > be confusing or messy..
>
> I think you might not have seen yet my follow-up email yet to Julian
> sent on the 7th of June. Basically squashing or reverting blindly is not
> an option when you want to review that the changes make sense on top of
> the new code base. Then the "nice story" or "confusing/messy story"
> part: as I said in the follow-up email to Julian my wish was to have as
> well commits with one logical change in each so then we should have
> *always* a nice story to read.
>
> Would love to hear your opinion now with these points clarified.
>
> Joonas
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/34caaa89/attachment-0001.htm>
------------------------------
Subject: Digest Footer
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
------------------------------
End of Koha-devel Digest, Vol 187, Issue 15
*******************************************
NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.