Hi to all,
I try to test the patches with .bywater sandboxes, but they don't apply.
In provision log I read:
TASK [Apply bug 29602 via git-bz in docker container] **************************
fatal: [localhost -> koha-nicetrad]: FAILED! => {"changed": true, 
"cmd": "cd /kohadevbox/koha && yes | git bz apply 29602", "delta": "0:00:06.139954", "end": "2022-04-02 10:00:04.110333", 
"msg": "non-zero return code", "rc": 1, "start": "2022-04-02 09:59:57.970379", 
"stderr": "Traceback (most recent call last):\n  File \"/usr/bin/git-bz\", line 2716, in <module>\n    applied = do_apply(bug_ref)\n  File \"/usr/bin/git-bz\", line 1791, in do_apply\n    print \"%d - %s\" % (patch.attach_id, patch.description)\nUnicodeEncodeError: 'ascii' codec can't encode character u'\\u2192' in position 56: ordinal not in range(128)", 
"stderr_lines": ["Traceback (most recent call last):", "  File \"/usr/bin/git-bz\", line 2716, in <module>", "    applied = do_apply(bug_ref)", "  File \"/usr/bin/git-bz\", line 1791, in do_apply", "    print \"%d - %s\" % (patch.attach_id, patch.description)", "UnicodeEncodeError: 'ascii' codec can't encode character u'\\u2192' in position 56: ordinal not in range(128)"], 
"stdout": "\nBug 29602 - We must be nicer with translators", "stdout_lines": ["", "Bug 29602 - We must be nicer with translators"]}
I'm not sure those are patches for sandboxes, but in fact they have at least an error about Unicode.
The sandbox is here: https://sandbox.bywatersolutions.com/, name 'nicetrad'
Cheers
Zeno Tajoli



On Sat, Mar 19, 2022 at 5:23 PM Victor Grousset/tuxayo <victor@tuxayo.net> wrote:
Hi,

After a few iterations of testing and fixes, bug 29602 looks about
ready. It mostly needs someone else to signoff by testing that pages are
not broken.
Here is a ticket with a link to the comment listing most of the impacted
pages:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602#c50
Rereading the last follow-up patches would also help.

Let me know if I can be of any help.

Cheers,

--
Victor Grousset/tuxayo
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/